From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: add notice for planned name size change
Date: Tue, 08 Aug 2017 11:47:02 +0200 [thread overview]
Message-ID: <24236398.BWkRJ1PWcL@xps> (raw)
In-Reply-To: <VI1PR05MB3149C4C9A7822E4078E40BACC38A0@VI1PR05MB3149.eurprd05.prod.outlook.com>
> > > VMBUS support will use GUID in eth_dev_data name field which requires
> > > at least 37 characters. Plan for increase in size now.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > ---
> > > +* ethdev: An ABI change is planned for 17.11 for the structure
> > eth_dev_data.
> > Isn't it better to use "``rte_eth_dev_data``"?
> >
> > > + The size of the unique name will increase RTE_ETH_NAME_MAX_LEN
> > from
> > > + 32 to
> > > + 64 characters to allow using a globally unique identifier (GUID) in this
> > field.
> >
> > Except for the small comment above,
> > Acked-by: Yongseok Koh <yskoh@mellanox.com>
>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks
prev parent reply other threads:[~2017-08-08 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170706150751.27251-1-stephen@networkplumber.org>
2017-08-07 22:19 ` Yongseok Koh
2017-08-08 4:56 ` Shahaf Shuler
2017-08-08 9:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24236398.BWkRJ1PWcL@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stephen@networkplumber.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).