From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 22DAA1B425; Wed, 9 May 2018 15:26:39 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9AA23229DF; Wed, 9 May 2018 09:26:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 09 May 2018 09:26:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=motOTHNwbSwH+jJsfSLGUe3y8I 3L0Fq+DtEVK+bbTgs=; b=Rv670dRjNXAwA8A52JrqZebiSh9DxaNXgg7hBghoKI e2kukjzFrmbs89NCYrNAmCL3yFaG6Y2E2QvnYiDMkmeg9dHABSW+JzO/WmXpO56D uOCxgq/cKzdcAG7iJiYssqF25i+ZvQzit8A201OpXUj6JjdcmudOHVKOJkzpSipK s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=motOTH NwbSwH+jJsfSLGUe3y8I3L0Fq+DtEVK+bbTgs=; b=ONBK6RQKy8nqzIz4F1dgZu jL918u3MSxq3IkPN9AHEsUkq4mFXhBanJepqiTpaL6SNI1fCAESPSbMm//t2WSKE 5fL2fbium3Vb+mMAaR317tVmLa8t681OaMfpmb8mruy0jmG6ke4CuNKBkL9YFy7u dgSO8fpfINskm+BjNMqsBz5RcvqFOGNKh8DHqv0BZX6oheeaT/9od31FusgaS6rU yqvClvgwWI69cut4EvU7zKmK8/qkHOoNTPw6tRc73ejE0BTi0NBpaIKenpyfxP4y xbuNUcKb55epYTrJdqC6DR+/rIoAdGfWD8OY15KH3orSdtXQ+yreZMohsOXlv+pg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DBDA2E463E; Wed, 9 May 2018 09:26:37 -0400 (EDT) From: Thomas Monjalon To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet Cc: dev@dpdk.org, Matan Azrad , stable@dpdk.org Date: Wed, 09 May 2018 15:26:36 +0200 Message-ID: <24237723.mWpy8k2Fz7@xps> In-Reply-To: <20180509124123.un67tmsh75kxwrir@bidouze.vm.6wind.com> References: <20180509094337.26112-1-thomas@monjalon.net> <20180509094337.26112-11-thomas@monjalon.net> <20180509124123.un67tmsh75kxwrir@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH 10/11] net/failsafe: fix sub-device ownership race X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 13:26:39 -0000 09/05/2018 14:41, Ga=EBtan Rivet: > > Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") >=20 > This fix is relying on the RTE_ETH_EVENT_NEW, an API that I think is not > meant to be backported in the stable release that would be targetted by > this commit id. This event was added in 18.02. So yes it can be backported. > I think this fix is useless without the rest of this series, so I don't > know what is exactly planned about the rest (whether it is backported, > and where), but I would only CC stable if this is planned, and only as > soon as the relevant APIs are introduced. All the series is candidate for 18.02 backport. > > static int > > fs_ethdev_portid_get(const char *name, uint16_t *port_id) > > { > > - uint16_t pid; > > + uint32_t pid; >=20 > I do not see why the port_id is made uint32_t? Is there a reason? Copying Matan's answer: " The maximum port id number can be 0xffff. In this case the loop will be infinite if we use uint16 to iterate over all= the ports. "