From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id AB3E7C13E for ; Wed, 8 Jun 2016 20:05:29 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id v199so75123880wmv.0 for ; Wed, 08 Jun 2016 11:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=bG+frbH5kLwpjuyjGTfAolV0x2tqW9Mq5Om02WO5bLE=; b=CxnPPz9F80IQledGQHPi6XYHGAas7M54xIj8M9HIlFlIQPWb4na3WuAmWncb+FbRgq gH53xPBC0+4Fs0YHS51PdFYFNh4KCXVmbiv4mT8qZXFnYRvbg+0ac6SMS4IgkYne3JNk gzqwNuq1KCg1es/p/K9MHnFm34PV/pVL5ZOg+JUssoe9nKzGZkmbCmKDKoSdetuxxaZQ dqImP2gxdTL0hDj+7mPpKiOBy9aLv5e8SAgej7xNB6T5MqYkrbvkPEAGRlLWYb8J59yg YjVXnW75uThWaLdboX7EyAtkPMxJd1lLrhj/ol7ndOEqK4yS1PttfDrPgjUBVG6aXggE XOzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=bG+frbH5kLwpjuyjGTfAolV0x2tqW9Mq5Om02WO5bLE=; b=T0OqKI6XowaTUjDpsU9RAvjoHpg2YWM0lYdtmaA0O/zLk+6Xwwol8I7lul3wAjpE8l xb5FSHXLoHbhuZl0zqqrKnRA6zKmPIlsLh6R84fW6gu47XX6UVjt/L0nvpJL1zXZTYTA Ru1PI8NbTj2lPm1wBV43g5G5trTOV0OKYuXfFg5FL51+gQLPiHQwuQLmINqF0ZlGdVNK Jmd+ksXyQ7c17+quHkelSUqA3bVuaSYQxi5A5pwwlLAazquV4q02Hw6wNIU7Fz0zwCUO RFU0m8G/FXSb3alRo8MGydrvsHD81023YAMiufCsFNqITN+Vg/0d5UcibZ+/5ZdWAPa9 0fbw== X-Gm-Message-State: ALyK8tK0jqeFv1NKdZUZF2SmYAoQCiAK8qZsxmSE3yiNh377d3fE7DmtCF4ReYpUJvX5tIbz X-Received: by 10.28.213.209 with SMTP id m200mr9586336wmg.80.1465409129436; Wed, 08 Jun 2016 11:05:29 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id ju6sm2756647wjb.14.2016.06.08.11.05.28 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 08 Jun 2016 11:05:28 -0700 (PDT) From: Thomas Monjalon To: Jasvinder Singh Cc: dev@dpdk.org, cristian.dumitrescu@intel.com Date: Wed, 08 Jun 2016 20:05:27 +0200 Message-ID: <2425429.KNKilsUfuN@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1465403456-137137-1-git-send-email-jasvinder.singh@intel.com> References: <1464618804-78135-1-git-send-email-jasvinder.singh@intel.com> <1465403456-137137-1-git-send-email-jasvinder.singh@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] ip_pipeline: configuration file parser cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 18:05:29 -0000 2016-06-08 17:30, Jasvinder Singh: > This commit adds following changes to configuration file parsing of > the ip pipeline application; > > 1. Parsing routines related to packet queues (pktq_in/out fields in the > PIPELINE section) and message queues (msgq_in/out fields of in the MSGQ > Section) are updated. > > In the parsing routines, function "strtok_r()" is used for parsing the > string instead of manually checking the string termination, white > spaces, tabs etc., between the string tokens. Each call to strtok_r() > returns a pointer to a null-terminated string containing the next token. > If no more tokens are found, strtok_r() returns NULL. As a result of > using strtok_r(), the code size of the parsing routines is reduced > significantly. > > 2. Replace PARSER_PARAM_ADD_CHECK macro by more specific macros such as > PARSE_CHECK_DUPLICATE_SECTION, PARSE_CHECK_DUPLICATE_SECTION_EAL to detect > duplicate entries in the various sections of the configuration file > > 3. Add new macros PARSER_ERROR_NO_ELEMENTS and PARSE_ERROR_TOO_MANY_ELEMENTS > for detecting no element and more elements than allowed situations > respectively, in the section entry. > > 4. Add new macros APP_PARAM_ADD_LINK_FOR_RXQ, APP_PARAM_ADD_LINK_FOR_TXQ > and APP_PARAM_ADD_LINK_FOR_TM which add corresponding nic ports entry to > the application param structure while parsing rx/tx queues, TM (Traffic > Manager) port sections and pktq_in/out entries of pipeline sections > > Signed-off-by: Jasvinder Singh > Acked-by: Cristian Dumitrescu Applied, thanks