Re: [dpdk-dev] [PATCHv3 3/3] ABI: Add some documentation

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-06-25 10:35, Neil Horman:
> v3)
>      * Fixed in tact -> intact
>      * Added docs to address static linking
>      * Removed duplicate documentation from release notes

It seems you missed some of my previous comments.

[...]
> +* ``VERSION_SYMBOL(b, e, n)``: Creates a symbol version table entry binding
> +  unversioned symbol ``b`` to the internal function ``b_e``.

Should a versioned symbol <b>@DPDK_<n>

> +* ``BASE_SYMBOL(b, e)``: Creates a symbol version table entry binding
> +  unversioned symbol ``b`` to the internal function ``b_e``.

Please give a use case of BASE_SYMBOL.

[...]
> +The addition of the new block tells the linker that a new version node is
> +available (DPDK_2.1), which contains the symbol rte_acl_create, and inherits the
> +symbols from the DPDK_2.0 node.

which contains the old version of the symbol rte_acl_create