From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 5F1542A62
 for <dev@dpdk.org>; Thu, 29 Mar 2018 09:34:45 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id DB4F020FCD;
 Thu, 29 Mar 2018 03:34:44 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 29 Mar 2018 03:34:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=lHWH8c0YUboDstZZ7LoPzsO2dW
 2KzsrmuIpk7hPeQsY=; b=YJUbGGLDnfB99tRxh7kLZ1eII2zqwakEFpxJvxBx2u
 BO61J4j1WZjCU10elfbiRnJ1Ni5lyoaojQhBtoBfSVf1zuOhzqo2zsj4cft6ltfs
 kpa+PiqttIZrk9aaYX6tbpfMf0SbJz76m8C1C+J5hBJwJwCLItd6MdzBOF/kUM7F
 w=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=lHWH8c
 0YUboDstZZ7LoPzsO2dW2KzsrmuIpk7hPeQsY=; b=KaML2Br4SfY/icZ515mEtk
 llRrV3VdgHyF29uPMF3Gx+x3XRIW70kNzcaFNJigrMvMINwVIHaReW6havrTVR/0
 VU3HzcxADcZtTHnguhhAa2J5nXqfY8xyaVQITZa72a8+z5w6zOYReZr7NJQ11Dy0
 Np11Vxf1MgAr+SzFoUy/tTAeDo4c3k/buPwsLChI1TH8BsOICQrJGnMpXgKkKWSn
 0X+NHNa4biPZ7i/gfD1MLnnz0dTgRh+b0NWK0HR/bfyZ4pLGzQLL8kD/8Blqeu/+
 QMZZR51MfoBL3bGz4zLFtWsEBIfrEXlJcGZOQTijlrNS26a+08a+mxyxrQURl3dQ
 ==
X-ME-Sender: <xms:FJe8Wiq0UPFh8fYWgdjp8omWxKGGGA0G6k5z7-Mm6eyIg94QuLx-BQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 6A70110339;
 Thu, 29 Mar 2018 03:34:42 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: Declan Doherty <declan.doherty@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Alex Rosenbaum <alexr@mellanox.com>, Ferruh Yigit <ferruh.yigit@intel.com>,
 Qi Zhang <qi.z.zhang@intel.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>,
 Remy Horton <remy.horton@intel.com>, John McNamara <john.mcnamara@intel.com>,
 Rony Efraim <ronye@mellanox.com>,
 Wu <IMCEAINVALID-Wu@eurprd05.prod.outlook.com>,
 Jingjing <jingjing.wu@intel.com>,
 Lu <IMCEAINVALID-Lu@eurprd05.prod.outlook.com>, Wenzhuo <wenzhuo.lu@intel.com>,
 Vincent JArdin <vincent.jardin@6wind.com>, Yuanhan Liu <yliu@fridaylinux.org>,
 Richardson <IMCEAINVALID-Richardson@eurprd05.prod.outlook.com>,
 Bruce <bruce.richardson@intel.com>,
 Ananyev <IMCEAINVALID-Ananyev@eurprd05.prod.outlook.com>,
 Konstantin <konstantin.ananyev@intel.com>,
 Wang <IMCEAINVALID-Wang@eurprd05.prod.outlook.com>,
 Zhihong <zhihong.wang@intel.com>
Date: Thu, 29 Mar 2018 09:34:27 +0200
Message-ID: <2430508.NP3kz8ElFZ@xps>
In-Reply-To: <DB7PR05MB44260846B4556669591ADAC3C3A20@DB7PR05MB4426.eurprd05.prod.outlook.com>
References: <20180328135433.20203-1-declan.doherty@intel.com>
 <20180328135433.20203-5-declan.doherty@intel.com>
 <DB7PR05MB44260846B4556669591ADAC3C3A20@DB7PR05MB4426.eurprd05.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v6 4/8] ethdev: Add port representor device
	flag
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Mar 2018 07:34:45 -0000

29/03/2018 08:13, Shahaf Shuler:
> And device attributes like : RTE_ETH_DEV_BONDED_SLAVE and RTE_ETH_DEV_REPRESENTOR.
> I don't think they belong together under the genetic name of dev_flags. 
> 
> Moreover, I am not sure the fact device is bonded slave should be exposed to the application. It should be internal to ethdev and its port iterators.

RTE_ETH_DEV_BONDED_SLAVE flag is used to prevent a manual detach of a slave.
I think it is wrong.
The bonding PMD should be able to manage any detach at any time,
because a real hardware plug-out can happen.

So I am in favor of removing RTE_ETH_DEV_BONDED_SLAVE.