From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 021BB683D
 for <dev@dpdk.org>; Fri,  3 Jul 2015 17:46:44 +0200 (CEST)
Received: by wgjx7 with SMTP id x7so91358063wgj.2
 for <dev@dpdk.org>; Fri, 03 Jul 2015 08:46:43 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=CiJv5cTPNngx/nfIxWO00uIXN2voJUwpdXL95+DCJk8=;
 b=EnV6w1tkUj+qdAem0JF7cX8OMHdLEbrv+ltv6tUZa72K5cfEggYzQ1+9CCYxi4BDEj
 heFIVl9KxK4nwOBcgYHhxNq/yAw4ZDhwUBuL6cOUUeiki2XkWWw0VGmC1iSi1Zbammin
 k6ftfEs4a2s6u9aBbEO6tb9P08/rn7V0l49dDyOCKb2emjk2x0BcZ5x3XqUSJFNj/vVj
 j1GJWnnktb06yhVLuRYSW7NLTyUXAGKcEugF9TNoLc12D2+0j11r15EWjdGwplP8P4HI
 w6HVQAJDT6pSSkhYD/FRa68nAd72NfMFs/Dc0rhF9F0XFTvil2DoebxN8J8bSS8INsmW
 3kog==
X-Gm-Message-State: ALoCoQm7tcmX8OK46bnmxwcrjeF8Ap83J/wLEYB8zd35csDFenvpH6qlonAg730cxU67yFXB2YmS
X-Received: by 10.194.7.97 with SMTP id i1mr22564761wja.107.1435938403875;
 Fri, 03 Jul 2015 08:46:43 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id bg6sm13922278wjc.13.2015.07.03.08.46.42
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 03 Jul 2015 08:46:43 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Date: Fri, 03 Jul 2015 17:45:34 +0200
Message-ID: <2430733.IxTGXH4ElX@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1435938006-22254-2-git-send-email-bruce.richardson@intel.com>
References: <1435938006-22254-1-git-send-email-bruce.richardson@intel.com>
 <1435938006-22254-2-git-send-email-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] ixgbe: add "cold" attribute to
	setup/teardown fns
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jul 2015 15:46:44 -0000

Hi Bruce,

2015-07-03 16:40, Bruce Richardson:
> As well as the fast-path functions in the rxtx code, there are also
> functions which set up and tear down the descriptor rings. Since these
> are not performance critical functions, there is no need to have them
> extensively optimized, so we add __attribute__((cold)) to their
> definitions. This has the side-effect of making debugging them easier as
> the compiler does not optimize them as heavily, so more variables are
> accessible by default in gdb.

What is the benefit, compared to -O0?