* [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix incorrect stats array length
@ 2016-06-27 13:37 Pablo de Lara
2016-06-28 8:28 ` Declan Doherty
0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2016-06-27 13:37 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, Pablo de Lara
crypto_statistics array was not big enough for storing
all the possible crypto device statistics, as its size was
RTE_MAX_ETHPORTS, but should be RTE_CRYPTO_MAX_DEVS, leading
this to a potential out-of-bounds issue.
Coverity issue: 120145
Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
examples/l2fwd-crypto/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index 8dc616d..70fada5 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -243,7 +243,7 @@ struct l2fwd_crypto_statistics {
} __rte_cache_aligned;
struct l2fwd_port_statistics port_statistics[RTE_MAX_ETHPORTS];
-struct l2fwd_crypto_statistics crypto_statistics[RTE_MAX_ETHPORTS];
+struct l2fwd_crypto_statistics crypto_statistics[RTE_CRYPTO_MAX_DEVS];
/* A tsc-based timer responsible for triggering statistics printout */
#define TIMER_MILLISECOND 2000000ULL /* around 1ms at 2 Ghz */
--
2.5.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix incorrect stats array length
2016-06-27 13:37 [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix incorrect stats array length Pablo de Lara
@ 2016-06-28 8:28 ` Declan Doherty
2016-07-11 15:05 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Declan Doherty @ 2016-06-28 8:28 UTC (permalink / raw)
To: Pablo de Lara, dev
On 27/06/16 14:37, Pablo de Lara wrote:
> crypto_statistics array was not big enough for storing
> all the possible crypto device statistics, as its size was
> RTE_MAX_ETHPORTS, but should be RTE_CRYPTO_MAX_DEVS, leading
> this to a potential out-of-bounds issue.
>
> Coverity issue: 120145
>
> Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> examples/l2fwd-crypto/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
> index 8dc616d..70fada5 100644
> --- a/examples/l2fwd-crypto/main.c
> +++ b/examples/l2fwd-crypto/main.c
> @@ -243,7 +243,7 @@ struct l2fwd_crypto_statistics {
> } __rte_cache_aligned;
>
> struct l2fwd_port_statistics port_statistics[RTE_MAX_ETHPORTS];
> -struct l2fwd_crypto_statistics crypto_statistics[RTE_MAX_ETHPORTS];
> +struct l2fwd_crypto_statistics crypto_statistics[RTE_CRYPTO_MAX_DEVS];
>
> /* A tsc-based timer responsible for triggering statistics printout */
> #define TIMER_MILLISECOND 2000000ULL /* around 1ms at 2 Ghz */
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix incorrect stats array length
2016-06-28 8:28 ` Declan Doherty
@ 2016-07-11 15:05 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-07-11 15:05 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev, Declan Doherty
2016-06-28 09:28, Declan Doherty:
> On 27/06/16 14:37, Pablo de Lara wrote:
> > crypto_statistics array was not big enough for storing
> > all the possible crypto device statistics, as its size was
> > RTE_MAX_ETHPORTS, but should be RTE_CRYPTO_MAX_DEVS, leading
> > this to a potential out-of-bounds issue.
> >
> > Coverity issue: 120145
> >
> > Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Acked-by: Declan Doherty <declan.doherty@intel.com>
Slawomir sent the same fix, so kind of applied :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-11 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-27 13:37 [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix incorrect stats array length Pablo de Lara
2016-06-28 8:28 ` Declan Doherty
2016-07-11 15:05 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).