From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2686A034F; Sat, 2 Nov 2019 19:31:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 355DB1DFE7; Sat, 2 Nov 2019 19:31:30 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 212351DFE6 for ; Sat, 2 Nov 2019 19:31:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 569385BAD; Sat, 2 Nov 2019 14:31:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 02 Nov 2019 14:31:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=oqfhV7OFJHjju5xNzsW+4l2G5IfWuBOufR1L17hgcrE=; b=PusSEhRDrigg ssdnhIo4OXv64ygrJvWDYWGhrR921g5fP/9uOmXyRNJelRc6Lx2NBq3eHsb43aCO 10m4tC3d760B9SEn2fp72Cx/hKvH7TYKXXWH0cCVpSeok7lNXY5/RbsFTrc5yPsd V/2kDTLyZHnvZ66O7f38ltbOMTFKL/w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=oqfhV7OFJHjju5xNzsW+4l2G5IfWuBOufR1L17hgc rE=; b=m6Giy+tlG6h0MimAyiLVYMRID4bP6Iu0c8s5d0BrhINpKNsSQt9zwPdqs IJLWCB9q21wrtBzVMHkYPlMi3xa5ZbnbjK060Ilr0oZkGm5jf9eTZES6lznlg8qM WiWuonfwcSpfeckJgXGkxoeW7cxJKdZbkB3fXAKPhx+p0hRGzvYNw8+pZyUOCjJa pQzsomK+Z40SuWvpcOBWAJR/n66c4fh1m90VJ7uOPnAH6WlOFPz5hZfE+AEF2uR0 /k+h+dyvKileoYFRHBB0q+iqVxmo4bap/rph/As8FpOXeHf4qvFTE68ml+K75xMr NvxL06YJ1uEhACwYB5HyXDIWDAbFg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddtledgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepleefrdeirddugeelrdduudegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 1892E3060062; Sat, 2 Nov 2019 14:31:25 -0400 (EDT) From: Thomas Monjalon To: "Liu, Yu Y" Cc: "Wang, Haiyue" , "dev@dpdk.org" , "arybchenko@solarflare.com" , "Yigit, Ferruh" , "jerinjacobk@gmail.com" , "Ye, Xiaolong" , "Kinsella, Ray" , "Sun, Chenmin" , Slava Ovsiienko , "Damjan Marion (damarion)" Date: Sat, 02 Nov 2019 19:31:23 +0100 Message-ID: <2431604.fJrMVA34KA@xps> In-Reply-To: References: <20191031171139.105110-1-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/11/2019 07:55, Liu, Yu Y: > Add Damjan from FD.io for awareness... > > Hi Thomas, > > Long time no see. Sorry I use outlook which is not friendly to community email. > > >Anyway I will propose to replace this API in the next release. > Will your plan be affected by API/ABI stable plan? The API is experimental, so it can be changed later. > BTW, if you propose new change in next release, it will make DPDK consumer(FD.io) to change again. Yes I agree it is not nice. > So even if it is not affected to the API/ABI stable plan, do we still have time to get a solution for everyone in DPDK 19.11 with your contribution/acceleration? Yes we have time. But you insist on an API without any good justification. > > I suspect a real hidden issue in Intel CPUs that you try to mitigate. > Please be rest assured it is not the case. > This request is just from one FD.io project internal bug " tx/rx burst function is shown as nil" reported by Chenmin. > My understanding is DPDK behavior was taken as bug for someone in FD.io project and potentially will mislead other DPDK consumer. > Haiyue is working with Chenmin to address the issue and with your support it will be even better. > > Your support will be highly appreciated! I already said what I consider to be good: a simple string. Of course I may be wrong, that's why I asked questions. But half of the questions are just ignored. If you want to progress, please reply to the questions asked by Slava in this thread. > -----Original Message----- > From: dev On Behalf Of Wang, Haiyue > > From: Thomas Monjalon > > > > Thank you for trying to address comments done late. > > > > 31/10/2019 18:11, Haiyue Wang: > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > +++ b/lib/librte_ethdev/rte_ethdev.h > > > > > +#define RTE_ETH_BURST_ALTIVEC (1ULL << 2) > > > +#define RTE_ETH_BURST_NEON (1ULL << 3) > > > +#define RTE_ETH_BURST_SSE (1ULL << 4) > > > +#define RTE_ETH_BURST_AVX2 (1ULL << 5) > > > +#define RTE_ETH_BURST_AVX512 (1ULL << 6) > > > > Of course, I still believe that giving a special treatment to vector > > instructions is wrong. > > You did not justify why it needs to be defined in bits instead of > > string. I am not asking again because anyway you don't really reply. I > > think you are executing an order you received and I don't want to > > blame you more. > > I suspect a real hidden issue in Intel CPUs that you try to mitigate. > > No need to reply to this comment. > > Anyway I will propose to replace this API in the next release. > > Never mind, if this design is truly ugly, drop it all now. I also prefer to do the best, that's why open source is amazing, thanks! ;-)