From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E100A0C43; Wed, 12 May 2021 16:29:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D19AF4003F; Wed, 12 May 2021 16:29:29 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id A71CC4003E for ; Wed, 12 May 2021 16:29:28 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1541F5C0136; Wed, 12 May 2021 10:29:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 12 May 2021 10:29:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= VBdEJq0hg+g/2IMeshxREn6xZ9zmSDDIKbYOzrfuBE4=; b=mVcoUfuEZD0eSnDf F+JjRggsHek5zjYSECvVB2qlVVcCBncrjvGuIPElRGuV3MAJGGazdiGMPn4QKv1t abX9siCb3w9U+I5MqERtzmyUOzsqIhYTecWbRUqcW/7FRGBxBC9wjKvzShd+2Lzg oa9H48Mo//d1hT0cMkXBCWpGHfXm9B8EpDFIF4ibA56qytcqDtZgov8/Yz00Fc7w elG6KNVHppSk0RhSucXJSF9sC0+RNSFHyGz6io0xgHfL+Ku/EueJoEFXq+jP47bG ojq6vLmzx8E7CZr0Enl0fygfCYtRjuQOQIkLJ/KdiCE3wI92BBTUZuQttgLM/x5G 2MYgJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=VBdEJq0hg+g/2IMeshxREn6xZ9zmSDDIKbYOzrfuB E4=; b=Zd+BPpFlkON7mtUCexLp9UcF1Y6WXsn5vXqzvP8GYd2CuGhc8J+77xxLK AocEeE0+uX04Sz49okqHrWiPAKFlifXG42W0E42W/+76TAJuC+j3DkadpRih8/nm fsYpBLBxzb/EWL/cJBkPdFUgBa4iqEqQgqoG4kbvCwB2NMNfCTqKYeuzS6e5SAC+ sqs1kcwqN002bKvbuaofOAvmfKaDmWhNxESwiA6EvRtBpmtpok4s5DX+ZcUa9eb/ FRSLdJ0l5dLXaJiAhyl+dNcBhQqDxehmWyEJayznFOtblWm8X/69BH/dNazrdioG ezCS44p0DfJFKut7vs9pguSzqJTYQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehvddgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 May 2021 10:29:25 -0400 (EDT) From: Thomas Monjalon To: "Min Hu (Connor)" Cc: dev@dpdk.org, ferruh.yigit@intel.com, nipun.gupta@nxp.com, hemant.agrawal@nxp.com Date: Wed, 12 May 2021 16:29:23 +0200 Message-ID: <2432315.0YYthSTycW@thomas> In-Reply-To: <1619072506-48243-1-git-send-email-humin29@huawei.com> References: <1619072506-48243-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] raw/skeleton: fix return value check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/04/2021 08:21, Min Hu (Connor): > This patch adds return value check for setting an attribute. > > Fixes: 88a81bcecb7b ("raw/skeleton: remove compile-time constant for device id") > Cc: stable@dpdk.org > > Signed-off-by: Min Hu (Connor) > --- > ret = rte_rawdev_set_attr(test_dev_id, "Test2", (uintptr_t)dummy_value); > + RTE_TEST_ASSERT(!ret, "Unable to set an attribute (Test2)"); Applied with title "raw/skeleton: add missing check after setting attribute" thanks