DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Phil Yang <phil.yang@arm.com>, Feifei Wang <feifei.wang2@arm.com>
Cc: "Bruce Richardson" <bruce.richardson@intel.com>,
	dev@dpdk.org, nd@arm.com,
	"Juraj Linkeš" <juraj.linkes@pantheon.tech>,
	"Ruifeng Wang" <ruifeng.wang@arm.com>,
	david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory
Date: Fri, 06 Aug 2021 17:43:08 +0200	[thread overview]
Message-ID: <2432521.6uc7bEPLWt@thomas> (raw)
In-Reply-To: <20210601015653.14499-3-feifei.wang2@arm.com>

01/06/2021 03:56, Feifei Wang:
> From: Phil Yang <phil.yang@arm.com>
> 
> To make the code easier to maintain, use the absolute path for the
> default build_dir to avoid repeatedly calling of readlink.
[...]
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> -builds_dir=${DPDK_BUILD_TEST_DIR:-.}
> +builds_dir=$(readlink -f ${DPDK_BUILD_TEST_DIR:-.})

It means that all uses of builds_dir will get the absolute path.
It may have consequences on meson configuration,
and will make outputs and logs longer.

I'm not sure this change is desirable.



  parent reply	other threads:[~2021-08-06 15:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01  1:56 [dpdk-dev] [PATCH v1 0/2] relative path support for ABI compatibility check Feifei Wang
2021-06-01  1:56 ` [dpdk-dev] [PATCH v1 1/2] devtools: add " Feifei Wang
2021-06-22  2:08   ` [dpdk-dev] 回复: " Feifei Wang
2021-06-22  9:19   ` [dpdk-dev] " Bruce Richardson
2021-06-01  1:56 ` [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory Feifei Wang
2021-07-28  7:20   ` [dpdk-dev] 回复: " Feifei Wang
2021-08-06 15:43   ` Thomas Monjalon [this message]
2021-08-11  3:14     ` Feifei Wang
2021-08-11  6:17 ` [dpdk-dev] [PATCH v2 0/1] relative path support for ABI compatibility check Feifei Wang
2021-08-11  6:17   ` [dpdk-dev] [PATCH v2 1/1] devtools: add " Feifei Wang
2021-10-15 10:02     ` [dpdk-dev] 回复: " Feifei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2432521.6uc7bEPLWt@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=feifei.wang2@arm.com \
    --cc=juraj.linkes@pantheon.tech \
    --cc=nd@arm.com \
    --cc=phil.yang@arm.com \
    --cc=ruifeng.wang@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).