From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BEE0A0C46; Fri, 6 Aug 2021 17:43:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AD71412B3; Fri, 6 Aug 2021 17:43:14 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 1D6C04014D for ; Fri, 6 Aug 2021 17:43:13 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 67FEF5C00ED; Fri, 6 Aug 2021 11:43:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 06 Aug 2021 11:43:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= zBsmTqcFjrXQbPIOCeTH/vw+mavb6b/mea7bEVPcI2k=; b=3c1+yt3X12+U+z2O u3/8ow/dBGweMOQEzG8wg3TRDsf02AwmwkLp+9K5oJOD8AmbArE0GF8Ly3ALr61k inle6d+o+5I3R1ntzxmGh1kHNE1RTolCNAsLZ8L344WDN/aG/fs2s6Pg2+EzJ0Nq cohtAY91jRdiBJFMR0xapW9EBiEFqwbOT62yz3VqQvhy1ogfxUN1NOSzJ9qVFasf 1KO9uzaUvUacpoP/NBuCLhiG2NbGWQHrSz0lPGq/ovxzzDhTcrfEfvaf06Y1F2wh cgoO4A88UoLDha5tCxxAJMEEyFD8fDwR+Ho50P28RB2SinAnwmSkhVuIFUbDEKEx z0r05A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=zBsmTqcFjrXQbPIOCeTH/vw+mavb6b/mea7bEVPcI 2k=; b=KLh6zKRU+CsT55YbZKQZXJm8NvNB13zqpnp3pko2YNa52QublhDEkvQVU nuar4+BLqECszcBLdhGg1fRQj6nZBxL6/XY5dGH3VN62wRxOg/5PzJJ+CLa184F8 wue/FVZCJRu7mkL88QYI3mKteDrYUvSh+0H2ndzld3gwaswsHYEu4a6Y96I0pmYg /muouEi2Lp4QG0fM2np5dNvhGzAG4b3zhZIrsWPybRx8CWtp2Uf2BtgWLefc+K6b qBnRLXEgikAG42WaFZ0dn8P5/vRyjTfQM6yuElnsYdPlK+RNf+U79XbKPAR9dOvi bRxTk3stQiULPaoT3dXJN+kt4HBMQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjedugdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 Aug 2021 11:43:10 -0400 (EDT) From: Thomas Monjalon To: Phil Yang , Feifei Wang Cc: Bruce Richardson , dev@dpdk.org, nd@arm.com, Juraj =?utf-8?B?TGlua2XFoQ==?= , Ruifeng Wang , david.marchand@redhat.com Date: Fri, 06 Aug 2021 17:43:08 +0200 Message-ID: <2432521.6uc7bEPLWt@thomas> In-Reply-To: <20210601015653.14499-3-feifei.wang2@arm.com> References: <20210601015653.14499-1-feifei.wang2@arm.com> <20210601015653.14499-3-feifei.wang2@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/06/2021 03:56, Feifei Wang: > From: Phil Yang > > To make the code easier to maintain, use the absolute path for the > default build_dir to avoid repeatedly calling of readlink. [...] > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > -builds_dir=${DPDK_BUILD_TEST_DIR:-.} > +builds_dir=$(readlink -f ${DPDK_BUILD_TEST_DIR:-.}) It means that all uses of builds_dir will get the absolute path. It may have consequences on meson configuration, and will make outputs and logs longer. I'm not sure this change is desirable.