* [dpdk-dev] [PATCH v1 0/2] relative path support for ABI compatibility check
@ 2021-06-01 1:56 Feifei Wang
2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 1/2] devtools: add " Feifei Wang
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Feifei Wang @ 2021-06-01 1:56 UTC (permalink / raw)
Cc: dev, nd, Feifei Wang
Add relative path support for ABI compatibility check and do some code
simplification work.
Phil Yang (2):
devtools: add relative path support for ABI compatibility check
devtools: use absolute path for the build directory
devtools/test-meson-builds.sh | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 11+ messages in thread* [dpdk-dev] [PATCH v1 1/2] devtools: add relative path support for ABI compatibility check 2021-06-01 1:56 [dpdk-dev] [PATCH v1 0/2] relative path support for ABI compatibility check Feifei Wang @ 2021-06-01 1:56 ` Feifei Wang 2021-06-22 2:08 ` [dpdk-dev] 回复: " Feifei Wang 2021-06-22 9:19 ` [dpdk-dev] " Bruce Richardson 2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory Feifei Wang 2021-08-11 6:17 ` [dpdk-dev] [PATCH v2 0/1] relative path support for ABI compatibility check Feifei Wang 2 siblings, 2 replies; 11+ messages in thread From: Feifei Wang @ 2021-06-01 1:56 UTC (permalink / raw) To: Bruce Richardson Cc: dev, nd, Phil Yang, Feifei Wang, Juraj Linkeš, Ruifeng Wang From: Phil Yang <phil.yang@arm.com> Because dpdk guide does not limit the relative path for ABI compatibility check, users maybe set 'DPDK_ABI_REF_DIR' as a relative path: ~/dpdk/devtools$ DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=build-gcc-shared ./test-meson-builds.sh And if the DESTDIR is not an absolute path, ninja complains: + install_target build-gcc-shared/v19.11/build build-gcc-shared/v19.11/build-gcc-shared + rm -rf build-gcc-shared/v19.11/build-gcc-shared + echo 'DESTDIR=build-gcc-shared/v19.11/build-gcc-shared ninja -C build-gcc-shared/v19.11/build install' + DESTDIR=build-gcc-shared/v19.11/build-gcc-shared + ninja -C build-gcc-shared/v19.11/build install ... ValueError: dst_dir must be absolute, got build-gcc-shared/v19.11/build-gcc-shared/usr/local/share/dpdk/ examples/bbdev_app ... Error: install directory 'build-gcc-shared/v19.11/build-gcc-shared' does not exist. To fix this, add relative path support using 'readlink -f'. Signed-off-by: Phil Yang <phil.yang@arm.com> Signed-off-by: Feifei Wang <feifei.wang2@arm.com> Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> --- devtools/test-meson-builds.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index daf817ac3e..43b906598d 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -168,7 +168,8 @@ build () # <directory> <target cc | cross file> <ABI check> [meson options] config $srcdir $builds_dir/$targetdir $cross --werror $* compile $builds_dir/$targetdir if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then - abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION + abirefdir=$(readlink -f \ + ${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION) if [ ! -d $abirefdir/$targetdir ]; then # clone current sources if [ ! -d $abirefdir/src ]; then -- 2.25.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] 回复: [PATCH v1 1/2] devtools: add relative path support for ABI compatibility check 2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 1/2] devtools: add " Feifei Wang @ 2021-06-22 2:08 ` Feifei Wang 2021-06-22 9:19 ` [dpdk-dev] " Bruce Richardson 1 sibling, 0 replies; 11+ messages in thread From: Feifei Wang @ 2021-06-22 2:08 UTC (permalink / raw) To: Feifei Wang, Bruce Richardson Cc: dev, nd, Phil Yang, Juraj Linkeš, Ruifeng Wang, nd Hi, Bruce Would you please help review this patch series? Thanks. Best Regards Feifei > -----邮件原件----- > 发件人: Feifei Wang <feifei.wang2@arm.com> > 发送时间: 2021年6月1日 9:57 > 收件人: Bruce Richardson <bruce.richardson@intel.com> > 抄送: dev@dpdk.org; nd <nd@arm.com>; Phil Yang <Phil.Yang@arm.com>; > Feifei Wang <Feifei.Wang2@arm.com>; Juraj Linkeš > <juraj.linkes@pantheon.tech>; Ruifeng Wang <Ruifeng.Wang@arm.com> > 主题: [PATCH v1 1/2] devtools: add relative path support for ABI > compatibility check > > From: Phil Yang <phil.yang@arm.com> > > Because dpdk guide does not limit the relative path for ABI compatibility > check, users maybe set 'DPDK_ABI_REF_DIR' as a relative > path: > > ~/dpdk/devtools$ DPDK_ABI_REF_VERSION=v19.11 > DPDK_ABI_REF_DIR=build-gcc-shared ./test-meson-builds.sh > > And if the DESTDIR is not an absolute path, ninja complains: > + install_target build-gcc-shared/v19.11/build > + build-gcc-shared/v19.11/build-gcc-shared > + rm -rf build-gcc-shared/v19.11/build-gcc-shared > + echo 'DESTDIR=build-gcc-shared/v19.11/build-gcc-shared ninja -C build-gcc- > shared/v19.11/build install' > + DESTDIR=build-gcc-shared/v19.11/build-gcc-shared > + ninja -C build-gcc-shared/v19.11/build install > ... > ValueError: dst_dir must be absolute, got build-gcc-shared/v19.11/build-gcc- > shared/usr/local/share/dpdk/ > examples/bbdev_app > ... > Error: install directory 'build-gcc-shared/v19.11/build-gcc-shared' does not > exist. > > To fix this, add relative path support using 'readlink -f'. > > Signed-off-by: Phil Yang <phil.yang@arm.com> > Signed-off-by: Feifei Wang <feifei.wang2@arm.com> > Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > --- > devtools/test-meson-builds.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index daf817ac3e..43b906598d 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -168,7 +168,8 @@ build () # <directory> <target cc | cross file> <ABI > check> [meson options] > config $srcdir $builds_dir/$targetdir $cross --werror $* > compile $builds_dir/$targetdir > if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then > - abirefdir=${DPDK_ABI_REF_DIR:- > reference}/$DPDK_ABI_REF_VERSION > + abirefdir=$(readlink -f \ > + ${DPDK_ABI_REF_DIR:- > reference}/$DPDK_ABI_REF_VERSION) > if [ ! -d $abirefdir/$targetdir ]; then > # clone current sources > if [ ! -d $abirefdir/src ]; then > -- > 2.25.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH v1 1/2] devtools: add relative path support for ABI compatibility check 2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 1/2] devtools: add " Feifei Wang 2021-06-22 2:08 ` [dpdk-dev] 回复: " Feifei Wang @ 2021-06-22 9:19 ` Bruce Richardson 1 sibling, 0 replies; 11+ messages in thread From: Bruce Richardson @ 2021-06-22 9:19 UTC (permalink / raw) To: Feifei Wang; +Cc: dev, nd, Phil Yang, Juraj Linkeš, Ruifeng Wang On Tue, Jun 01, 2021 at 09:56:52AM +0800, Feifei Wang wrote: > From: Phil Yang <phil.yang@arm.com> > > Because dpdk guide does not limit the relative path for ABI > compatibility check, users maybe set 'DPDK_ABI_REF_DIR' as a relative > path: > > ~/dpdk/devtools$ DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=build-gcc-shared > ./test-meson-builds.sh > > And if the DESTDIR is not an absolute path, ninja complains: > + install_target build-gcc-shared/v19.11/build build-gcc-shared/v19.11/build-gcc-shared > + rm -rf build-gcc-shared/v19.11/build-gcc-shared > + echo 'DESTDIR=build-gcc-shared/v19.11/build-gcc-shared ninja -C build-gcc-shared/v19.11/build install' > + DESTDIR=build-gcc-shared/v19.11/build-gcc-shared > + ninja -C build-gcc-shared/v19.11/build install > ... > ValueError: dst_dir must be absolute, got build-gcc-shared/v19.11/build-gcc-shared/usr/local/share/dpdk/ > examples/bbdev_app > ... > Error: install directory 'build-gcc-shared/v19.11/build-gcc-shared' does not exist. > > To fix this, add relative path support using 'readlink -f'. > > Signed-off-by: Phil Yang <phil.yang@arm.com> > Signed-off-by: Feifei Wang <feifei.wang2@arm.com> > Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > --- > devtools/test-meson-builds.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index daf817ac3e..43b906598d 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -168,7 +168,8 @@ build () # <directory> <target cc | cross file> <ABI check> [meson options] > config $srcdir $builds_dir/$targetdir $cross --werror $* > compile $builds_dir/$targetdir > if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then > - abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION > + abirefdir=$(readlink -f \ > + ${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION) > if [ ! -d $abirefdir/$targetdir ]; then > # clone current sources > if [ ! -d $abirefdir/src ]; then This looks a simple enough change. Acked-by: Bruce Richardson <bruce.richardson@intel.com> ^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory 2021-06-01 1:56 [dpdk-dev] [PATCH v1 0/2] relative path support for ABI compatibility check Feifei Wang 2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 1/2] devtools: add " Feifei Wang @ 2021-06-01 1:56 ` Feifei Wang 2021-07-28 7:20 ` [dpdk-dev] 回复: " Feifei Wang 2021-08-06 15:43 ` [dpdk-dev] " Thomas Monjalon 2021-08-11 6:17 ` [dpdk-dev] [PATCH v2 0/1] relative path support for ABI compatibility check Feifei Wang 2 siblings, 2 replies; 11+ messages in thread From: Feifei Wang @ 2021-06-01 1:56 UTC (permalink / raw) To: Bruce Richardson Cc: dev, nd, Phil Yang, Juraj Linkeš, Feifei Wang, Ruifeng Wang From: Phil Yang <phil.yang@arm.com> To make the code easier to maintain, use the absolute path for the default build_dir to avoid repeatedly calling of readlink. Suggested-by: Juraj Linkeš <juraj.linkes@pantheon.tech> Signed-off-by: Phil Yang <phil.yang@arm.com> Signed-off-by: Feifei Wang <feifei.wang2@arm.com> Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> --- devtools/test-meson-builds.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 43b906598d..d6b0e7e059 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -16,7 +16,7 @@ srcdir=$(dirname $(readlink -f $0))/.. MESON=${MESON:-meson} use_shared="--default-library=shared" -builds_dir=${DPDK_BUILD_TEST_DIR:-.} +builds_dir=$(readlink -f ${DPDK_BUILD_TEST_DIR:-.}) if command -v gmake >/dev/null 2>&1 ; then MAKE=gmake @@ -193,16 +193,16 @@ build () # <directory> <target cc | cross file> <ABI check> [meson options] fi install_target $builds_dir/$targetdir \ - $(readlink -f $builds_dir/$targetdir/install) + $builds_dir/$targetdir/install echo "Checking ABI compatibility of $targetdir" >&$verbose echo $srcdir/devtools/gen-abi.sh \ - $(readlink -f $builds_dir/$targetdir/install) >&$veryverbose + $builds_dir/$targetdir/install >&$veryverbose $srcdir/devtools/gen-abi.sh \ - $(readlink -f $builds_dir/$targetdir/install) >&$veryverbose + $builds_dir/$targetdir/install >&$veryverbose echo $srcdir/devtools/check-abi.sh $abirefdir/$targetdir \ - $(readlink -f $builds_dir/$targetdir/install) >&$veryverbose + $builds_dir/$targetdir/install >&$veryverbose $srcdir/devtools/check-abi.sh $abirefdir/$targetdir \ - $(readlink -f $builds_dir/$targetdir/install) >&$verbose + $builds_dir/$targetdir/install >&$verbose fi } @@ -275,7 +275,7 @@ done # Test installation of the x86-generic target, to be used for checking # the sample apps build using the pkg-config file for cflags and libs load_env cc -build_path=$(readlink -f $builds_dir/build-x86-generic) +build_path=$builds_dir/build-x86-generic export DESTDIR=$build_path/install install_target $build_path $DESTDIR pc_file=$(find $DESTDIR -name libdpdk.pc) -- 2.25.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] 回复: [PATCH v1 2/2] devtools: use absolute path for the build directory 2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory Feifei Wang @ 2021-07-28 7:20 ` Feifei Wang 2021-08-06 15:43 ` [dpdk-dev] " Thomas Monjalon 1 sibling, 0 replies; 11+ messages in thread From: Feifei Wang @ 2021-07-28 7:20 UTC (permalink / raw) To: Bruce Richardson; +Cc: dev, nd, Juraj Linkeš, Ruifeng Wang, nd Hi, Bruce Sorry to disturb you again. Would you please help review the second patch of this series? Thanks very much. Best Regards Feifei > -----邮件原件----- > 发件人: Feifei Wang <feifei.wang2@arm.com> > 发送时间: Tuesday, June 1, 2021 9:57 AM > 收件人: Bruce Richardson <bruce.richardson@intel.com> > 抄送: dev@dpdk.org; nd <nd@arm.com>; Phil Yang <Phil.Yang@arm.com>; > Juraj Linkeš <juraj.linkes@pantheon.tech>; Feifei Wang > <Feifei.Wang2@arm.com>; Ruifeng Wang <Ruifeng.Wang@arm.com> > 主题: [PATCH v1 2/2] devtools: use absolute path for the build directory > > From: Phil Yang <phil.yang@arm.com> > > To make the code easier to maintain, use the absolute path for the default > build_dir to avoid repeatedly calling of readlink. > > Suggested-by: Juraj Linkeš <juraj.linkes@pantheon.tech> > Signed-off-by: Phil Yang <phil.yang@arm.com> > Signed-off-by: Feifei Wang <feifei.wang2@arm.com> > Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > --- > devtools/test-meson-builds.sh | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 43b906598d..d6b0e7e059 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -16,7 +16,7 @@ srcdir=$(dirname $(readlink -f $0))/.. > > MESON=${MESON:-meson} > use_shared="--default-library=shared" > -builds_dir=${DPDK_BUILD_TEST_DIR:-.} > +builds_dir=$(readlink -f ${DPDK_BUILD_TEST_DIR:-.}) > > if command -v gmake >/dev/null 2>&1 ; then > MAKE=gmake > @@ -193,16 +193,16 @@ build () # <directory> <target cc | cross file> <ABI > check> [meson options] > fi > > install_target $builds_dir/$targetdir \ > - $(readlink -f $builds_dir/$targetdir/install) > + $builds_dir/$targetdir/install > echo "Checking ABI compatibility of $targetdir" >&$verbose > echo $srcdir/devtools/gen-abi.sh \ > - $(readlink -f > $builds_dir/$targetdir/install) >&$veryverbose > + $builds_dir/$targetdir/install >&$veryverbose > $srcdir/devtools/gen-abi.sh \ > - $(readlink -f > $builds_dir/$targetdir/install) >&$veryverbose > + $builds_dir/$targetdir/install >&$veryverbose > echo $srcdir/devtools/check-abi.sh $abirefdir/$targetdir \ > - $(readlink -f > $builds_dir/$targetdir/install) >&$veryverbose > + $builds_dir/$targetdir/install >&$veryverbose > $srcdir/devtools/check-abi.sh $abirefdir/$targetdir \ > - $(readlink -f > $builds_dir/$targetdir/install) >&$verbose > + $builds_dir/$targetdir/install >&$verbose > fi > } > > @@ -275,7 +275,7 @@ done > # Test installation of the x86-generic target, to be used for checking # the > sample apps build using the pkg-config file for cflags and libs load_env cc - > build_path=$(readlink -f $builds_dir/build-x86-generic) > +build_path=$builds_dir/build-x86-generic > export DESTDIR=$build_path/install > install_target $build_path $DESTDIR > pc_file=$(find $DESTDIR -name libdpdk.pc) > -- > 2.25.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory 2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory Feifei Wang 2021-07-28 7:20 ` [dpdk-dev] 回复: " Feifei Wang @ 2021-08-06 15:43 ` Thomas Monjalon 2021-08-11 3:14 ` [dpdk-dev] 回复: " Feifei Wang 1 sibling, 1 reply; 11+ messages in thread From: Thomas Monjalon @ 2021-08-06 15:43 UTC (permalink / raw) To: Phil Yang, Feifei Wang Cc: Bruce Richardson, dev, nd, Juraj Linkeš, Ruifeng Wang, david.marchand 01/06/2021 03:56, Feifei Wang: > From: Phil Yang <phil.yang@arm.com> > > To make the code easier to maintain, use the absolute path for the > default build_dir to avoid repeatedly calling of readlink. [...] > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > -builds_dir=${DPDK_BUILD_TEST_DIR:-.} > +builds_dir=$(readlink -f ${DPDK_BUILD_TEST_DIR:-.}) It means that all uses of builds_dir will get the absolute path. It may have consequences on meson configuration, and will make outputs and logs longer. I'm not sure this change is desirable. ^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] 回复: [PATCH v1 2/2] devtools: use absolute path for the build directory 2021-08-06 15:43 ` [dpdk-dev] " Thomas Monjalon @ 2021-08-11 3:14 ` Feifei Wang 0 siblings, 0 replies; 11+ messages in thread From: Feifei Wang @ 2021-08-11 3:14 UTC (permalink / raw) To: thomas, Phil Yang Cc: Bruce Richardson, dev, nd, Juraj Linkeš, Ruifeng Wang, david.marchand, nd Hi, Thomas Thanks for your reviewing. I agree with your comment. As your concern, this patch is simple but may have some negative effects. Thus I will drop it from series in the next version. Best Regards Feifei > -----邮件原件----- > 发件人: Thomas Monjalon <thomas@monjalon.net> > 发送时间: Friday, August 6, 2021 11:43 PM > 收件人: Phil Yang <Phil.Yang@arm.com>; Feifei Wang > <Feifei.Wang2@arm.com> > 抄送: Bruce Richardson <bruce.richardson@intel.com>; dev@dpdk.org; nd > <nd@arm.com>; Juraj Linkeš <juraj.linkes@pantheon.tech>; Ruifeng Wang > <Ruifeng.Wang@arm.com>; david.marchand@redhat.com > 主题: Re: [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the > build directory > > 01/06/2021 03:56, Feifei Wang: > > From: Phil Yang <phil.yang@arm.com> > > > > To make the code easier to maintain, use the absolute path for the > > default build_dir to avoid repeatedly calling of readlink. > [...] > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > -builds_dir=${DPDK_BUILD_TEST_DIR:-.} > > +builds_dir=$(readlink -f ${DPDK_BUILD_TEST_DIR:-.}) > > It means that all uses of builds_dir will get the absolute path. > It may have consequences on meson configuration, and will make outputs > and logs longer. > > I'm not sure this change is desirable. > ^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH v2 0/1] relative path support for ABI compatibility check 2021-06-01 1:56 [dpdk-dev] [PATCH v1 0/2] relative path support for ABI compatibility check Feifei Wang 2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 1/2] devtools: add " Feifei Wang 2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory Feifei Wang @ 2021-08-11 6:17 ` Feifei Wang 2021-08-11 6:17 ` [dpdk-dev] [PATCH v2 1/1] devtools: add " Feifei Wang 2 siblings, 1 reply; 11+ messages in thread From: Feifei Wang @ 2021-08-11 6:17 UTC (permalink / raw) Cc: dev, nd, Feifei Wang Add relative path support for ABI compatibility check. v2: 1. delete the code simplification patch due to negative effects (Thomas) Phil Yang (1): devtools: add relative path support for ABI compatibility check devtools/test-meson-builds.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH v2 1/1] devtools: add relative path support for ABI compatibility check 2021-08-11 6:17 ` [dpdk-dev] [PATCH v2 0/1] relative path support for ABI compatibility check Feifei Wang @ 2021-08-11 6:17 ` Feifei Wang 2021-10-15 10:02 ` [dpdk-dev] 回复: " Feifei Wang 0 siblings, 1 reply; 11+ messages in thread From: Feifei Wang @ 2021-08-11 6:17 UTC (permalink / raw) To: Bruce Richardson Cc: dev, nd, Phil Yang, Feifei Wang, Juraj Linkeš, Ruifeng Wang From: Phil Yang <phil.yang@arm.com> Because dpdk guide does not limit the relative path for ABI compatibility check, users maybe set 'DPDK_ABI_REF_DIR' as a relative path: ~/dpdk/devtools$ DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=build-gcc-shared ./test-meson-builds.sh And if the DESTDIR is not an absolute path, ninja complains: + install_target build-gcc-shared/v19.11/build build-gcc-shared/v19.11/build-gcc-shared + rm -rf build-gcc-shared/v19.11/build-gcc-shared + echo 'DESTDIR=build-gcc-shared/v19.11/build-gcc-shared ninja -C build-gcc-shared/v19.11/build install' + DESTDIR=build-gcc-shared/v19.11/build-gcc-shared + ninja -C build-gcc-shared/v19.11/build install ... ValueError: dst_dir must be absolute, got build-gcc-shared/v19.11/build-gcc-shared/usr/local/share/dpdk/ examples/bbdev_app ... Error: install directory 'build-gcc-shared/v19.11/build-gcc-shared' does not exist. To fix this, add relative path support using 'readlink -f'. Signed-off-by: Phil Yang <phil.yang@arm.com> Signed-off-by: Feifei Wang <feifei.wang2@arm.com> Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- devtools/test-meson-builds.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 9ec8e2bc7e..8ddde95276 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -168,7 +168,8 @@ build () # <directory> <target cc | cross file> <ABI check> [meson options] config $srcdir $builds_dir/$targetdir $cross --werror $* compile $builds_dir/$targetdir if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then - abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION + abirefdir=$(readlink -f \ + ${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION) if [ ! -d $abirefdir/$targetdir ]; then # clone current sources if [ ! -d $abirefdir/src ]; then -- 2.25.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] 回复: [PATCH v2 1/1] devtools: add relative path support for ABI compatibility check 2021-08-11 6:17 ` [dpdk-dev] [PATCH v2 1/1] devtools: add " Feifei Wang @ 2021-10-15 10:02 ` Feifei Wang 0 siblings, 0 replies; 11+ messages in thread From: Feifei Wang @ 2021-10-15 10:02 UTC (permalink / raw) To: Feifei Wang, Bruce Richardson, thomas, david.marchand Cc: dev, nd, Phil Yang, Juraj Linkeš, Ruifeng Wang, nd Hi, Sorry to disturb you. Have more comments for this patch or if it can be applied? Thanks very much. Best Regards Feifei > -----邮件原件----- > 发件人: Feifei Wang <feifei.wang2@arm.com> > 发送时间: Wednesday, August 11, 2021 2:17 PM > 收件人: Bruce Richardson <bruce.richardson@intel.com> > 抄送: dev@dpdk.org; nd <nd@arm.com>; Phil Yang <Phil.Yang@arm.com>; > Feifei Wang <Feifei.Wang2@arm.com>; Juraj Linkeš > <juraj.linkes@pantheon.tech>; Ruifeng Wang <Ruifeng.Wang@arm.com> > 主题: [PATCH v2 1/1] devtools: add relative path support for ABI compatibility > check > > From: Phil Yang <phil.yang@arm.com> > > Because dpdk guide does not limit the relative path for ABI compatibility > check, users maybe set 'DPDK_ABI_REF_DIR' as a relative > path: > > ~/dpdk/devtools$ DPDK_ABI_REF_VERSION=v19.11 > DPDK_ABI_REF_DIR=build-gcc-shared ./test-meson-builds.sh > > And if the DESTDIR is not an absolute path, ninja complains: > + install_target build-gcc-shared/v19.11/build > + build-gcc-shared/v19.11/build-gcc-shared > + rm -rf build-gcc-shared/v19.11/build-gcc-shared > + echo 'DESTDIR=build-gcc-shared/v19.11/build-gcc-shared ninja -C build-gcc- > shared/v19.11/build install' > + DESTDIR=build-gcc-shared/v19.11/build-gcc-shared > + ninja -C build-gcc-shared/v19.11/build install > ... > ValueError: dst_dir must be absolute, got build-gcc-shared/v19.11/build-gcc- > shared/usr/local/share/dpdk/ > examples/bbdev_app > ... > Error: install directory 'build-gcc-shared/v19.11/build-gcc-shared' does not > exist. > > To fix this, add relative path support using 'readlink -f'. > > Signed-off-by: Phil Yang <phil.yang@arm.com> > Signed-off-by: Feifei Wang <feifei.wang2@arm.com> > Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > Acked-by: Bruce Richardson <bruce.richardson@intel.com> > --- > devtools/test-meson-builds.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 9ec8e2bc7e..8ddde95276 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -168,7 +168,8 @@ build () # <directory> <target cc | cross file> <ABI > check> [meson options] > config $srcdir $builds_dir/$targetdir $cross --werror $* > compile $builds_dir/$targetdir > if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then > - abirefdir=${DPDK_ABI_REF_DIR:- > reference}/$DPDK_ABI_REF_VERSION > + abirefdir=$(readlink -f \ > + ${DPDK_ABI_REF_DIR:- > reference}/$DPDK_ABI_REF_VERSION) > if [ ! -d $abirefdir/$targetdir ]; then > # clone current sources > if [ ! -d $abirefdir/src ]; then > -- > 2.25.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-10-15 10:02 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-01 1:56 [dpdk-dev] [PATCH v1 0/2] relative path support for ABI compatibility check Feifei Wang 2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 1/2] devtools: add " Feifei Wang 2021-06-22 2:08 ` [dpdk-dev] 回复: " Feifei Wang 2021-06-22 9:19 ` [dpdk-dev] " Bruce Richardson 2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory Feifei Wang 2021-07-28 7:20 ` [dpdk-dev] 回复: " Feifei Wang 2021-08-06 15:43 ` [dpdk-dev] " Thomas Monjalon 2021-08-11 3:14 ` [dpdk-dev] 回复: " Feifei Wang 2021-08-11 6:17 ` [dpdk-dev] [PATCH v2 0/1] relative path support for ABI compatibility check Feifei Wang 2021-08-11 6:17 ` [dpdk-dev] [PATCH v2 1/1] devtools: add " Feifei Wang 2021-10-15 10:02 ` [dpdk-dev] 回复: " Feifei Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).