From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 0CE4B595B for ; Thu, 13 Nov 2014 10:40:43 +0100 (CET) Received: by mail-wg0-f46.google.com with SMTP id x13so16508299wgg.33 for ; Thu, 13 Nov 2014 01:50:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Q7Fm8oHRoOnRtuX+TnMLPl2hGyFnDBuPp9nxx3pm+MI=; b=AM1SYKChKTieX28MC0sJhE/VPtoWtM7exwyDiQA9dM6IqgFvVVk7ks/6Zco3z2As6I 4YzzPsYOUX/v0jv+OrAtSs5HhRlPM86aqm9lIvPabrl1gRZxxiNsfPTFg7kXzzNXPh0s Vrk1p9o4plWfDSn1UY52/WOHsHM5Lv6OhYwWpM/4vxWnkqNRWO8MahcbSt+VTrZoEKF+ 1hoKQBAHm88dxddteOKLau14FuFNrxfql0Ywc2mOJ8yIBwxbCvE373mjNyjfVtUlG/dS Dqq4brYCsmXhBM7Umvu7foCovDg29EOOItjyDTMbk+b4ecUg7Ib6LC+4vAjv/8483ltO Gd6Q== X-Gm-Message-State: ALoCoQlUu6Xk7WhPSdXtHPRRWWCdT9XtBF655XFcvjDzaPIdEbU65jDWwlxqxN3dIH5qgga6ABR6 X-Received: by 10.180.77.170 with SMTP id t10mr2109110wiw.57.1415872241114; Thu, 13 Nov 2014 01:50:41 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id lp14sm23066853wic.20.2014.11.13.01.50.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Nov 2014 01:50:40 -0800 (PST) From: Thomas Monjalon To: "Wu, Jingjing" Date: Thu, 13 Nov 2014 10:50:20 +0100 Message-ID: <2433359.CatIjmm0iz@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1413939687-11177-1-git-send-email-jingjing.wu@intel.com> <1414654006-7472-6-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 05/21] i40e: implement operations to add/delete flow director X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2014 09:40:43 -0000 Hi Jingjing, You didn't reply to Pablo's comment. Any news of this patchset? Could it be reviewed? Thanks -- Thomas 2014-11-05 21:18, De Lara Guarch, Pablo: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jingjing Wu > > Deal with two operations for flow director > > - RTE_ETH_FILTER_ADD > > - RTE_ETH_FILTER_DELETE > > Encode the flow inputs to programming packet. > > Sent the packet to filter programming queue and check status > > on the status report queue. > > > > Signed-off-by: Jingjing Wu > > --- > > lib/librte_pmd_i40e/i40e_ethdev.c | 3 + > > lib/librte_pmd_i40e/i40e_ethdev.h | 3 + > > lib/librte_pmd_i40e/i40e_fdir.c | 622 > > ++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 628 insertions(+) > > > > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > > b/lib/librte_pmd_i40e/i40e_ethdev.c > > index 8195e8a..fb43efb 100644 > > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > > @@ -4577,6 +4577,7 @@ i40e_dev_filter_ctrl(struct rte_eth_dev *dev, > > enum rte_filter_op filter_op, > > void *arg) > > { > > + struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data- > > >dev_private); > > int ret = 0; > > > > if (dev == NULL) > > @@ -4585,6 +4586,8 @@ i40e_dev_filter_ctrl(struct rte_eth_dev *dev, > > switch (filter_type) { > > case RTE_ETH_FILTER_TUNNEL: > > ret = i40e_tunnel_filter_handle(dev, filter_op, arg); > > Missing break here? > > > + case RTE_ETH_FILTER_FDIR: > > + ret = i40e_fdir_ctrl_func(pf, filter_op, arg); > > break; > > default: > > PMD_DRV_LOG(WARNING, "Filter type (%d) not > > supported",