From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1649945CDF; Mon, 11 Nov 2024 01:26:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B59364027C; Mon, 11 Nov 2024 01:26:16 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2042.outbound.protection.outlook.com [40.107.220.42]) by mails.dpdk.org (Postfix) with ESMTP id 7BD2E40151 for ; Mon, 11 Nov 2024 01:26:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q0quBce6Av0eRURSezsqxoQi70NFApxdV4ha9Ita61lNeytcq5CUp2pzUBOBNgL8Gz5H3r7TzNwfBp+uKwhgNDVD+ydFV44jVKmvsqUFhRK5PEeJEB2MdqYRLgghh0/U/F/xx7vhC0vziCiaSkvafcVIplVNEGNXbPFGD3F/kaNow5QQ2wggCImoTe0x7YMnZqvYhBeWJz1nE7uKbgJv6/1DAv6FKycgq7yVeWnJ5DV+bfsme0fL1o52tsKfyyafirrd/gEnkD45jEBJMiFXivVHp2oUoSXjdvpzns3ABB/TAEusRKytxk4LFxCLroIYDanSg1zpfYCB+AYaQl8fKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jHOOxSj7ApA7dYbwc3QiHddf9+RFGjnWwgl6X/tfLrk=; b=n1EW0Qz886NxJLcluVTg+RkZPfA4se1KKWv7ZGOX9x3VdSPxJ/eobzkogK4O4sqq/vYQPsuUCTXPON2cJwZVRuV2vq0hEqTKQFbI6boEvJnzrc7TcSJ1yt4OqTfuqNWFd/3kUkdP7rgYdh7dgMF0kODLlZsKSUn5f2Q0p2Ds1H0LArDRPKs8BULGgoXHfZlbdJnR9VD/+9hDk5QbaIHRpF/hk+sjR/r3itRJdkEi2VWEUR/sUWJs+CB/o7PSygwHnWFLXrKEFwAoSXaNtro8/J4sQwPIZQ5/wQs73VdmgueKYLS/VOQ8fZKLzi9zwJZVFJjdC3a+P4mHXuk1GQIUMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jHOOxSj7ApA7dYbwc3QiHddf9+RFGjnWwgl6X/tfLrk=; b=bIU5HZRN2j9Pt6Og5Wsqf1uUkBJuBxhZ+AviHLzDJXe3s/XMK/4ldnDsZlfSDsdD0P1b15VWe/qv0OETqqa6AY5mBKhc6cGYoYUkQLON7tqQ5tC2MaqhbJha0gHbiw9XC/ZVHhA7XqPrMcNH44LlA7BwZCeDJrrOVndYbMzrFYM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by SA1PR12MB6750.namprd12.prod.outlook.com (2603:10b6:806:257::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.26; Mon, 11 Nov 2024 00:26:10 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%3]) with mapi id 15.20.8137.027; Mon, 11 Nov 2024 00:26:10 +0000 Message-ID: <24362b50-5a63-42b5-81e7-e52d3d4acabc@amd.com> Date: Mon, 11 Nov 2024 00:26:05 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 00/17] Modify code as suggested by the maintainer. To: Howard Wang , dev@dpdk.org Cc: pro_nic_dpdk@realtek.com References: <20241108121123.248797-1-howard_wang@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241108121123.248797-1-howard_wang@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0364.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::9) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|SA1PR12MB6750:EE_ X-MS-Office365-Filtering-Correlation-Id: cd4b118a-78c8-486f-fc9a-08dd01e77124 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cWlhUkQ3UTUwSGVMTGxZR0d5eU5LWCsySWZDQ2c5NmZSQWpkaVlocEZycHBE?= =?utf-8?B?QmFvc2F3OVFHMEttblB2bXZ3V044NHNtaTAwS3hKVStrUnJLM3R0aUtEaVFF?= =?utf-8?B?OE9lNWZBenNvd29NV2NGbUd5Zm1EaFloT25hZUlPa3dLRTNuNWU2Wkptcnkv?= =?utf-8?B?NDZscEQvQTVaUGJpZ0xLWE1wSE5NU1U5YmJJSnY0TmhLSmlnV2piOGMxWG55?= =?utf-8?B?Wm9DQjZDL1hZcjBIWlJtbnFaNVlMQ1pBekRDcUJJQmxSUkQ4cnZzTjY2bC9h?= =?utf-8?B?VTZzSUs0QnBIdUg3dGJuUVRWbGltcllSZ3pwcVJha0VTaHl5UzY5V29mRkwv?= =?utf-8?B?a3NUM1FsYVpSL3UvMzkvQW5BaGVpaVhOcFliRTFUUFRwamxqdm1zdzU3Qk81?= =?utf-8?B?MGhEOVpPR3RGT1ZCQzd0bGFWUjYybU01elBxVm1hcDB2c0lFdUl3VGFCRWFD?= =?utf-8?B?dmVqYVc1Q2J6QUFnc0dWYUZMWFZJdDU0VmlKSGN6VGs0SVRQT2Q3dkZNcnZY?= =?utf-8?B?aEZKUFE4QWp2ODZtZzhnc1ZIaUJzVVVBU3o4NFRPU3R3YVFPOHF4ck4yQjJo?= =?utf-8?B?d2d6bnNCemtici9TOXFqbGZvbHUvK3hZL2dXNHlhQTJHbFpYamVaWmdiRHoz?= =?utf-8?B?K0NrWlZicG9QMzdaemtkams1SnlHUUVVVFhJakVrNjVkeUlGME1QVDAwNnRC?= =?utf-8?B?dDE4MjduV1NqWFAya2JkS3B4c05vZjNxV0ZKTi9MUnluRVRnKzZtRkZpdEtx?= =?utf-8?B?WW5zNm1LVnFHMkozWUxLMEwxK21lNS84RHNnTHlOUTQ4T2YrVmRleUU4K0xW?= =?utf-8?B?Zk8wWGJ1SlVYTzQwVU9uc2lQaEhva3l4UHJ0bk5yVDN1TCtxVVdPZmNpM3lC?= =?utf-8?B?bTlMdUVDd1FiRkluUVZod0hiM1FUU1RLUDhuTEdSMHZaQXg0ay9JRTIrZXJw?= =?utf-8?B?NU1ibXdzVXZPUGJ0UEZWcWNLZ1BZSnBRam5uRmlBUUluazBwUmJxYThyb0ll?= =?utf-8?B?YUc3dUFRZGtSd2VpOHpGUzBmaVo5TVh3WGJTTDdqUEcwY2xIOGg3MzhhNDdh?= =?utf-8?B?TTVWak9RRHFDOGRKcUJtYkN1WWhkMDI3emFaUlcwTWJOcGNLbTlQVDBXUkU0?= =?utf-8?B?UStQVExhZVU4NE8vbE9WSWg2OGV2akFlRGEzV1pJL002Y0RldWJsMmpEOWRy?= =?utf-8?B?R2NTRVJuODZDSmxyd3pSUU1hZXNjUXRrdjZkVks2NzRBUlZMb3FyU3B4Q2JT?= =?utf-8?B?UWhpWWlsMENlakN5ZkdiNzJtSXZzQ0t1aUZWdHUwbWdUQUxIMHQweWoyMFFy?= =?utf-8?B?M2RnMXpiQ09JSDdGaVNtQXBiMy9UYm1TTDE2c1JJRGZJODBuemdMaDlrR2FO?= =?utf-8?B?Nk10VWdFamNzZ2o0RWhEM3ZTeEcyY0czblFIblpuV0Y5SkNXaXNaeW5rOEYr?= =?utf-8?B?RFY0U0VkeDBGSkwwREFwRnNnaDZXeGtQODZrS0I3VXhzNjZkUm83N2tkeXNr?= =?utf-8?B?QTkxVGQyamVPdHJ5KzRIbDRnQ0dsbEZ5MllZaDVzSVpMdGQwUHo3RmQ5RXdQ?= =?utf-8?B?VmY5Z1ZUQXVhc3BvRUo5QUFlMnhRTCt5eWdoK1ZmdXBkUXp0WCtpcmNDbkVa?= =?utf-8?B?OFZKbTA3UWxLRnc0KzU2UHI2cUF4V3VOTEJGby8vTzlRZENySEtURHJ0RGxN?= =?utf-8?B?a3pSd2tLRzBSTnRaVlg4Rm5GWFY3WTNYZEw1TG5hZ2NUdlpObjFkdE5vVUQr?= =?utf-8?Q?eRpQ68MknXSPXtKWdg7QAvTsCHvYuK+RsSCX3Wg?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUk3UFU2eng1VmtyU05sRTJOeEU3MStoS0FTcDZBbmpMU3Uzbzh2dk5NMnY0?= =?utf-8?B?eTFEOS9ZMmx1M0ZuTmRQcTVTYXNxdG9QdTg4U0FZM05SUGZHOHFlVVZsTVli?= =?utf-8?B?Q0FSM0Z3T25MUm15VkZGNERqY2lFblVVMTZVejZNRW5FZjNaSExaaTVIZUNC?= =?utf-8?B?MnZkZlVtSzJSamVhYnFaWkJUaGpmTCt4WmkzRG9WazdBcmNpTXFpajNQV0lj?= =?utf-8?B?c3E5QW5RUVIvZ01JMEhraE1OTW8yU1VaVWROZ0Z6SlBTa3ViUWhVQTNseFNl?= =?utf-8?B?VHZvMXVUZm1rckorblVvV0dOOTlLRVJYa01iYm1sWEJGNmJtVVBDUW05aHNP?= =?utf-8?B?V0lDZWoxeDFzOStlRVhUWWlhNGg0VnNRTnVQWWNHLzkxSnZxUVJZdUdQeERE?= =?utf-8?B?OU5DR0NzYUNQR2VjcENtOElPNWZDcWU3SjJEUXVuenAxaFZyK2UxSVgwc2Uz?= =?utf-8?B?UUpqUlVUK01ndnRDR0JIeWR3YUo0NmsxcnhsZE1OYmdKUm1BODJ3RmNMN0FY?= =?utf-8?B?bkxTNStqR05OL3ZkdW8rMSsvUVpCNjVKRVlTWndYeURNU01sMjZxSGNrN0x4?= =?utf-8?B?bC9BY2lPR2ZOdmhwaHFJTFlvZS9JVXpCOHpTSmZYc1Fpb0kreCtaRmtZdmFL?= =?utf-8?B?OGE3ZS9ZVjFQc2ZvU3kvUnZnbHd5YVk4dTF0b1ZDcmljK3BocHNjU1IyaVNr?= =?utf-8?B?QkpNaXloUUJYRHpCeGhrUkhIWTlIb05qWFZ0bnhDekhoWXI5VFRYaEduYWZZ?= =?utf-8?B?Vi8rblRUZEw4cjJ2aStXdW9zNXlNUUl5MWV3RWZtWngvMnpwS1M2L1RzT0NJ?= =?utf-8?B?cXRtcm9LYStObUFNMnRvNlJXYXZxUWtBWk1CY1RubThtZ3FpU280YlAyclk3?= =?utf-8?B?L0V6WE0ybXAwVW03VGdPUGhyZ3E5N3JNZ2ZsQ2E2M25ieERpUUlETXFPdkty?= =?utf-8?B?eUY1OWtmNGJRTEsrYmxGcjlYNEk3Z3d3dnVheUxweW5WSE1xaUJYVlh4ald6?= =?utf-8?B?UmdBU1JsUTRwMjJHWVkyaTIxZ2lGOERsNkFvdWY0RjdNNXIzQXEwN2c1bjc1?= =?utf-8?B?d1ZQSW9FQytYYjRaaFhQZXp4TGpUaGo0eFF0b1BubThqU0JLT3hEU25Wejcy?= =?utf-8?B?R3g4N0xNRlQ1ZnFyeVhDZHRTais1cnlTSUpibXdzYmZ2Y3pDTFZ2RlR0cE9x?= =?utf-8?B?cFZlNGphTGNrcGUzcERPV1hlVmNZYytLQ252dnFTcExkR29BV2Jxa2kybFZC?= =?utf-8?B?QnNJMEErNHdNcDF6c1hHV2x5bTh6SGdaaU0yT1AybmJxVVVDd29mMzZYM0xj?= =?utf-8?B?ZGZvUURLV2p4dklSSTh1bmpjYXA2dkVuY3dPb0dHUnF4YmxpUjNNNys1azRK?= =?utf-8?B?eHY5SW9ZN1daT2sra09JdSt4SlNEb0VzMURrSHNuTW51aEZDN0FKMjhlOHRL?= =?utf-8?B?bG5sRlZpOTJmd0NicXByeU5udDdPS201NTREVDJUZ01VSVRVZXcwTENGMlFM?= =?utf-8?B?aU5tRkRqcU9XZURvRktpWUV6MzM2QWd1SEY0NmxybnNnaTExVzFYUFV2WnRO?= =?utf-8?B?dGdGL2c5UHl4UkNGQlJMUFNCZUFUUmdFN0x1cUx4YW82emVZWkNXYXJ6dXBy?= =?utf-8?B?Y3czYTNMMWpCaXQ3L05vTllucmVjS20xblM0WFQxYXZGR1lDSENWRHpCcEd0?= =?utf-8?B?ZzZTNnh4bUJyQnJBYVR6UUNQQW5xWUJlT043RUZFeHNjcmRveUVjTG5jWncz?= =?utf-8?B?dzNyemJIajh0NEtnaGRCSjczRVJsTzJPV1JxNnFiaUJwZEViOUY2QXpYOHRW?= =?utf-8?B?QXlDRW8xSFNxS2tjNURFTFpFRW9lMFNTZm44Vmg0b1ZxZVl4TitnZUFMbEU5?= =?utf-8?B?QmkwSkVBN3o2VnJFem1na29oVVBRVWowWlhjVTNSZWVYOUZaQlBEUGQ1OFRG?= =?utf-8?B?clVDdys0R1lPNGt6YkVGVmI4K3l2aWJDVFhKTmgvaFFZUGVCcGFLN2FSUExo?= =?utf-8?B?aWcxcmxlbGFkSGo1bWEwbVNYUEFwNlhjVVVvdG9Nb2tlSlgzV0hFcE40WW93?= =?utf-8?B?QjEvSDZLSzR1a2FwaURqWGFueW8vdFROYXppYWIyWjFNbTh4SVgrOElnNitG?= =?utf-8?Q?nHcl3QFPIXcLQr220pGdBZp+o?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd4b118a-78c8-486f-fc9a-08dd01e77124 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 00:26:10.6201 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p1lrZLf843pyKNSUNDXRBGgbi3a0dRd2+SJGQPNzLEZL0ctqfRfaIM7JEJt5VCA2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6750 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/8/2024 12:11 PM, Howard Wang wrote: > Remove some headers and code that are not used. > Improve r8169.ini and r8169.rst gradually. > > Howard Wang (17): > net/r8169: add PMD driver skeleton > net/r8169: add logging structure > net/r8169: add hardware registers access routines > net/r8169: implement core logic for Tx/Rx > net/r8169: add support for hw config > net/r8169: add phy registers access routines > net/r8169: add support for hardware operations > net/r8169: add support for phy configuration > net/r8169: add support for hw initialization > net/r8169: add link status and interrupt management > net/r8169: implement Rx path > net/r8169: implement Tx path > net/r8169: implement device statistics > net/r8169: implement promisc and allmulti modes > net/r8169: implement MTU configuration > net/r8169: add support for getting fw version > net/r8169: add driver_start and driver_stop > Hi Howard, Thanks for the updates. Series should build after each patch, but it seems broken in the set, starting from patch 4/17 there are some warnings, and they are fixed after a few patches. But can you please sure it builds fine after each patch? Above build issue is the main blocker for the set, but there are a few minor issues listed below: 1. please fix issue highlighted by check-git-log.sh `./devtools/check-git-log.sh -n17` 2. Please fix meson syntax warnings `./devtools/check-meson.py` Also I put some comments to individual patches.