From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09D07A00C2; Sat, 25 Apr 2020 14:19:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98CA11C1A0; Sat, 25 Apr 2020 14:19:01 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id B212D1C19E for ; Sat, 25 Apr 2020 14:18:59 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 0B601A75; Sat, 25 Apr 2020 08:18:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sat, 25 Apr 2020 08:18:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= /PSYBmA+jQLGO9/D22xz3PyWew4YijH6NTRPOAjvEy4=; b=RNq7bPUZpHnl+UZ4 2SydCV1jghB13QI6m/499MK5xDSVsNoIP1KXhkiKgNc2q1uze/BGw4HHa+30fZgh tLggcsYZGkofEYc4ns/505W8ebyobLYybaqlRK/dTDKFYxIzHymqv5hxWL7CWAwP VDBpo2SJDdp5Py+luofvhifbR4IyLDMnjWM3t82O1LjX+NDpC3yEx7Xbp8N/Dd1j ZgMr0l6Jffhc2l0rRZjj7WxDqp409IAbwZD0MGeh8NuyzKgKMVsSFyw4ZKzgTPlb wZX9D5wvH8kVXVsub17dXp47feH+HBI9Y/yXo1clGm/9ztF7qtxgP0rDUoc/lWI/ 7tYmHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=/PSYBmA+jQLGO9/D22xz3PyWew4YijH6NTRPOAjvE y4=; b=qG0gwsXr7zBWD9MqfR3H7y/VgCLr7yPUoAVLxIri+H/+qSHmsqB5NMx+r HXqnpLDYHOzEx5GSQQ5XAT6u761qUIgOYZ6FXw9wP8D4OE5XqgGitSH5LYmCS/8W qhMCaP8AZ1/wqxiAVyavYut5euRfBPR+QgT1Wi6s4Dg5eApKXyJEVHdmhvBYxVpe wa48/LJ9Zs+VFFo9CLcG5xMrNfGj1T9i9brwg6U9L8NrleZml18pNkM7C/N9FhQD lc6wtmyhw3OiIkHoVTNUQmBmZKUH2wqkKXi38YgMBd0/EP0RSxWu7URS5u0W9bvy FM1YWPzvVlGj6mGp5U4iO7L4imH3A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheeggddviecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DC90F328005E; Sat, 25 Apr 2020 08:18:54 -0400 (EDT) From: Thomas Monjalon To: Aaron Conole Cc: "Burakov, Anatoly" , dev@dpdk.org, Konstantin Ananyev , Pavan Nikhilesh , Bruce Richardson , David Marchand , Ferruh Yigit , Lukasz Wojciechowski Date: Sat, 25 Apr 2020 14:18:53 +0200 Message-ID: <2436414.XQYqjrCR6X@thomas> In-Reply-To: References: <20200415172547.1421587-1-aconole@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 3/3] ipfrag: add unit test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/04/2020 19:34, Aaron Conole: > "Burakov, Anatoly" writes: > > Nitpicking, but i believe the coding style guide discourages using > > boolean syntax for anything other than boolean checks, and it is > > better to use a more explicit `if (x == NULL)`. > > I see, it does. Looking at the code-base, I see it mixed all over, some > places using 'if (!ptr)' and others 'if (ptr == NULL)'. Actually, even > in the flow_filtering.rst doc, it implies that if (!ptr) is acceptable. > > Since I'm spinning a v6 with the constants, I'll fold this change in - > maybe it makes sense to clean it up everywhere to help mitigate the > confusion (for example, I most recently did work in the eal and the !ptr > is all over there). WDYT? In general I agree cleanups are good, avoiding confusion. About changing the whole codebase, just for styling I am not sure. Please let's start with documentation fixes and discuss whether to move forward.