[dpdk-dev] [PATCH] net/dpaa2: remove unnecessary loop for unused pool entries

[dpdk-dev] [PATCH] net/dpaa2: remove unnecessary loop for unused pool entries

[Gavin Hu]

Currently only one buffer pool is configured and in use,
looping for up to maxmum 8 times is unnecessary and might
be buggy as assigned uninititalized values.

The fix is to loop for the configured times with initialize
with valid values.

Fixes: 16bbc98a3e ("bus/fslmc: update MC to 10.3.x")
Cc: stable@dpdk.org

Signed-off-by: Gavin Hu <gavin.hu@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
 drivers/net/dpaa2/mc/dpni.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dpaa2/mc/dpni.c b/drivers/net/dpaa2/mc/dpni.c
index 69cf119ce..9f228169a 100644
--- a/drivers/net/dpaa2/mc/dpni.c
+++ b/drivers/net/dpaa2/mc/dpni.c
@@ -198,7 +198,7 @@ int dpni_set_pools(struct fsl_mc_io *mc_io,
 					  token);
 	cmd_params = (struct dpni_cmd_set_pools *)cmd.params;
 	cmd_params->num_dpbp = cfg->num_dpbp;
-	for (i = 0; i < DPNI_MAX_DPBP; i++) {
+	for (i = 0; i < cmd_params->num_dpbp; i++) {
 		cmd_params->pool[i].dpbp_id =
 			cpu_to_le16(cfg->pools[i].dpbp_id);
 		cmd_params->pool[i].priority_mask =
-- 
2.11.0

Re: [dpdk-dev] [PATCH] net/dpaa2: remove unnecessary loop for unused pool entries

[Shreyansh Jain]

On 7/31/2018 1:21 PM, Gavin Hu wrote:
> Currently only one buffer pool is configured and in use,
> looping for up to maxmum 8 times is unnecessary and might
> be buggy as assigned uninititalized values.
> 
> The fix is to loop for the configured times with initialize
> with valid values.
> 
> Fixes: 16bbc98a3e ("bus/fslmc: update MC to 10.3.x")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Re: [dpdk-dev] [PATCH] net/dpaa2: remove unnecessary loop for unused pool entries

[Thomas Monjalon]

31/07/2018 15:52, Shreyansh Jain:
> On 7/31/2018 1:21 PM, Gavin Hu wrote:
> > Currently only one buffer pool is configured and in use,
> > looping for up to maxmum 8 times is unnecessary and might
> > be buggy as assigned uninititalized values.
> > 
> > The fix is to loop for the configured times with initialize
> > with valid values.
> > 
> > Fixes: 16bbc98a3e ("bus/fslmc: update MC to 10.3.x")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > ---
> 
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied, thanks