From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 9DCAC8055 for <dev@dpdk.org>; Mon, 15 Dec 2014 23:42:40 +0100 (CET) Received: by mail-wi0-f172.google.com with SMTP id n3so10431676wiv.17 for <dev@dpdk.org>; Mon, 15 Dec 2014 14:42:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=wM5osLwHoKv/O0W57GEWTehQ4sSvfI4qBO8CzRpZSxo=; b=lgKvY3IXkWFDDQMK2caTPc/vBilX2HOnuWibb18C7eJxmfG1g2rS7KOP2DGM8u9bXl 9NB5uUMcWGnC8+XmFJsFySNNY828T/gVxBhU01nl4/q3QI/Az9YG5OqTZRfgaaT5RL+b ZpJJkqs1eai+EPW1BBMiHC9pfqw4POSYvzKgYonxsAdWcrrPTbIjLZaqC67vOJBVEJU6 wpSMSbFK6f7NIDRQNnkXqLwtty6JZZlEfR2op9yWkQ497IaD9DWyxuan9uC7tBO08+Gp 2WTftKxglBgR0O4wnYvxM+x9hg0ZR5ohoEI/z/QKE6KfdThbCHvH/xyepsmb2pWkmwtU MM6Q== X-Gm-Message-State: ALoCoQl/of9IWpr/BRDud1KJ98D+GR13u7cuZqFWwqPTUueDdwJskv3rLDZPCB9REOFOtafYlejL X-Received: by 10.194.87.100 with SMTP id w4mr57360154wjz.65.1418683360445; Mon, 15 Dec 2014 14:42:40 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id p14sm14869548wie.1.2014.12.15.14.42.39 for <multiple recipients> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Dec 2014 14:42:39 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Neil Horman <nhorman@tuxdriver.com>, stepan <stepan.sojka@adaptivemobile.com> Date: Mon, 15 Dec 2014 23:42:14 +0100 Message-ID: <2438199.ui6ep4sFDa@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <20141208144910.GE3237@localhost.localdomain> References: <kzlhosux2e.fsf@adaptivemobile.com> <20141208144910.GE3237@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [dpdk-dev, pcap] pcap: fix build of all-in-one shared library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 15 Dec 2014 22:42:40 -0000 2014-12-08 09:49, Neil Horman: > On Tue, Oct 07, 2014 at 12:14:04AM +0100, stepan wrote: > > Build of some of the test binaries fails when the following flags are enabled: > > > > CONFIG_RTE_LIBRTE_PMD_PCAP=y > > CONFIG_RTE_BUILD_SHARED_LIB=y > > CONFIG_RTE_BUILD_COMBINE_LIBS=y > > > > The binarieas are missing symbols from libpcap. This > > patch adds the missing '-lpcap' linker flag into the respective Makefiles. > > > > Signed-off-by: stepan <stepan.sojka@adaptivemobile.com> > > > > --- > > app/cmdline_test/Makefile | 4 ++++ > > app/dump_cfg/Makefile | 4 ++++ > > app/test-acl/Makefile | 4 ++++ > > app/test/Makefile | 4 ++++ > > 4 files changed, 16 insertions(+) > > > > diff --git a/app/cmdline_test/Makefile b/app/cmdline_test/Makefile > > index e9eafd2..ce44fd5 100644 > > --- a/app/cmdline_test/Makefile > > +++ b/app/cmdline_test/Makefile > > @@ -47,6 +47,10 @@ SRCS-y += commands.c > > CFLAGS += -O3 > > CFLAGS += $(WERROR_FLAGS) > > > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) > > +LDFLAGS += -lpcap > > +endif > > + > > include $(RTE_SDK)/mk/rte.app.mk > > > > endif > > diff --git a/app/dump_cfg/Makefile b/app/dump_cfg/Makefile > > index 3257127..513ce59 100644 > > --- a/app/dump_cfg/Makefile > > +++ b/app/dump_cfg/Makefile > > @@ -35,6 +35,10 @@ APP = dump_cfg > > > > CFLAGS += $(WERROR_FLAGS) > > > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) > > +LDFLAGS += -lpcap > > +endif > > + > > # all source are stored in SRCS-y > > > > SRCS-y := main.c > > diff --git a/app/test-acl/Makefile b/app/test-acl/Makefile > > index 43dfdcb..ea063fd 100644 > > --- a/app/test-acl/Makefile > > +++ b/app/test-acl/Makefile > > @@ -37,6 +37,10 @@ APP = testacl > > > > CFLAGS += $(WERROR_FLAGS) > > > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) > > +LDFLAGS += -lpcap > > +endif > > + > > # all source are stored in SRCS-y > > SRCS-y := main.c > > > > diff --git a/app/test/Makefile b/app/test/Makefile > > index 6af6d76..e456140 100644 > > --- a/app/test/Makefile > > +++ b/app/test/Makefile > > @@ -145,6 +145,10 @@ CFLAGS_test_kni.o += -Wno-deprecated-declarations > > endif > > CFLAGS += -D_GNU_SOURCE > > > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) > > +LDFLAGS += -lpcap > > +endif > > + > > # this application needs libraries first > > DEPDIRS-y += lib > > > Acked-by: Neil Horman <nhorman@tuxdriver.com> NAK, it doesn't seem to be the proper fix. LDFLAGS should be automatically filled in rte.vars.mk. Will send another proposal. -- Thomas