From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1BAFA0547; Wed, 21 Apr 2021 14:09:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85E4B41ABF; Wed, 21 Apr 2021 14:09:05 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 4385E41ABE for ; Wed, 21 Apr 2021 14:09:04 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 18CDE203B; Wed, 21 Apr 2021 08:09:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 21 Apr 2021 08:09:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= GoHMvrmeoOzV3PO8E9/IlCi7jdLw7UMW2DKqwkztP2E=; b=ashIn3s5u0LKjy7H /CYVKfWCJlTsw17y6FSkgIUFzMBDERgAb8S4JZQYlN615RcDwvR6/IWc/6M3NXl/ QsRszNqlO7CSZ+dl/xQn1IldadY+6UqTesznp3+006bOqT9SZg9U6txzGfYAcjJs XR3Rk7f9reXKWTyJsKOwz52wJZlDsRcqsPZJXjz5/oao7ScwlDtFtkK0utsTjuAU IfMF8E/BzWGMBm4dcPorFljuwkt+3Hw/6KcavSc5NPHMdGe5CxQqDcsF4bPy3x+w 5s1U0MQ1Hs9JrqfKghWchXokIh3KnIblnoDlabexG75ZMs2CaESzxy+YhPjOUxnB FJD0kg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=GoHMvrmeoOzV3PO8E9/IlCi7jdLw7UMW2DKqwkztP 2E=; b=KQytPomqYpPw1lQ+qssetjaoW0ugD/Kn8uk6/H5u+XfVHHj8PvR6O1uvZ iah0QV5oPxdbW91CwNnzZYLqxw/wdqQ60hG4KdU45CyCmcHO+YDud2+ZHBBRbIs6 pQi6oeUCLlFZKqhFnq3XYWGUxTlpb3WWLXLWxeuNnHwWcLENEF/ZhLZ2CfaExubW hYWBrRso71IC1fBcj/Lc/w95H+j8VjZ43FxhgZ6GSewS0X864JpX4yxJTjhXUjs+ LZz3lXYgQK9qGf4hGCy/dTJPqBX8HwHkf9Mv/u54rfvtGcLIC2OHSqlS462vWlWI VtugA8PU6Pkvcji3ZjQaeeiqh19gg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddtkedghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhephfefvdeuheejleeltdefveelhfejfefhveelfeevvdehieejleej lefffeevgeehnecuffhomhgrihhnpehmvghsohhnsghuihhlugdrtghomhenucfkphepje ejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CEDF61080063; Wed, 21 Apr 2021 08:09:00 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Wed, 21 Apr 2021 14:08:58 +0200 Message-ID: <2440980.e6NH8AvO49@thomas> In-Reply-To: <20210420102232.314452-1-bruce.richardson@intel.com> References: <20210401115009.1063844-1-bruce.richardson@intel.com> <20210420102232.314452-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 00/16] Build file updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/04/2021 12:22, Bruce Richardson: > This set contains 5 changes/updates to the DPDK build and build files. > > The changes in this set are: > 1. Use "continue" keyword, new in 0.49 to shorten and reduce indentation levels > in the foreach loops when building library or driver components. > 2. For libraries, drop support for header-only libraries, which was added just > for the "compat" lib which had a single header, and is now part of EAL. This > similarly reduces indentation levels and makes the code easier to follow > 3. Since the larger blocks of meson code in our repo is seeing massive > whitespace changes, take the opportunity to switch our indentation style for > meson files from that of C-files using tabs, to Meson/Python style using > spaces.[1] > 4. Remove the "librte_" prefix from all our library directories. While as useful > cleanup, the main driver for this was that it simplifies the matching for #5 > below. > 5. Add a "disable_libs" build option to allow the user to optionally not build > certain components. Include in this an explicit list of libraries which are > "known safe" to disable in the build. For now this is a short list of three > libs, all of which are safe because they are not buildable on FreeBSD. More > work is needed to expand this list in future. > > [1] https://mesonbuild.com/Style-guide.html#tabs-or-spaces I went an extra mile to align files list in drivers. That's a big bang applied for 21.05-rc1. Please could you try to set up the git trick to skip some of these changes in the git blame? Thanks