From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75A9BA04FF; Wed, 27 Apr 2022 14:16:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 188A040E78; Wed, 27 Apr 2022 14:16:01 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 7B4DC40691 for ; Wed, 27 Apr 2022 14:15:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651061759; x=1682597759; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=yzNiJyGwai6mX02C36a0js3dFRsQz9n9NN1u4CIpWCU=; b=cbFxoSnVf5mKzpsBtCYQvTutc6L/bjb/Gzb47kKYEdErOIzMzCNucn9J v7vvgyyLrXzdbEpI9aXRcexDn8d4wq1eikXYW+QEHIQ5sf6qLmNdDtmiG 5xX9E2keV/2uQVH8LF0fKwY3QcQYTN08HHM3ex6Bm2Q8IsKbZX5re7nBK u6ItTn2cz1rmDjL/Pd1ad3I9KkyycSYwXJ3Gr1FY9FYd2xgd/D6mE9mrp AceqKUWG3IhUCW/J1rY1tM4r2xpCDHvGIJu2dyYoDUfswqhYCY4NfMrnG QK8yacgwtXsMgO7jDNQWPmus/+pnYkSbm5jv0AFVpHKQKVmg5CtkbVQX/ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="264754066" X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="264754066" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 05:15:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="533178382" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga006.jf.intel.com with ESMTP; 27 Apr 2022 05:15:58 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 27 Apr 2022 05:15:57 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 27 Apr 2022 05:15:57 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 27 Apr 2022 05:15:57 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 27 Apr 2022 05:15:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=doXKlnlax36cdfteD0gmn5thio3zR+peoiS6eDnHW3gZ80LU99xGjtpKu3kco3uphggYyCS/7hc6x9p80+FZaQNq/7AVuDnAfaDgSWvJADQYQlwMXjWAhyVHwV8T1aOYZoMFJhQ3rWE4MJLppWooAFre5SMbEmaL5FOLnABmh8umcBnI8k0grQFpwWmzOYxW1sZL4/zix9PMEpPugyH9BMn/Tjc59HvpkoPMhcZW1s6eI4XEydnUuQXYt3YHq7L+EZYL181e6WMACJGu5j+L2b3JMw8mXt52k3zMKuskFckhp5dkOgbPEj9OioduAfZkWKzxcOrI1ENC3CEyhBGHAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aMQd/5IwAWZpeXaXiIbi2W3Jk5WktlcnLvZ8PwBuGdg=; b=LDmxN0ieb4XKDjxLfwbBB5wP1dcKhV+VI9ajyrfRIYSuMx899is7xYk5qQnjs8npADgpNZYpL/4kRdAb/o6i1g8yzkQLr3no+hpX1l8HSYXod0+9+ONmJFaZqqez5cBSxLi0+yY1sKYNbor4xtEoIb0p4u1oFMyxJi4pzKgipPvP9a9304HxOayelCLmq09Vnm12XyyzyA/TOI3Dv1ca8l/iaMxj9xxn2LNMLlNAWf9wuDGJdwC7gF1JWOyvugp0rzEnPpfl4DYrIEfXpPXF8fWZy1Fd3pij8BFUnmXutWcwNWO8tOmJ7i1aJ2dbVEAo+0DjfGjifvqctQ1FiwWmOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by DM4PR11MB5995.namprd11.prod.outlook.com (2603:10b6:8:5e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Wed, 27 Apr 2022 12:15:56 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::c3c:359:d9c4:3a54]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::c3c:359:d9c4:3a54%4]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022 12:15:56 +0000 Message-ID: <24445fab-6aa3-a8e0-0faa-e32b8ddb2eef@intel.com> Date: Wed, 27 Apr 2022 17:45:45 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/2] app/testpmd: fix stats get when display fwd stats Content-Language: en-US To: "Min Hu (Connor)" , CC: , , References: <20220406084537.16799-1-humin29@huawei.com> <20220406084537.16799-2-humin29@huawei.com> From: "Singh, Aman Deep" In-Reply-To: <20220406084537.16799-2-humin29@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN0PR01CA0052.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:49::21) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3b0d0673-6671-46ac-2f17-08da2847ae38 X-MS-TrafficTypeDiagnostic: DM4PR11MB5995:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aZHwyeYwmXv6h8C/kihdvmS4UGwjT+DdOrwDIHvBDEv5vanYRaqfFVC1kYdqC5mRffwAkW7ArcWxMUNrVk6y98YrvYQ8TtNwYhH6o8oUKQ/rTOnDcxQaWBFV60lV3oY5VqsBHVLqJh+tFu6era0uTQYwKMHU2JSD/r/MOCgVVJ3uihMF+wjuqEIS4pGSNdSVlydcxdKbcY9lE7XF19raoggDD+MApeRuA9EWYF8Xig6Zwv5IS32vRX/+lNAfJ3KlW/Y/gBEAy/Sl9XA8DbTbxfWw5V39WhyJDoz8zm5CSrGYXYkYkoV5AH7P7NxtH//0Hms2tKhB6rc3shVMUyfeh6aokTzmckp4bHOzDjpuWVeofmOTdpNZLd/AqIxhQUplpMagzvTAxy3GrBIm+YIE/b29SG2fMtQanJ7Rmj/Zp9ZYTqpUXnFBOlCDYo4Z2xKmFW7yqcFhsLmFcdurSRToTDkWgZfyDqxNEb86Dkf/qsyICVKiao/+5RNhyFSnX/2IDBj2s63VK/7lCdyOybABNebh5tychgZDRWdxI+1mqXe+z6J+/p9rlgyYW2Vm+ghFS6ghunmMUG1UJ8otvmzvvMAW6AsLPnzq3qOnV4+XkmwRDFJBf1nOdOrbzJe/QneqW81RaqsgQZHhqzQ+RFfDuwcv4Bm8nWJ3MXFwiwauj0x4J3yt4zteasDcKUydULd2qjw5dCXTe2s+59aIcxslkZxcrrLr8vXjCSAUKg/SsDo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(316002)(6486002)(66556008)(26005)(66476007)(2616005)(8676002)(508600001)(86362001)(6512007)(66946007)(6666004)(82960400001)(4326008)(5660300002)(31696002)(53546011)(8936002)(6506007)(36756003)(83380400001)(31686004)(107886003)(186003)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUVRU1I3d0kvSlpvcXFTc2EyVUFZK0xDdmhhSldDd09Gck5ic3dDR3UxQyt4?= =?utf-8?B?RGErV3RDQU1QcHNMZlNBZHdRdllEbk83Rk8rL3luV0ZSZEZrZlh5K0w4Sk9i?= =?utf-8?B?ejhJYUh1VlYydS8yRVZIYkExV0NYWXUrZE1yMEFISDN3N3RpUVpTa2NTTkp1?= =?utf-8?B?RWNMemw3VU1SQ2dwVlJxSGdtNDZjRGpOTnpzT3lkbFhKb2pMM0FFdmVhQVdj?= =?utf-8?B?SWpJR3lDaDFJVlFGbkx3U1RMQ0xwaTBJYktvYy9IRGtLc3lwYWttR3dhSDZk?= =?utf-8?B?cktUR0tPQTRjRHJVVlNyUCtxdTRHV21oUWQ5VktBNU9UVFAwcHVieitwNUxi?= =?utf-8?B?dXY0OWtDVzZ2L1o3bVZZc2RjdlBMaExVbm1vdHVWZmYxbnJnVVNCREpEUUdh?= =?utf-8?B?Q2dMZlB0NXEvckkvZG95MWVnQUhKaE1jRGJoUnI2S0NFZ0RuQzliMUFmMmdm?= =?utf-8?B?aFdQdnJ0V0ZFOVFhUzJSVmFMZmxKQWNPNmlCcHl6eWNEWTJ1Z0U3NzdqQlQ4?= =?utf-8?B?RFEvOXdJck9pSFh3UDNGZ1RKWURDMjRvZFk4cHJ5eFFkOWtUVU9MSVNGZDE4?= =?utf-8?B?ZWZpd28wdmFra2VTTzI2ZHdsYkUwdVdIaDd5UmJHVVpEeTR4SW50M2NaaUdO?= =?utf-8?B?QzVkajlPdUR1eDlKakRTclJwVjhSQ2JsNXUyNnFERUZua0VRRlhiVVBMVlYw?= =?utf-8?B?akxsZ01CZCtla2U0VC9Fd0w1MFk3U2JrQktIbFdoUW5LYTlES1craEtaRmRC?= =?utf-8?B?SWVjYldKdjUwS2tGejF2L0pWd3lIMnRCNUkyVkpRMlcwaEZLa0x3S3FqbHls?= =?utf-8?B?Kytrdm9OYnJxVkhqL1g1UkhxcDJDejNYd2lKeFpBTG55eHhLa2xWLzJOYjNp?= =?utf-8?B?b25oZmRiN1NxN01vZXZKdWY0b2N4ZlhpcEFhSzdsbllkSnRiLytuL1hBOElM?= =?utf-8?B?YTVtSTI2eXo2a1hWeFQ1OElVc09ET2hlZ2l0bzcvT2FaVXRoK0pXTDVzbFBq?= =?utf-8?B?djM5ckNFNmJFREdYMkF2cm9vcG9rT1lUcEZtem9yaU1Qd1pad2xZKzFsQlpJ?= =?utf-8?B?c242Qk0wakpBWGRrSm1zY0NxanBlQVMvR1hwRER4WUswSEhZQm1ucDJ1aHRx?= =?utf-8?B?ZjYxVVFmbFg1Zks0NGx5Tk0xVXUwV2ZyZ09UWjVnUkFBSHpPMU16dTMzVEdu?= =?utf-8?B?VkdKSzhlaHhFd25DY3ZvWkQ2L1hacGxvdGdCa0RoOWVjRFg1R2xLU0NoVjhC?= =?utf-8?B?MzRFSXBLVXlJem1RUVJtQWpKazhlTzRzTWR1M3BmMzM5ek5uK1U5d2d0eUVr?= =?utf-8?B?S0c3dGZWa2IvWVk1M0RTNG5aMVNWOEtJaGp3UFVVVlNraG1wSTl2clFjOHYw?= =?utf-8?B?bFVvK3ZvUGFEblpBMlZkbUZieTNUQ0trOHBPK2ErUVN3RmNnc0w0dGxxNnhV?= =?utf-8?B?QmxBcWFkaDdycUozUEdmTDNIMjVuR0NIdWp1cG8yWVBXRk1wWVUzWVZUbE0r?= =?utf-8?B?a0twZ250SDVjclZDNWR2VDhmYmRSYVhHNGllRzNnZ1NLelA5OGVQMzhxYVA3?= =?utf-8?B?aTQ3WG8zd0hOYVZBank2UWJMdlZlSzc5RGM0N1cxdVBpSVVsYlRlTTAzcU5v?= =?utf-8?B?WU5oWXozVzNBZCsraFUvVUtWbFBIS1ZsWmRxei9PZkpuMTVsQ0lsNHNzVStJ?= =?utf-8?B?RXNYZmFJNUhaeFh1bUNNLytHU1JFMTJKSzhWcnpmWU9aalBMR2FmNDFyZDRt?= =?utf-8?B?amdFd1pHcmxYTkV6a2dYdUUvT3UvcldodjVMSk44RHRZME1hc2podmJua0dO?= =?utf-8?B?REN4ckU3NHY3SHRoNDhYNzlrV21RRXFhakZqemtNYi84MWU4MytKUVB2MVpJ?= =?utf-8?B?VjBtc1VZaXB1d2xaZjN3ZUV6YVZVNFY0OERORHlSTExrd2lpVFpwK2JSSmY5?= =?utf-8?B?WFFkQmJqMGUxa0tpYlFtMnh5STJZanpsOWMyQkI0NlpjcGppcDdjMHNxY0dW?= =?utf-8?B?Vlpjd3E0Qkdndi93WDh3RjQvUXpLeVpPVnR2QnFkQUo0RXdIQ3dlUTdlZ2c1?= =?utf-8?B?VUN1aVlBcjBQM01hK3owaytUZ3FaY2pSd05vcXpqUlZOSjdiZUo4cmh0dTZo?= =?utf-8?B?TXIwRGdFM1hFREI0QUJDUTM5TWpqMWt3L1pzNEtIU0NzV1l1QWVFUkJuSXp2?= =?utf-8?B?WUhpc3IvWWpvY2s4LzBKVmU3L2RSOS9YcS9sZ2RmaTNGaGwvdmJXVE9ZblBP?= =?utf-8?B?eE43b2dDdGJDS29NVHVjdlg2a0J0cHI2RmhIYjlxeXNlNmcvRUszZXAzakhr?= =?utf-8?B?NU9TQjRWRjRRMjlTb0ZyRWJRRmg5MDc2ZUwvYTFTTyttVE92VHowQzUzbEZz?= =?utf-8?Q?0S+Fp80soZ4HzNBU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3b0d0673-6671-46ac-2f17-08da2847ae38 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 12:15:56.1427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zpk8aqKZPdrdeIezHLH7jMZqfdk8HkoZeqDCMHDacFUdOGqCvB6cNzvN6AQ6CPt+VwWx7o9UPIP2t62jjtOKCj2Pn5jUY1ViNtz6wJw4Gpw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5995 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/6/2022 2:15 PM, Min Hu (Connor) wrote: > In function 'fwd_stats_display', if function 'rte_eth_stats_get' fails, > 'stats' is uncertainty value. The display result will be abnormal. > > This patch check the return value of 'rte_eth_stats_get' to avoid > display abnormal stats. > > Fixes: 53324971a14e ("app/testpmd: display/clear forwarding stats on demand") > Cc: stable@dpdk.org > > Signed-off-by: Min Hu (Connor) > --- > app/test-pmd/config.c | 10 ++++++++-- > app/test-pmd/testpmd.c | 16 ++++++++++++++-- > 2 files changed, 22 insertions(+), 4 deletions(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index cc8e7aa138..bd689f9f86 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -249,14 +249,20 @@ nic_stats_display(portid_t port_id) > diff_ns; > uint64_t mpps_rx, mpps_tx, mbps_rx, mbps_tx; > struct rte_eth_stats stats; > - > static const char *nic_stats_border = "########################"; > + int ret; > > if (port_id_is_invalid(port_id, ENABLED_WARN)) { > print_valid_ports(); > return; > } > - rte_eth_stats_get(port_id, &stats); > + ret = rte_eth_stats_get(port_id, &stats); > + if (ret != 0) { > + fprintf(stderr, > + "%s: Error: failed to get stats (port %u): %d", > + __func__, port_id, ret); > + return; > + } > printf("\n %s NIC statistics for port %-2d %s\n", > nic_stats_border, port_id, nic_stats_border); > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index fe2ce19f99..79bb23264b 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1982,6 +1982,7 @@ fwd_stats_display(void) > struct rte_port *port; > streamid_t sm_id; > portid_t pt_id; > + int ret; > int i; > > memset(ports_stats, 0, sizeof(ports_stats)); > @@ -2013,7 +2014,13 @@ fwd_stats_display(void) > pt_id = fwd_ports_ids[i]; > port = &ports[pt_id]; > > - rte_eth_stats_get(pt_id, &stats); > + ret = rte_eth_stats_get(pt_id, &stats); > + if (ret != 0) { > + fprintf(stderr, > + "%s: Error: failed to get stats (port %u): %d", > + __func__, pt_id, ret); > + continue; > + } > stats.ipackets -= port->stats.ipackets; > stats.opackets -= port->stats.opackets; > stats.ibytes -= port->stats.ibytes; > @@ -2108,11 +2115,16 @@ fwd_stats_reset(void) > { > streamid_t sm_id; > portid_t pt_id; > + int ret; > int i; > > for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) { > pt_id = fwd_ports_ids[i]; > - rte_eth_stats_get(pt_id, &ports[pt_id].stats); > + ret = rte_eth_stats_get(pt_id, &ports[pt_id].stats); > + if (ret != 0) > + fprintf(stderr, > + "%s: Error: failed to clear stats (port %u):%d", > + __func__, pt_id, ret); Should we clear "ports[pt_id].stats" in this condition. > } > for (sm_id = 0; sm_id < cur_fwd_config.nb_fwd_streams; sm_id++) { > struct fwd_stream *fs = fwd_streams[sm_id]; As such LGTM Acked-by: Aman Singh