From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B2CAC1B221 for ; Wed, 10 Jan 2018 14:50:50 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 320D920D2C; Wed, 10 Jan 2018 08:50:50 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 10 Jan 2018 08:50:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=LvnxpQ2xSWtMeRXi8mA35fW5u6 q42rOscaLag8oPXlM=; b=nvj/ZeWOXKiYjrnTB+7xZreqk1hdumrk3IHbLXp8CC DSsWyCc3pR+tXk95ZNa9jhW/h+5vQ7/8wPmKYmSlfMZs0TjDRE7SE3asnYbzCdRX CWi3q7ZeT1+j25I7gI4j4t/2PFUYphqlyATyTAe2neI25bhHGNzCSyOgGfTAPiz3 Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=LvnxpQ 2xSWtMeRXi8mA35fW5u6q42rOscaLag8oPXlM=; b=Ur0m65NgDA0/4hjjwi+Red MLweTbLW4xzVs0WzTRrS0h1cVcpBlUzHBS4XxSzoXO2uh3D2sWrD3w/wLCI8ZBo8 OFVGN8ZpaxNl9OprO1Vi5JWjZxm/RyYmywfFsdozPAYX2/E4YN/Y9rWUXNyul4AR LYZHeUUjfO4gybQdz18hCRL+wMv8fvgFS0XSPspjILusbCda1+df8suYeG0VcEDs p4s+32CeD94GVDoA8KSyN1SWcgazLpv3IJ9RTqJaoyLKMOC4mjqCr57T67y/Bt99 u4DudxXwMagCRe/beM8ZmZ2uvTzCK5y2hvXrwD6xMg36qAiGWniSBi95Z6hEnyuw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C5F16247FF; Wed, 10 Jan 2018 08:50:49 -0500 (EST) From: Thomas Monjalon To: "Rybalchenko, Kirill" Cc: dev@dpdk.org, Adrien Mazarguil , "Wu, Jingjing" , "Xing, Beilei" , "johndale@cisco.com" , "neescoba@cisco.com" , "nelio.laranjeiro@6wind.com" , "yskoh@mellanox.com" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Chilikin, Andrey" Date: Wed, 10 Jan 2018 14:50:23 +0100 Message-ID: <2447540.PENus5WeOb@xps> In-Reply-To: <696B43C21188DF4F9C9091AAE4789B824E2B6786@IRSMSX108.ger.corp.intel.com> References: <1511785787-127452-1-git-send-email-kirill.rybalchenko@intel.com> <20171204174304.GK4062@6wind.com> <696B43C21188DF4F9C9091AAE4789B824E2B6786@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 13:50:51 -0000 Hi, 09/01/2018 16:16, Rybalchenko, Kirill: > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > > On Mon, Nov 27, 2017 at 12:29:47PM +0000, Kirill Rybalchenko wrote: > > > Increase the internal limit for flow types from 32 to 64 to support > > > future flow type extensions. > > > Change type of variables from uint32_t[] to uint64_t[]: > > > rte_eth_fdir_info.flow_types_mask > > > rte_eth_hash_global_conf.sym_hash_enable_mask > > > rte_eth_hash_global_conf.valid_bit_mask > > > > > > This modification affects the following components: > > > net/i40e > > > net/enic > > > net/mlx5 > > > net/ixgbe > > > app/testpmd > > > > > > Signed-off-by: Kirill Rybalchenko > > > > Can you elaborate a bit on the need for these changes? > > Have you considered implementing those future extensions through > > rte_flow instead? > > Hi Adrien, this is not a new feature but rather fix of existing limitation. > In current implementation the symmetric hash mask and flow mask are > represented by 32-bit variable, while hardware bitmask has 64 bits. > Unfortunately, this modification changes ABI of the library as it changes size > of rte_eth_fdir_info structure. All related PMDs (listed above) had to be modified > accordingly. This ABI change is not announced. Unfortunately it will have to wait the release 18.05.