DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ravi Kerur <rkerur@gmail.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] doc: Merge l3fwd and l3fwd-acl documentation files
Date: Sun, 07 May 2017 22:50:17 +0200	[thread overview]
Message-ID: <2449201.3f6kNIuhA3@xps> (raw)
In-Reply-To: <1493145557-17160-1-git-send-email-rkerur@gmail.com>

Hi,

25/04/2017 20:39, Ravi Kerur:
> Merge relevant contents of l3fwd and l3fwd-acl documentation.
> Modify l3fwd document with ACL specific information.
> Remove l3fwd-acl documentation file.
> 
> Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> ---
>  doc/guides/sample_app_ug/img/ipv4_hash_rule.svg    | 158 +++++++++
>  doc/guides/sample_app_ug/img/ipv4_lpm_rule.svg     | 139 ++++++++
>  doc/guides/sample_app_ug/index.rst                 |   1 -
>  doc/guides/sample_app_ug/l3_forward.rst            | 326 ++++++++++++++++-
>  .../sample_app_ug/l3_forward_access_ctrl.rst       | 385 ---------------------
>  5 files changed, 614 insertions(+), 395 deletions(-)
>  create mode 100644 doc/guides/sample_app_ug/img/ipv4_hash_rule.svg
>  create mode 100644 doc/guides/sample_app_ug/img/ipv4_lpm_rule.svg
>  delete mode 100644 doc/guides/sample_app_ug/l3_forward_access_ctrl.rst

I've not looked at the content.
I just do not understand why a patch for merging content is adding
some new files.
Moreover, these SVG files contains some binary PNG.
Please send only some source files.

  parent reply	other threads:[~2017-05-07 20:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 18:39 Ravi Kerur
2017-05-05 16:15 ` Mcnamara, John
2017-05-07 20:50 ` Thomas Monjalon [this message]
2017-05-08 21:04   ` Ravi Kerur
2017-05-08 21:00 ` [dpdk-dev] [PATCH v2] " Ravi Kerur
2017-05-10 10:14   ` Mcnamara, John
2017-05-11  1:51     ` Ravi Kerur
2017-05-11  1:49   ` [dpdk-dev] [PATCH v3] " Ravi Kerur
2017-05-16  9:27     ` Mcnamara, John
2017-06-04 11:17       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2449201.3f6kNIuhA3@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=rkerur@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).