From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jijiang Liu <jijiang.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure changes
Date: Tue, 21 Oct 2014 12:26:26 +0200 [thread overview]
Message-ID: <2450996.3KDeDxoTz7@xps13> (raw)
In-Reply-To: <1413881168-20239-2-git-send-email-jijiang.liu@intel.com>
Hi Jijiang,
2014-10-21 16:46, Jijiang Liu:
> Remove the "reserved2" field and add the "packet_type"
"Remove and add" can be said "Replace".
> and the "inner_l2_l3_len" fields in the rte_mbuf structure.
Please explain that you are using 2 bytes of the second cache line
for TX offloading of tunnels.
> /* remaining bytes are set on RX when pulling packet from descriptor */
> MARKER rx_descriptor_fields1;
> - uint16_t reserved2; /**< Unused field. Required for padding */
> +
> + /**
> + * Packet type, which is used to indicate ordinary L2 packet format and
> + * also tunneled packet format such as IP in IP, IP in GRE, MAC in GRE
> + * and MAC in UDP.
> + */
> + uint16_t packet_type;
Why not name it "l2_type"?
--
Thomas
next prev parent reply other threads:[~2014-10-21 10:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 8:45 [dpdk-dev] [PATCH v6 0/9] Support VxLAN on Fortville Jijiang Liu
2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure changes Jijiang Liu
2014-10-21 10:26 ` Thomas Monjalon [this message]
2014-10-21 14:14 ` Liu, Jijiang
2014-10-22 8:45 ` Thomas Monjalon
2014-10-22 8:53 ` Liu, Jijiang
2014-10-23 2:23 ` Zhang, Helin
2014-11-12 13:26 ` Thomas Monjalon
2014-11-12 14:31 ` Zhang, Helin
2014-11-12 15:23 ` Thomas Monjalon
2014-11-13 3:17 ` Liu, Jijiang
2014-11-13 8:53 ` Thomas Monjalon
2014-11-13 11:24 ` Liu, Jijiang
2014-11-13 11:35 ` Thomas Monjalon
2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 2/9] librte_ether:add VxLAN packet identification API in librte_ether Jijiang Liu
2014-10-21 10:51 ` Thomas Monjalon
2014-10-21 13:48 ` Liu, Jijiang
2014-10-21 21:19 ` Thomas Monjalon
2014-10-22 1:46 ` Liu, Jijiang
2014-10-22 9:52 ` Thomas Monjalon
2014-10-22 12:47 ` Liu, Jijiang
2014-10-22 13:25 ` Thomas Monjalon
2014-10-22 5:21 ` Liu, Jijiang
2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 3/9] i40e:support VxLAN packet identification in librte_pmd_i40e Jijiang Liu
2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 4/9] app/test-pmd:test VxLAN packet identification Jijiang Liu
2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 5/9] librte_ether:add data structures of VxLAN filter Jijiang Liu
2014-10-21 15:13 ` Thomas Monjalon
2014-10-22 2:25 ` Liu, Jijiang
2014-10-22 9:31 ` Thomas Monjalon
2014-10-22 11:03 ` Liu, Jijiang
2014-10-23 9:06 ` Chilikin, Andrey
2014-10-22 6:45 ` Liu, Jijiang
2014-10-22 9:25 ` Thomas Monjalon
2014-10-22 13:54 ` Liu, Jijiang
2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 6/9] i40e:implement API of VxLAN packet filter in librte_pmd_i40e Jijiang Liu
2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 7/9] app/testpmd:test VxLAN packet filter Jijiang Liu
2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 8/9] i40e:support VxLAN Tx checksum offload Jijiang Liu
2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 9/9] app/testpmd:test " Jijiang Liu
2014-10-21 14:54 ` [dpdk-dev] [PATCH v6 0/9] Support VxLAN on Fortville Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2450996.3KDeDxoTz7@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jijiang.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).