From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id B54A66A96 for ; Tue, 21 Oct 2014 12:18:30 +0200 (CEST) Received: by mail-wi0-f173.google.com with SMTP id fb4so9646322wid.0 for ; Tue, 21 Oct 2014 03:26:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=DMw1yMUAeGfHwtWhUfRKGz7S7938aRM5shrxK2Sts7g=; b=IRC05PDypykve50Mubw6IAK2FQA8AF7GxpKR8fhF/0yjZdjkCgnUgTonenFe9cV210 4cl1bjmFaGOKSiRsPm6lAZaicypL/9zuMsbvPMXZwKE23cr3b+NBnNpQSRmnNK+MvR6R uovIatLv03zSav+peBklHrE8shPwwfEUn6KSe04+N/GuVvAGK2Cya0dkKzeTsScz46KB /KT8Eqt6MNI/fzkvw0BBK5lkPf01ans0EE96aC7GtjaDFfJTJVTgjWRy4qDboj7FD0JL +hlVN2CwjQe2uA71pOYM7K4+/C754K6yRMtac4Fo9uZoRSo61vibmMZablF7WfIJN6ir QxEQ== X-Gm-Message-State: ALoCoQlpB1XGQbsi/QauIaVCC3aUZdiTz6SDJGbs2Z7qksCDl+oPGIn4+m9sQxfAEBr2k3SekLdi X-Received: by 10.194.250.68 with SMTP id za4mr40337101wjc.83.1413887205819; Tue, 21 Oct 2014 03:26:45 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id q10sm14892549wjq.35.2014.10.21.03.26.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Oct 2014 03:26:45 -0700 (PDT) From: Thomas Monjalon To: Jijiang Liu Date: Tue, 21 Oct 2014 12:26:26 +0200 Message-ID: <2450996.3KDeDxoTz7@xps13> Organization: 6WIND User-Agent: KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; ) In-Reply-To: <1413881168-20239-2-git-send-email-jijiang.liu@intel.com> References: <1413881168-20239-1-git-send-email-jijiang.liu@intel.com> <1413881168-20239-2-git-send-email-jijiang.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2014 10:18:31 -0000 Hi Jijiang, 2014-10-21 16:46, Jijiang Liu: > Remove the "reserved2" field and add the "packet_type" "Remove and add" can be said "Replace". > and the "inner_l2_l3_len" fields in the rte_mbuf structure. Please explain that you are using 2 bytes of the second cache line for TX offloading of tunnels. > /* remaining bytes are set on RX when pulling packet from descriptor */ > MARKER rx_descriptor_fields1; > - uint16_t reserved2; /**< Unused field. Required for padding */ > + > + /** > + * Packet type, which is used to indicate ordinary L2 packet format and > + * also tunneled packet format such as IP in IP, IP in GRE, MAC in GRE > + * and MAC in UDP. > + */ > + uint16_t packet_type; Why not name it "l2_type"? -- Thomas