From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0E10A00BE; Thu, 10 Feb 2022 17:00:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9693A42745; Thu, 10 Feb 2022 17:00:25 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 4EB57426EE for ; Thu, 10 Feb 2022 17:00:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644508823; x=1676044823; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=kBuJIOL0aUQeKE5w3qGO4Rk0haJciDm1EF03c4koN6M=; b=hcf4NeoKixNjD6q/2B8vCx2AQSsP8DpoirOcfofEtZgevLa8+ep0fF2Q FiV1MxriAibWqvmB2j4sTY9Rucjv4Q/rFCMMNbOdbxvm5gpqyawH3yE/B 0aUB0nx/HNLgmMMhr7EyNgYoJkLNJ+YbIb8PNn0eYAPT4aquIUtIAeBPr orzpyxgbW/8zCi5IsEYGKXI4XlD/daSvV0auKve8HLOyKTlluqKELBn8E 0BFxM1NfSfBwpk6BFgg8yKrr6Dmp8pHrNOefcclNXhdUmppjidGdJXdN3 aUCY/JwXisF8TenYGOCjxehIV87KX7KDGMqPx867C+JqQ+sqNhFfbFfQE w==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="230165469" X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="230165469" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 08:00:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="701734160" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga005.jf.intel.com with ESMTP; 10 Feb 2022 08:00:21 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 08:00:21 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 08:00:21 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 08:00:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FqnltttIufUpQeLGVszWvgcqByrctaBmgWI43f1rEY+oaS+fWCZTAz2b2k8k0N7CvTwi/rFlCS4ogBerrtENuo5VTm8jV9NgaCsrJcAlKtvPv5Ta0y9b2yHVGXJ3gGSPsPprrKZjqsPHDB01SItUNBRSLiCkiJc4nmhJGjoFpLarrRw8g21Lo315V8w5Kfps5RiDBqvcxqUBJnPJz0GmQY8X5PEVPLKgeqqv66yL8ftvDe/LZEAu9JmIuLAtGdhavE/ldvSCuZGLXgLRNpCMuUEHV2raDjt0YZSC8f79LtfwCmvzIpP+D2ZIKkyTpfRl0MeXy0+htfyZq+syXi8KfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a7W369nFbraFFSUGlF8toMBuBwXJdhlQ1bCLiFb7Eh0=; b=F1KyXXoG+tMAPImcvxHYJR7b5qIQjh3yoIW+zx5pLOkwLF4QZsQXZP3F11iT+ureuSk42mGnaJPWhoNFi3NA+l2AitNF+EYdW3dKzXAgAQcSEzF0YJdtwnhs81folndGxC4NznTHPrZDmecclOBEn0MtII5YVf/V1e+thSwno25PJAU/ncmhvi6rQqPBOUWwJgFzScjhMtzZLeDAaM7sF0b4gv84OK4PTdkHiptE/zdMWUzbIz8JSLMCOjQ/fIw8hKX9/lbrCMxescaIGeU9OghswpXs3lZ746w4ELsynhpB25wXfNoAaPdnx8gA3l/JHjE/YVdCo2EKbrWWEUIJ+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MN0PR11MB6033.namprd11.prod.outlook.com (2603:10b6:208:374::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Thu, 10 Feb 2022 16:00:12 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 16:00:12 +0000 Message-ID: <245157e3-1948-f207-9cdd-88ce22cad453@intel.com> Date: Thu, 10 Feb 2022 16:00:04 +0000 Content-Language: en-US To: Alexander Kozyrev , CC: , , , , , , , , References: <20220206032526.816079-1-akozyrev@nvidia.com > <20220209213809.1208269-1-akozyrev@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH v4 00/10] ethdev: datapath-focused flow rules management X-User: ferruhy In-Reply-To: <20220209213809.1208269-1-akozyrev@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0094.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::9) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: db86ced3-045d-4664-e00e-08d9ecae6b53 X-MS-TrafficTypeDiagnostic: MN0PR11MB6033:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gK1uhyDwE1qR3JXoHGeWN985X5vPk+0z7NsNX5sRD82PkWQnRQZV1g8GrEdjNaOP8902gqNUCqj1awq5nSRqzFH4IDuhiIMV1Y1gRb52P9Cq9rgSPovWfoEQ4FUIiVlX9YwSCad7PY/oKHPrKwnmivSgfXRkgZa5yQWsPkpvyMjjOl8RH+PYe/713KpLft2pnz4MvU4reG4fs8Q6W3HXEfOyq0wcfh7heAfqFefa2v8ZGYPnyhwpsgJEmnjYcqWhR3PMIjSVX5XdpIFYRtAm5iTZfoPwsUYcAcIdbenjt2yBL+M26r/YTqAImyG+TYlDKSuETxEXTUutaYeovhr9e1EgjnNaXeBSD3Vx1rtDlqJtQ6eltA2wrce6JZR05Cdq0Fx36iRe5YsbQRgPpB8vbNqfKWRWH61Z+nfgpE63GS/u7JBFlNTA2h7alfhcwPx2oV/H/Cc45ZsGKHzS1Icw2kBxSd+EArqpGviKBS8wUW4+E3+n0vv5M0a7rbWjsLJmdqTae1iDIIJYa9oytFec8oYgCKelSuRLh+OwY8+w0Nq0fdM1td/UNWCUxnv1e6qQe8JDQrgAbidpuWFDnnKoVWcec9AtQnSD4+zcyDsTwRLnto95dM1xJV6fPpbLvsWNGkGgeNR5dpWpyu6lMSHzGQlyEKrga0gYdbbNDXvzQbLw9Uhr5PGdk0vL62+YRnU7Tr4dc8tl8GTnuI/dXM0foh6s/mINLuFlp+EE3DvzrdFpjDIEKBSp/XlyVk6zLToGbbFtLqPFhUPqzTiFyNgkYpVesWtz8gSnFpdh1f3dhOo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(31696002)(508600001)(53546011)(55236004)(6666004)(6512007)(6506007)(5660300002)(2906002)(31686004)(44832011)(82960400001)(316002)(66476007)(38100700002)(8936002)(66556008)(6486002)(36756003)(66946007)(86362001)(966005)(186003)(107886003)(83380400001)(2616005)(26005)(4326008)(8676002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emtEQ3UweVpWcHFmcGR4akdMZnRFMkdweFJiS3pjQzhQSk5NamVqd0I3Tnly?= =?utf-8?B?d25BM3JodEUrRnEra1BmT0tRdzlHMGxPNkE0dTRvckFQQld2OHloUm96MzBL?= =?utf-8?B?UU5YSEdDY05BVkxUQTBxTTM5eHhHNC85NEtQbDhaVTUyWEtkdndrSzU4QnRR?= =?utf-8?B?STRaRlR6UGZObWhzdFhYbHpnVndZUXRCOGY0NktLUllxM3RXNTJzdnFUSXJY?= =?utf-8?B?azMwRFhIWmZHcTZCV0wrcm1UV2R0YnNxVkhwNXpUc29LMnVLTjh3Ni9pdi9s?= =?utf-8?B?NldURDRrSmxJejA1NC9vd1VFWGd0SVlvR0lnY1pWYmo5MDFNSHpnOCtheEZV?= =?utf-8?B?VEhsT1VsMjgvTWljOVRMcTcvS2JoV2ZnWU1SbTl2TEI4QWF4SlAveGlWMHNF?= =?utf-8?B?eEt0eTg2dVFPSnVUdUJzbDBMZEtDRWVkeWpqL3d4Q3VHNklLY1dFYXRRcTFX?= =?utf-8?B?TytSWjVsOGR6dFE0RHprY2pOSVVhWW45SXVDK0NSbDJuWERRKzB4V1JIempn?= =?utf-8?B?NTdFTEcrbVRxMytYQlowOFlNTDE2aVhpUllpeVNySnVpT2FKSS92R1JDYjJs?= =?utf-8?B?K3hZMVQzUTQ2M1NIYkY2akcwWGlmQTJobW40WFdiUW51UlF0UHpKamhXN3RQ?= =?utf-8?B?WndXMCtlNkJMakhaM2ZMM096MTR1amlLWG10R3BmQ0hsN2swNmhUbHdMUmh1?= =?utf-8?B?YlA0WGVWYytNWGt0UHpHM1l6Lzl3RzR0blROcVZpdVplelhQQ3dvMTBoNERl?= =?utf-8?B?YVRIditYTFdUb0YvNS85R3NWVGZpSUlRb3hNSzhzZ0I4aStzaDhYZVJnSC9v?= =?utf-8?B?eXE2THFXUHhQaERxOXA3QzhOMnl2eGRCWTZaTTMwUjZmaEsweEh1OHpXUEtz?= =?utf-8?B?b3RETGo3eDNmNDNtV1M3YUxEWHlPMjZNMjZWTXFUUWU3ZDBTbHFjODVMOGx2?= =?utf-8?B?Z1NpMnRQN2tDa2FaT1UyL3crQzhUK1k5STBkUjE2d25rb1V2R1JMRS9wQzZP?= =?utf-8?B?SUg0QVl5S01UTEtWQUNobUhSeU9SdlFVeTA1T1A0aEFydm5ldERFRGxqZXNa?= =?utf-8?B?WFJGT1A3SmllQzlndnRGZUdpcFhvdW52cTFML1ppOE1sT2lMY3BMdVRlZXNH?= =?utf-8?B?SEhrNVlLZVBaZ0ZJVm0ybVRKdEFxMFVVVXpXK01BUGRBdVNFaDNMT3JPUVZw?= =?utf-8?B?cVpLQ0Vjc3BtbmsxbmUvV0JQZFVhVWlsemE2azVGbWkzTmtiMUVqT3FQL2hI?= =?utf-8?B?bFc2NXo4ZFhRUklUQU1WZGorcmRPYk81dW9DMlM3RXMwUGt2WVpwYW5rVnU5?= =?utf-8?B?RmNsU1F4bGIwUEpNb1AwbEVUb0lTU0VuN2JwYVNoYzBHRDBaWFd3SXFBNU5k?= =?utf-8?B?TUd6MWdYOGthNEorTWErTytQUEVxeml4YWpZQUpwRFNjWVdUZFlsb1kybzdi?= =?utf-8?B?YkkwaFN4NDkxU2dyTEVlME5La29BZk93UFRNN2ZGdHRUSEFNOEhBNkJtOUQw?= =?utf-8?B?MG16WXRidHhoelJLZWFsUFNKZWJ0NjdpazY2NjlEWUhmR0RTV3NXLy9mN0Fp?= =?utf-8?B?WWVwclcxWVN0NS9Uci92bC9zUkR3R28wRHhmRVMxcDlYTjFaY3B1YzYvMlFl?= =?utf-8?B?NXI0cTd0OFNva0JMR2VzZDFNU3VEZE5Da05tMVNPVmhKckovaVJ4eUtMWUtH?= =?utf-8?B?eWUwdjRUazVhOWNiYUxxRUZsYWRMUzJkdzVlMFhMQnJKSUpMUTNneEtta1ZV?= =?utf-8?B?TUw1NlQrK29LM0QxRjJmVEFENHZrR3VxRTE3YkVJYy9Hb0ZORnV1OEVVVkJL?= =?utf-8?B?ZDhIcFdhQUJCWWhvT1hGNzNMSjl2MGpTOU81ckdRemJCNlN5YkUvRkowVnNw?= =?utf-8?B?aWdGRFhTSTdLdzkzZXhhRjV1SnV2VGw3cktiNXAvZ3MrQkFuRVhTMDZSTmhS?= =?utf-8?B?VmNoNHFuK2F6TUY2OUVlNkIzb3lyaUFHcmdXUkdSc2ttSDVuTEVmekVDL1VS?= =?utf-8?B?Z3E3cVhzRUhmWXVqNGd4ampQNGVFeStDUk1NWU5HY1VXcEppN2Vpa2tNbjhk?= =?utf-8?B?QW5nSHdFSm5Fd1IxVXBPa1MwUWxzWjkrMjQ4SzBERm5IcWlPamVwbzEyS3VW?= =?utf-8?B?STF2QU1ScW9USEFuM3FybCtBTlIwc0J2U0U1TERQMnJRYUV2aU5neXZIUEl4?= =?utf-8?Q?qIv7LaXBLtl2IhIIB15e7vU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: db86ced3-045d-4664-e00e-08d9ecae6b53 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 16:00:12.1258 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GHlNc0t2S6NZ+5dEg5IQesiulnPviEgQ0Fj91PwMWNKkuCrjBc/6MmCvuJkJpb0SVSTvrLA8kNseQqakvQhhQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6033 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2022 9:37 PM, Alexander Kozyrev wrote: > Three major changes to a generic RTE Flow API were implemented in order > to speed up flow rule insertion/destruction and adapt the API to the > needs of a datapath-focused flow rules management applications: > > 1. Pre-configuration hints. > Application may give us some hints on what type of resources are needed. > Introduce the configuration routine to prepare all the needed resources > inside a PMD/HW before any flow rules are created at the init stage. > > 2. Flow grouping using templates. > Use the knowledge about which flow rules are to be used in an application > and prepare item and action templates for them in advance. Group flow rules > with common patterns and actions together for better resource management. > > 3. Queue-based flow management. > Perform flow rule insertion/destruction asynchronously to spare the datapath > from blocking on RTE Flow API and allow it to continue with packet processing. > Enqueue flow rules operations and poll for the results later. > > testpmd examples are part of the patch series. PMD changes will follow. > > RFC: https://patchwork.dpdk.org/project/dpdk/cover/20211006044835.3936226-1-akozyrev@nvidia.com/ > > Signed-off-by: Alexander Kozyrev > Acked-by: Ori Kam > > --- > v4: > - removed structures versioning > - introduced new rte_flow_port_info structure for rte_flow_info_get API > - renamed rte_flow_table_create to rte_flow_template_table_create > > v3: addressed review comments and updated documentation > - added API to get info about pre-configurable resources > - renamed rte_flow_item_template to rte_flow_pattern_template > - renamed drain operation attribute to postpone > - renamed rte_flow_q_drain to rte_flow_q_push > - renamed rte_flow_q_dequeue to rte_flow_q_pull > > v2: fixed patch series thread > > Alexander Kozyrev (10): > ethdev: introduce flow pre-configuration hints > ethdev: add flow item/action templates > ethdev: bring in async queue-based flow rules operations > app/testpmd: implement rte flow configuration > app/testpmd: implement rte flow template management > app/testpmd: implement rte flow table management > app/testpmd: implement rte flow queue flow operations > app/testpmd: implement rte flow push operations > app/testpmd: implement rte flow pull operations > app/testpmd: implement rte flow queue indirect actions > Hi Jerin, Ajit, Ivan, As far as I can see you did some reviews in the previous versions, but not ack the patch. Is there any objection to last version of the patch, if not I will proceed with it. Hi Alex, As process we require at least one PMD implementation (it can be draft) to justify the API design. If there is no objection from above reviewers and PMD implementation exists before end of the week, I think we can get the set for -rc1. Thanks, ferruh