From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B413AA0487 for ; Mon, 29 Jul 2019 22:06:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4426F1BF56; Mon, 29 Jul 2019 22:06:31 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C5C241BF53 for ; Mon, 29 Jul 2019 22:06:29 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 66D4C2227B; Mon, 29 Jul 2019 16:06:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 29 Jul 2019 16:06:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Jv2+Z65PFB/vuvRG3RWhMXI8pt/UxngBt2tuTXNlZgc=; b=EeNsmaHlUvVf QCIfXpJ6CjMdOMNV3sj+DEPkuAEs6QzCc1/8VZNu2n0Ugk4FpwEs7MT6hsIGy3hq WRoEE+CBJC6NyhDikVyM36MGaG114vbUz+IlayA/QvihoVpGqeV/TsjDtJPKcAjk UTleljCxRQb16FRHfbILt6LYPzEhgKA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Jv2+Z65PFB/vuvRG3RWhMXI8pt/UxngBt2tuTXNlZ gc=; b=twixdB0BL54HKTdpc5/5+oigMGwETJMn8JNmGTVs6uuS25fmbOYeTe59K 0yQwQRy7f7l1n0y4pu1Kl+RyX2Nl0hGNj8PsjSWuKehJvKsCmPJdbwqombDuuwld BfRZF+OarsIJQ1qQjVl0iZm1qCpOBXuzLhT0G8UsgYoMMlbljW29tE+IoC6lmUoE i0KgxrLvnX5Dbs+ahVY6+/E33ktF90U1NHH8XN0JZxMUxwUTtSMvXxi5kZliJ6mQ +ahd5A3bco0pQ2RP1HVatX7fi4E5UsW8t7RWjvSYXPyzjIzZxNOaODXUejKiD7aU xLn9jA5xMA3aMfvWXizw/dCBZgg+Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrledugddugeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 34626380083; Mon, 29 Jul 2019 16:06:28 -0400 (EDT) From: Thomas Monjalon To: "Morrissey, Sean" , "Laatz, Kevin" Cc: dev@dpdk.org, David Marchand , Gaetan Rivet Date: Mon, 29 Jul 2019 22:06:27 +0200 Message-ID: <2451654.9878AJQY2f@xps> In-Reply-To: References: <20190724152059.17859-1-sean.morrissey@intel.com> <5173895.pTg1DfyaZ9@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/07/2019 10:40, David Marchand: > On Sun, Jul 28, 2019 at 9:55 PM Thomas Monjalon wrote: > > 25/07/2019 10:42, David Marchand: > > > > > > 24/07/2019 17:20, Sean Morrissey: > > > > On further investigation, the full fix involves > > > > a change in the EAL command line parameter handling, > > > > which is probably too risky for RC3. > > > > No way you change the command line parsing, > > except the rte_option which was created for telemetry. > > The history of this "simple" feature is already full > > of hesitations which made me hesitate to merge. > > Please, don't force me to dig in the code, otherwise > > I will be tempted to do a big "clean-up". > > > > > > This revert will allow telemetry to function again, > > > > but with the erroneous message still in place. > > > > We will aim to fix in the next release. > > > > > > Might be good to look and revisit the rte_option api. > > The patch on eal did not make any sense. > I am for reverting it too. OK, reverted. Next time I will see a patch for telemetry, I will ask all questions and will check by myself.