[dpdk-dev] [PATCH] ethdev: fix corrupted device info in configure

[dpdk-dev] [PATCH] ethdev: fix corrupted device info in configure

[Ferruh Yigit]

Calling dev_infos_get() devops directly in rte_eth_dev_configure cause
random values in uninitialized fields because devops doesn't reset the
dev_info structure.

Call rte_eth_dev_info_get() API instead which memset the struct.

Also remove duplicated dev_infos_get existence check.

Fixes: 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters")
Cc: remy.horton@intel.com

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_ethdev/rte_ethdev.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 4b713a184..9304b0d4b 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -1028,7 +1028,9 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
 	dev = &rte_eth_devices[port_id];
 
 	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);
-	(*dev->dev_ops->dev_infos_get)(dev, &dev_info);
+	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_configure, -ENOTSUP);
+
+	rte_eth_dev_info_get(port_id, &dev_info);
 
 	/* If number of queues specified by application for both Rx and Tx is
 	 * zero, use driver preferred values. This cannot be done individually
@@ -1059,9 +1061,6 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
 		return -EINVAL;
 	}
 
-	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);
-	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_configure, -ENOTSUP);
-
 	if (dev->data->dev_started) {
 		RTE_PMD_DEBUG_TRACE(
 		    "port %d must be stopped to allow configuration\n", port_id);
-- 
2.14.3

Re: [dpdk-dev] [PATCH] ethdev: fix corrupted device info in configure

[Thomas Monjalon]

10/05/2018 00:16, Ferruh Yigit:
> Calling dev_infos_get() devops directly in rte_eth_dev_configure cause
> random values in uninitialized fields because devops doesn't reset the
> dev_info structure.
> 
> Call rte_eth_dev_info_get() API instead which memset the struct.
> 
> Also remove duplicated dev_infos_get existence check.
> 
> Fixes: 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters")
> Cc: remy.horton@intel.com
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Re: [dpdk-dev] [PATCH] ethdev: fix corrupted device info in configure

[Ferruh Yigit]

On 5/9/2018 11:50 PM, Thomas Monjalon wrote:
> 10/05/2018 00:16, Ferruh Yigit:
>> Calling dev_infos_get() devops directly in rte_eth_dev_configure cause
>> random values in uninitialized fields because devops doesn't reset the
>> dev_info structure.
>>
>> Call rte_eth_dev_info_get() API instead which memset the struct.
>>
>> Also remove duplicated dev_infos_get existence check.
>>
>> Fixes: 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters")
>> Cc: remy.horton@intel.com
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied to dpdk-next-net/master, thanks.