From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id AC02F1C8E4; Thu, 5 Apr 2018 00:46:45 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4939422830; Wed, 4 Apr 2018 18:46:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 04 Apr 2018 18:46:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=nck9w0Or3s4fGWT8LDB9OIRtuX 0grol5e45MunEGkN4=; b=jNNYNbOzBmUXtUrPkSe2/yWlyVnG9tjId1BUyfFsn1 b+B0Oj6CWJTPn/EcTK0L/kgwON+U6WfX9xJT2BFSmt3VwQ73j6AMtRy1NJSFE7mF G9OoFL7MVO6nnZaufxMd2biPg/BN+p+FZsMY/gEIUdnb/2ItL+izUP6cOMoTzS6s E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=nck9w0 Or3s4fGWT8LDB9OIRtuX0grol5e45MunEGkN4=; b=T9uIZ5YJfr+FhAbuq+/HR9 mhQsPNmXq36fcU9zQdAIneXsM6LAWJSCtXOQxZqmbiiCy3hC1McpKjWsCfuc9b5i 6aeTX9lKkFdlehVGLKi76ryIFabkuYaFN+2LpdU7VyHG6Sfnmsg1PpDN3v2kKqvn oOu4T/LV+B0W0wC/4QFmGMLiwygcdCRqfluaXOzF3HM5c9dbwVvZe6Y1+gHZkbTt rI8N6wiUmrJXb4Y3vNwlma+0D8QaDe/rdL6dZW9S6jR6UQkd0lF3HH3wKW+EwXiJ X4eR9h2xZc5WEv3K43LNw5QKqaXjr5MaTH9lb8M5Jdjvc5SiPFfS+NYKiJyiVV3g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8097BE43BE; Wed, 4 Apr 2018 18:46:44 -0400 (EDT) From: Thomas Monjalon To: Gaetan Rivet Cc: dev@dpdk.org, Shreyansh Jain , stable@dpdk.org, Hemant Agrawal Date: Thu, 05 Apr 2018 00:46:43 +0200 Message-ID: <24575642.k2hPTVmtYA@xps> In-Reply-To: References: <20180322102844.8109-1-gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] bus/fslmc: fix find device start condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 22:46:46 -0000 23/03/2018 09:52, Shreyansh Jain: > On Thu, Mar 22, 2018 at 3:58 PM, Gaetan Rivet wrote: > > If start is set and a device before it matches the data, > > this device is returned. > > > > Fixes: c7fe1eea8a74 ("bus: simplify finding starting point") > > Cc: stable@dpdk.org > > > > Cc: Hemant Agrawal > > Cc: Shreyansh Jain > > Signed-off-by: Gaetan Rivet > > --- > > > > Hi Shreyansh, Hemant, > > > > Sorry, I did not test this. > > I found this issue while working on vdev and PCI. > > > > There is a better way to iterate on devices [1], but the gain > > is really minimal and the implementation slightly more complex. > > I preferred to avoid complex, as I could not test this patch. > > > > Regards, > > > > [1]: http://dpdk.org/ml/archives/dev/2018-March/092906.html > > > > I think this change should suffice here. Thanks. > > (On a side note, it seems compilation using clang is failing for this > patch [1] though it is not related to this change. I will look into > that) > > [1] http://dpdk.org/ml/archives/test-report/2018-March/044684.html > > Acked-by: Shreyansh Jain Applied, thanks