DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] bus/fslmc: fix find device start condition
@ 2018-03-22 10:28 Gaetan Rivet
  2018-03-23  8:52 ` Shreyansh Jain
  0 siblings, 1 reply; 3+ messages in thread
From: Gaetan Rivet @ 2018-03-22 10:28 UTC (permalink / raw)
  To: dev; +Cc: Gaetan Rivet, stable, Hemant Agrawal, Shreyansh Jain

If start is set and a device before it matches the data,
this device is returned.

Fixes: c7fe1eea8a74 ("bus: simplify finding starting point")
Cc: stable@dpdk.org

Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---

Hi Shreyansh, Hemant,

Sorry, I did not test this.
I found this issue while working on vdev and PCI.

There is a better way to iterate on devices [1], but the gain
is really minimal and the implementation slightly more complex.
I preferred to avoid complex, as I could not test this patch.

Regards,

[1]: http://dpdk.org/ml/archives/dev/2018-March/092906.html

 drivers/bus/fslmc/fslmc_bus.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index 5ee0beb85..010dd474e 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -301,8 +301,9 @@ rte_fslmc_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,
 	struct rte_dpaa2_device *dev;
 
 	TAILQ_FOREACH(dev, &rte_fslmc_bus.device_list, next) {
-		if (start && &dev->device == start) {
-			start = NULL;  /* starting point found */
+		if (start != NULL) {
+			if (&dev->device == start)
+				start = NULL;  /* starting point found */
 			continue;
 		}
 
-- 
2.11.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-04 22:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-22 10:28 [dpdk-dev] [PATCH v1] bus/fslmc: fix find device start condition Gaetan Rivet
2018-03-23  8:52 ` Shreyansh Jain
2018-04-04 22:46   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).