From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 9C701727F for ; Fri, 30 Mar 2018 17:57:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1CD9B20DFF; Fri, 30 Mar 2018 11:57:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 30 Mar 2018 11:57:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=HeTBp61b97VwpfwAizjyFYgyTW A2Tgwlupd17DWqgUc=; b=fx1+gOGLTuTzFY8q3P7yUfZr8LyPsHXUf4hLQcqR8N sggtEhobiVs+k6SE3e9pt4SwQqNwyXKzo/pN8r40Zgf/kvhVuw0Md2Y4dMOx4ZnH Z6EsYsiBdEXSrhb609zWy4anCNzXWbkWW3No43hc8lc8+vfddf4wT0Mn36Rc8tRb 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=HeTBp6 1b97VwpfwAizjyFYgyTWA2Tgwlupd17DWqgUc=; b=Roi2m5QqLiKY0DrF3Nhetr aQHKoIZ3Tck0+IGP0Zj2C85OfUAgvMQ/NoryXsmPHSTafvorpliMUy5qu2HnXxaG 6bBLNboarh/sxlSR70NXXF4n/rGvcw2XyyXTxlNrMcGLVTUSZtZfW2vRvAJ6pYTl cvotECeSIZGAIZKnGuhA9CYIndVAMjdS54k4ZalsjImN0X6NbwMF2bP4ATZyJ/3p OQ6VBoszpYjNGmuRCGSYF9T9GrTNj1Qf3QwYJ6bHDrovueYCrb3wHBdjO9lGxLeo DxHthm5cIXU0jbvFJD78S/W2VA1TfI4A+NrhgXYjsDZXq5LBQsU3qFvbpGFmxiQw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F275BE5084; Fri, 30 Mar 2018 11:57:52 -0400 (EDT) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org, John McNamara , Wenzhuo Lu , Jingjing Wu , Qi Zhang , Beilei Xing , Shreyansh Jain , ferruh.yigit@intel.com Date: Fri, 30 Mar 2018 17:57:16 +0200 Message-ID: <24577040.56AkOZZsW2@xps> In-Reply-To: <1867154.rqMg12d5dS@xps> References: <20180321142749.27520-1-remy.horton@intel.com> <20180321142749.27520-2-remy.horton@intel.com> <1867154.rqMg12d5dS@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 15:57:54 -0000 30/03/2018 17:40, Thomas Monjalon: > I know that this patch is already applied, > but I have some comments below. > Please try to address them. > > 21/03/2018 15:27, Remy Horton: > > + /* If number of queues specified by application for both Rx and Tx is > > + * zero, use driver preferred values. This cannot be done individually > > + * as it is valid for either Tx or Rx (but not both) to be zero. > > + * If driver does not provide any preferred valued, fall back on > > + * EAL defaults. > > + */ > > The fallback could be set in rte_eth_dev_info_get() and call this function > instead of calling directly dev_ops->dev_infos_get. > It would require to never return -ENOTSUP. > > At least, some default values should be set in rte_eth_dev_info_get(). I see it has been discussed in v1. And it was decided to not have ethdev defaults in rte_eth_dev_info_get. > > @@ -1029,6 +1048,10 @@ struct rte_eth_dev_info { > > /** Configured number of rx/tx queues */ > > uint16_t nb_rx_queues; /**< Number of RX queues. */ > > uint16_t nb_tx_queues; /**< Number of TX queues. */ > > + > > + /** Tx/Rx parameter recommendations */ > > + struct rte_eth_dev_portconf default_rxportconf; > > + struct rte_eth_dev_portconf default_txportconf; > > Some formatting comments: > Usually, there is no blank line in structs. > The doxygen comment must apply to each field. > Have you checked what is the doxygen output?