From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 3494C5A44 for <dev@dpdk.org>; Thu, 16 Feb 2017 11:44:35 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id v186so62979187wmd.0 for <dev@dpdk.org>; Thu, 16 Feb 2017 02:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=bnNohg7ZtYOWlzoXToSJZiiaUnyI9VaHgDBgZz9t9LQ=; b=Qv57wPgsNQlHfSycKbbwT3OymjNe3yBW6MP9bIdqeD1urrGamB35Rkm1oCG3nSHOe/ GeJW7aL47sjU5ElorsSNhPePVFX6AvDM+gEJIu1TVl03IcnJphq8slkd9B5rfRp71IQr dx1X7pqxqHYfG/IC1+8lq+DqR8asdMqWIOOnkJBpqW6Ok3AXveMtEsSciDJvBYftK4BO Tzldn9NGffd/MDMSLlV4N7kWVCovbepkUCY8AC7G3WGPvT5X+uYznBQZ0gITFYAYrAVY fxL/rWOXSX0915moxmokFL8t4HXAoPQIiXSiWfuIRa6QybfzhsRgn57EqjbZ7UYAGPzw 5NPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=bnNohg7ZtYOWlzoXToSJZiiaUnyI9VaHgDBgZz9t9LQ=; b=GDinW7bRXX/mLN703NOQMtnqOJRl7DgZk4p5RO+OJvT0lphRWMQtjXqzOlS+vvu1j8 LOFmOXSWSmqpMw8roW03Bx/wBe9e7XPB4sBVwfZZZUla6sb5zieWSKd4MK/Tae/p/MCc gIPKhL7KcMy2mcpaNWnlAdXAh+wP6G8rnAmyJ/LgZMW7QLAoMEdf4qXyjoN/KS+tHCrU /cO8ViDgxvMNi8EGklopVwlyOAb6Kp0zQUkJZf/hP6KLbh5TQ438/0t2UTPZ2i078oga 30mngwwvbKB9LTvbQIXvYXjgL88gLPwX4WArtqYfIl/5fTOp7I0zEXE/N6zfrpeujYrg 3hmg== X-Gm-Message-State: AMke39lPvcR4tXsof3mVMK9pnYGYbMbd8OqJEEVJ9dMkoruGcVZglhfq7/p4GJ61NztOGgyl X-Received: by 10.28.222.11 with SMTP id v11mr11424072wmg.1.1487241874834; Thu, 16 Feb 2017 02:44:34 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id k4sm2984608wmf.22.2017.02.16.02.44.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 02:44:34 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, John McNamara <john.mcnamara@intel.com>, Keith Wiles <keith.wiles@intel.com> Date: Thu, 16 Feb 2017 11:44:33 +0100 Message-ID: <2458783.cUhEIUrdmi@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <e96fc4e1-6a93-2d52-d3bd-87c02609af93@intel.com> References: <20170214151326.7554-1-ferruh.yigit@intel.com> <371817936.VaZMuq7BCX@xps13> <e96fc4e1-6a93-2d52-d3bd-87c02609af93@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/4] mk: add new test-run make rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 16 Feb 2017 10:44:35 -0000 2017-02-16 10:21, Ferruh Yigit: > On 2/16/2017 9:26 AM, Thomas Monjalon wrote: > > 2017-02-15 15:26, Ferruh Yigit: > >> --- a/mk/rte.sdkroot.mk > >> +++ b/mk/rte.sdkroot.mk > >> @@ -92,8 +92,8 @@ default: all > >> config showconfigs showversion showversionum: > >> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@ > >> > >> -.PHONY: test fast_test ring_test mempool_test perf_test coverage > >> -test fast_test ring_test mempool_test perf_test coverage: > >> +.PHONY: test test-run fast_test ring_test mempool_test perf_test coverage > >> +test test-run fast_test ring_test mempool_test perf_test coverage: > >> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@ > > > > "test" is a shortcut for build + basic tests. > > I think test-run can be better named. It runs all the basic tests registered > > in autotests. "test-all" would be wrong. What about "test-basic"? > > Right, "test-basic" matches more to existing rules (test-fast, > test-perf, ..), all has hidden "run" action implied, I will use > "test-basic" if there is no objection. > > My concerns is "test-basic" "running basic tests without compilation" > may not be obvious for a newcomer. > Should I add a line to "make help" for "test" and "test-*" rules? > > Like: > test Compile tests and run basic unit tests > test-* Run specific subset of the unit tests Yes it looks good.