From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 14DF944C7 for ; Thu, 15 Mar 2018 16:47:39 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 901AA20B71; Thu, 15 Mar 2018 11:47:35 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 15 Mar 2018 11:47:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=lC2cX+d/kV8HyPVYxMf9Y5FGr3 ISW8AOdtNDuTsyVXs=; b=JegaZWCG2Fcpq71tH94o0EmdRdejappXiTL7tG8uEa 2nX5l1Gq8AnVOawg28yxRfFAIEyqQS+S9R77kZ5Z3w1Ly2zUzAk3dBVqp8FBWxzP AdSVBJZqm57Hbz1097yWKpiCcPSFV5ZDJvzZ5ZOQRkWqsKfAj0Cvx3ctZii4MTFw Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=lC2cX+ d/kV8HyPVYxMf9Y5FGr3ISW8AOdtNDuTsyVXs=; b=bEcFC+bj0wiOqrdmYR0/4V p35nU3pQ+tZI/TTGEjiwZXNTXsn3p1dgb5Urup/e3LmuxyLkr1qwO5JZNGDQ/fCM oqat8CmhFTP9zy8SDvosG65aoGK8c9H06ElbUO7BdfebE/D6nRLvx6ksi3E5S5wc nGYrJ38OsfNmaDn19xnTNtL/KUwZXGBjqdDM11yMsNciSYjjq62gdGUKjKHOf60+ X8DQ45pIAEmsx5KMabpekLBxG6FQkqQW8/n5BmE8WXorMzeHW3jKDcIkL56Y7GkL T0uZv8LM6qlE9KmP84UZIiyJpgSGvEWrxWl03TcNQtQ8T261nygZhnYWGlr7FjXg == X-ME-Sender: Received: from xps.localnet (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id EF3A27E0F0; Thu, 15 Mar 2018 11:47:33 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger , =?ISO-8859-1?Q?N=E9lio?= Laranjeiro Cc: dev@dpdk.org, Pascal Mazon Date: Thu, 15 Mar 2018 16:39:46 +0100 Message-ID: <2460477.86ImKqUlBA@xps> In-Reply-To: <20180314081736.6b06dd2f@xeon-e3> References: <20180314120855.avapkwbwx6hecwmw@laranjeiro-vm.dev.6wind.com> <20180314081736.6b06dd2f@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 15:47:39 -0000 14/03/2018 16:17, Stephen Hemminger: > On Wed, 14 Mar 2018 13:08:55 +0100 > N=E9lio Laranjeiro wrote: > > On Tue, Mar 13, 2018 at 02:20:31PM -0700, Stephen Hemminger wrote: > > > On Tue, 13 Mar 2018 13:28:25 +0100 > > > Nelio Laranjeiro wrote: > > > > drivers/net/tap/Makefile | 3 +- > > > > drivers/net/tap/rte_eth_tap.c | 16 +-- > > > > drivers/net/tap/tap_flow.c | 118 +++++++++= +----------- > > > > drivers/net/tap/tap_netlink.h | 42 -------- > > > > drivers/net/tap/tap_tcmsgs.c | 28 ++--- > > > > drivers/net/tap/tap_tcmsgs.h | 2 +- > > > > lib/Makefile | 2 + > > > > lib/librte_netlink/Makefile | 26 +++++ > > > > lib/librte_netlink/meson.build | 13 +++ > > > > .../librte_netlink/rte_netlink.c | 87 +++++++++= ++---- > > > > lib/librte_netlink/rte_netlink.h | 43 ++++++++ > > > > lib/librte_netlink/rte_netlink_version.map | 18 ++++ > > >=20 > > > I might have raised this before; but having yet another netlink libra= ry is > > > not a great advantage. It would be much better to use a common extern= al library > > > libmnl which is already available on every distribution. =20 > >=20 > > The question is more do we really want to have a dependency on a so > > small wrapper for a socket interface? >=20 > Lots of drivers already have dependencies. > And I trust libmnl rather than a reinvented library. Are we sure it is commonly installed in distributions? This is needed only for TAP and mlx drivers. Do we really want to add this dependency as mandatory for everybody to compile DPDK with default PMDs? I see 4 options: 1/ keep duplicated few functions in PMDs 2/ use libmnl 3/ add the functions in a DPDK lib (this patch) 4/ add the functions in EAL I would vote for the first option because mlx5 has very minimal requirement regarding netlink. The first option can give us some time to think about the right way to use netlink in the next releases.