* [PATCH] build: detect backtrace availability
@ 2023-01-08 9:59 Thomas Monjalon
2023-01-09 9:08 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2023-01-08 9:59 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, David Marchand
Backtrace dump is available:
- always on Windows
- on Linux/BSD if execinfo.h is available (not anymore on Alpine)
The flag RTE_BACKTRACE was set unconditionnaly in rte_config.h.
It is now set only if the feature is available.
Note: Alpine Linux has decided to remove libexecinfo support,
so this change will allow to compile DPDK on recent Alpine Linux.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
config/meson.build | 3 ++-
config/rte_config.h | 1 -
doc/guides/linux_gsg/sys_reqs.rst | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/config/meson.build b/config/meson.build
index 80564eec52..0c4d1f06e5 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -200,10 +200,11 @@ if fdt_dep.found() and cc.has_header('fdt.h')
endif
libexecinfo = cc.find_library('libexecinfo', required: false)
-if libexecinfo.found() and cc.has_header('execinfo.h')
+if libexecinfo.found()
add_project_link_arguments('-lexecinfo', language: 'c')
dpdk_extra_ldflags += '-lexecinfo'
endif
+dpdk_conf.set('RTE_BACKTRACE', cc.has_header('execinfo.h') or is_windows)
libarchive = dependency('libarchive', required: false, method: 'pkg-config')
if libarchive.found()
diff --git a/config/rte_config.h b/config/rte_config.h
index 3c4876d434..7b8c85e948 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -37,7 +37,6 @@
#define RTE_MAX_MEMZONE 2560
#define RTE_MAX_TAILQ 32
#define RTE_LOG_DP_LEVEL RTE_LOG_INFO
-#define RTE_BACKTRACE 1
#define RTE_MAX_VFIO_CONTAINERS 64
/* bsd module defines */
diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst
index e4f9b41251..2a7988cf46 100644
--- a/doc/guides/linux_gsg/sys_reqs.rst
+++ b/doc/guides/linux_gsg/sys_reqs.rst
@@ -32,7 +32,7 @@ Compilation of the DPDK
* For RHEL/Fedora systems these can be installed using ``dnf groupinstall "Development Tools"``
* For Ubuntu/Debian systems these can be installed using ``apt install build-essential``
- * For Alpine Linux, ``apk add alpine-sdk bsd-compat-headers libexecinfo-dev``
+ * For Alpine Linux, ``apk add alpine-sdk bsd-compat-headers``
.. note::
--
2.39.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] build: detect backtrace availability
2023-01-08 9:59 [PATCH] build: detect backtrace availability Thomas Monjalon
@ 2023-01-09 9:08 ` Bruce Richardson
2023-02-02 21:54 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2023-01-09 9:08 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, David Marchand
On Sun, Jan 08, 2023 at 10:59:20AM +0100, Thomas Monjalon wrote:
> Backtrace dump is available:
> - always on Windows
> - on Linux/BSD if execinfo.h is available (not anymore on Alpine)
>
> The flag RTE_BACKTRACE was set unconditionnaly in rte_config.h.
> It is now set only if the feature is available.
>
> Note: Alpine Linux has decided to remove libexecinfo support,
> so this change will allow to compile DPDK on recent Alpine Linux.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] build: detect backtrace availability
2023-01-09 9:08 ` Bruce Richardson
@ 2023-02-02 21:54 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2023-02-02 21:54 UTC (permalink / raw)
To: dev; +Cc: David Marchand, Bruce Richardson
09/01/2023 10:08, Bruce Richardson:
> On Sun, Jan 08, 2023 at 10:59:20AM +0100, Thomas Monjalon wrote:
> > Backtrace dump is available:
> > - always on Windows
> > - on Linux/BSD if execinfo.h is available (not anymore on Alpine)
> >
> > The flag RTE_BACKTRACE was set unconditionnaly in rte_config.h.
> > It is now set only if the feature is available.
> >
> > Note: Alpine Linux has decided to remove libexecinfo support,
> > so this change will allow to compile DPDK on recent Alpine Linux.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-02 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-08 9:59 [PATCH] build: detect backtrace availability Thomas Monjalon
2023-01-09 9:08 ` Bruce Richardson
2023-02-02 21:54 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).