From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF47745681; Mon, 22 Jul 2024 15:04:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B363B402AC; Mon, 22 Jul 2024 15:04:55 +0200 (CEST) Received: from fhigh5-smtp.messagingengine.com (fhigh5-smtp.messagingengine.com [103.168.172.156]) by mails.dpdk.org (Postfix) with ESMTP id 23B3C402DD for ; Mon, 22 Jul 2024 15:04:44 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id B27CA1140203; Mon, 22 Jul 2024 09:04:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 22 Jul 2024 09:04:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1721653482; x=1721739882; bh=6Nk+LgRZ7UNUxm1wkP8ZPbnDpigIvaGcL1cyMDKM64U=; b= mr5E+CYAFblrxh5VLTl8zHuQ4Vhkog9sx3ltNu2+A8gr6Tvkr22X6DXXb1J65GLX R9SrUKFr7X0cN86co50JZ7EbkZKZ/IGJBM7Z3ePUKFDk7iu+PIz64qfQOIlp4cm3 iimK/2b/xYkuM8SdFIdxuVQ4gPav8A0iIaMen//XT5rh0mqX9PtH05hlVvV53AMt LlSSyV6L7YVL3cKZ/XMgK6A5FMFKIIGHqw8x+p1PoJ8Ccz1gWNb3tnY406P04ejo xGsribOnyvVBseaf2ouv+YbSWrOoNdI584j3VA3rCzJtbI5kqOj+ONfx70GLLLOY /5I7akpvL5jU+l+pQA+ZEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1721653482; x= 1721739882; bh=6Nk+LgRZ7UNUxm1wkP8ZPbnDpigIvaGcL1cyMDKM64U=; b=M jHxrTaAmUtvMW8VgPZTlfA+fsVPLUz/tWeV7GWLRUu4JU033t4446GX96O/A4nEA 09p4wA2kOHiI+9OJd/NpI/nq+clFrbnUj054TZNQk/nuX99upTcVxV+nddQrw/E3 84CUCv3RL8NA+5WP0/iI/OISrlpar8xBrVrjoe9/1cd116cnO+MkwHwxxOy6KlY2 FdufE2xDRpKceUbHMldVTP4k/rjHY62MO0jZeWA13CGl0xhRg6da8yi9ZXXLlUH5 an//uD+YhdBWpVlwYgQ8S031caNgVji/h0t2ghsOuDFe6x8s+7C6hqpip9UlWjwS E09ZQjDk7bjOtx/Jqh8KQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrheejgdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefg vdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Jul 2024 09:04:39 -0400 (EDT) From: Thomas Monjalon To: "Minggang(Gavin) Li" , Ferruh Yigit Cc: Matan Azrad , Slava Ovsiienko , Ori Kam , Aman Singh , dev@dpdk.org, Raslan Darawsheh Subject: Re: [V1] app/testpmd: restore VXLAN-GPE support Date: Mon, 22 Jul 2024 15:04:36 +0200 Message-ID: <2469214.jE0xQCEvom@thomas> In-Reply-To: References: <20240717071130.1548425-1-gavinl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 22/07/2024 11:36, Ferruh Yigit: > On 7/22/2024 8:10 AM, Minggang(Gavin) Li wrote: > > From: Ferruh Yigit > >> On 7/17/2024 8:11 AM, Gavin Li wrote: > >>> VXLAN-GPE support was removed from testpmd recently. Drivers which are > >>> not migrated are still using VXLAN-GPE in tests. > >>> > >>> This commit is to restore the support for VXLAN-GPE in testpmd. > >>> > >>> Fixes: da118115d95c ("app/testpmd: support matching any VXLAN field") > >>> Signed-off-by: Gavin Li > >>> > >> > >> Hi Gavin, > >> > >> The original patch was from you, right? What went wrong? > > The remove of VXLAN-GPE from testpmd is too aggressive since there are > > drivers which are not migrated are still using VXLAN-GPE. It's better to > > keep it till the day to remove the RTE item of VXLAN-GPE from DPDK. > > > > Sorry, I was not clear enough maybe, I was asking more details on the > problem? I remember I was suggesting Gavin to remove testpmd code based on the old API. And he realized it was too much agressive later. > With a net/vxlan commit [1] in this release, (this commit is part of > -rc1), VXLAN & VXLAN-GPE headers combined and VXLAN-GBP header added to > this combined struct. VXLAN-GPE header is marked as deprecated. > Testpmd is also updated to use new headers, that is the commit in the > fixes tag of this patch. > > But drivers using old, now depreciated, VXLAN structs won't able to use > testpmd to test, so I agree, may be I merged the patch too early. Yes, so this patch re-add testpmd code for the old API. > As this patch was part of -rc1, I wonder why we didn't get any complaint > about not able to test VXLAN-GPE? Maybe it is tested only with mlx5. > Btw, if we revert this patch, is there a way to test VXLAN-GBP? Because > it only exists as part of new combined VXLAN struct? > Instead of reverting the commit all together, is there way to keep old > capability in testpmd, but add feature to test VXLAN-GBP? It is not a complete revert, we keep GBP in the new API. > And another issue is, there can still some users of the VXLAN-GPE header > in the net library, perhaps that also deprecated immaturely. It is just marked as deprecated. > Can you please send a deprecation note for combining VXLAN headers and > removing VXLAN-GPE in v24.11? Please CC all drivers implementing this > flow pattern. This can be way to highlight the issue to driver > maintainers and communicate the change with end users. 24.11 is probably too early. I propose to keep it as deprecated for compatibility, and maybe remove in one year?