From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58298A00E6 for ; Thu, 11 Jul 2019 16:41:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C0D61B464; Thu, 11 Jul 2019 16:41:05 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 293A24C8E for ; Thu, 11 Jul 2019 16:41:04 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 5944B323D; Thu, 11 Jul 2019 10:41:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 11 Jul 2019 10:41:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=6GWawaAFHLtwG10lLOcrEFSkywfpv3LUoIMJYNyBWTo=; b=WHy5dVmBu6u9 rwJvgVeYB3mycu2uRrRBdMqtQ/uRyuZ/v8iUVlBjaATqu5+THXtPmEF19KYTHs35 TO6UuaDwJjAaklG/DCbHLcIKnUjNovXvRfK+iiv2IxHZkeVQuTaqiqFim99mNwcA r3+eujrPqm1h+93njaCsa5nvlUK7yeA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=6GWawaAFHLtwG10lLOcrEFSkywfpv3LUoIMJYNyBW To=; b=dpVOHIiMw07bykDxsV3GSnEAehwWP0JT42NJW9AleankIDYCd1IHvZ6o3 R3McYcf3fmqy0gLtoQm0+QBrsZ3jgxX5rCJSc0LISa+qjw9rhErbHqZ4yiu4Lqis jKcAp8D66cMz6OTgTh8w7V4P++Tu0bL3PntCnw6Lf02tyww/c53ci9Ox58H9LkTz bHFQ0eC+L3hDJb7A0B3gaj4VFtvb6RnDs4zKoqaCSwhw4eJnrQECH9cfErJ9Ef6Z 8QQGoiTQRWHs8WU3gPVHjkpdeUjIU6xV3FhFx7Njd0bR3PEhQfgpLV0rWSqY6cXR y5YwnemVoi5JuCujsnpPz5mW4Afhw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgeekgdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9D6108005C; Thu, 11 Jul 2019 10:40:59 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: David Marchand , anatoly.burakov@intel.com, jerinj@marvell.com, John McNamara , Marko Kovacevic , Igor Russkikh , Pavel Belous , Ajit Khaparde , Somnath Kotur , Wenzhuo Lu , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Matan Azrad , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Alejandro Lucero , Nithin Dabilpuram , Kiran Kumar K , Rasesh Mody , Shahed Shaikh , Bruce Richardson Date: Thu, 11 Jul 2019 16:40:58 +0200 Message-ID: <2472231.6TaqnvWiti@xps> In-Reply-To: <1562795329-16652-3-git-send-email-david.marchand@redhat.com> References: <1562795329-16652-1-git-send-email-david.marchand@redhat.com> <1562795329-16652-3-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix IOVA mode selection as VA for pci drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" I was expecting some replies / reviews of this patch today. 10/07/2019 23:48, David Marchand: > The incriminated commit broke the use of RTE_PCI_DRV_IOVA_AS_VA which > was intended to mean "driver only supports VA" but had been understood > as "driver supports both PA and VA" by most net drivers and used to let > dpdk processes to run as non root (which do not have access to physical > addresses on recent kernels). > > The check on physical addresses actually closed the gap for those > drivers. We don't need to mark them with RTE_PCI_DRV_IOVA_AS_VA and this > flag can retain its intended meaning. > Document explicitly its meaning. > > We can check that a driver requirement wrt to IOVA mode is fulfilled > before trying to probe a device. > > Finally, document the heuristic used to select the IOVA mode and hope > that we won't break it again. > > Fixes: 703458e19c16 ("bus/pci: consider only usable devices for IOVA mode") > > Signed-off-by: David Marchand