* [PATCH v1] app/mldev: fix error reporting on IO failure
@ 2023-06-12 18:00 Srikanth Yalavarthi
2023-07-07 8:18 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Srikanth Yalavarthi @ 2023-06-12 18:00 UTC (permalink / raw)
To: Srikanth Yalavarthi, Anup Prabhu; +Cc: dev, sshankarnara, ptakkar
Application is reporting the test output as success when a
failure occurs in writing the output. Fix incorrect error
reporting on failure to write output files.
Fixes: da6793390596 ("app/mldev: support inference validation")
Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
app/test-mldev/test_inference_common.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/app/test-mldev/test_inference_common.c b/app/test-mldev/test_inference_common.c
index 7c62726761..418bf38be4 100644
--- a/app/test-mldev/test_inference_common.c
+++ b/app/test-mldev/test_inference_common.c
@@ -867,9 +867,6 @@ ml_inference_validation(struct ml_test *test, struct ml_request *req)
goto next_output;
}
done:
- if (match)
- t->nb_valid++;
-
return match;
}
@@ -892,10 +889,8 @@ ml_request_finish(struct rte_mempool *mp, void *opaque, void *obj, unsigned int
rte_ml_io_dequantize(t->cmn.opt->dev_id, model->id, t->model[req->fid].nb_batches,
req->output, model->output);
- if (model->reference == NULL) {
- t->nb_valid++;
+ if (model->reference == NULL)
goto dump_output_pass;
- }
if (!ml_inference_validation(opaque, req))
goto dump_output_fail;
@@ -920,6 +915,7 @@ ml_request_finish(struct rte_mempool *mp, void *opaque, void *obj, unsigned int
if (error)
return;
}
+ t->nb_valid++;
return;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] app/mldev: fix error reporting on IO failure
2023-06-12 18:00 [PATCH v1] app/mldev: fix error reporting on IO failure Srikanth Yalavarthi
@ 2023-07-07 8:18 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2023-07-07 8:18 UTC (permalink / raw)
To: Srikanth Yalavarthi; +Cc: Anup Prabhu, dev, sshankarnara, ptakkar
12/06/2023 20:00, Srikanth Yalavarthi:
> Application is reporting the test output as success when a
> failure occurs in writing the output. Fix incorrect error
> reporting on failure to write output files.
>
> Fixes: da6793390596 ("app/mldev: support inference validation")
>
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-07 8:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-12 18:00 [PATCH v1] app/mldev: fix error reporting on IO failure Srikanth Yalavarthi
2023-07-07 8:18 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).