From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 1E5FE9ACF for ; Tue, 1 Mar 2016 14:33:09 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id l68so33555499wml.1 for ; Tue, 01 Mar 2016 05:33:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZwmSv0yRqhpmMtDl25csMfDFIMZsi5G31PlCzJn9zB4=; b=iCU7JFtec84zWMGehLVcbPg/6sjDRDJmHLjy/ia8NHCkpkmjaRzc7q0aaI89LCruUH VCzJ3k+njG8AsJTk6FEvlmdg8Uw2ztoqOiBxAEd5o71fGgT6bJOZHMo3BobHi8FDAhgZ e8+4YytFe9FKx0VdUwNWw7G+LStAZ48qkxmWkDKr8Pv/rGCV8B9AIWTDd4E++Aes9Pd8 K1JEwZSUNRUHyNbhYPCHEo+z+Q+xMrE1Hh1jRLI8+xYhMbamkihj1n5TSe9f/QWMoU1J zNCyfgSzu3Y3zIwxVTLOdAvJPuBecxdsNcY/4iCsntxGRyY++2kIJ9t9X1CvhftzyMG4 Bo1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=ZwmSv0yRqhpmMtDl25csMfDFIMZsi5G31PlCzJn9zB4=; b=lQDPkcBrXPfHdbpH9WiiRu7tzkWYJFca9eOs4qclYGbm3v/kZTUGWmloAjz5HFgjmk XyPAC2/BKSxmvlT5+FfOmWcqw335JPCF48F4jSQiStEBzX0RH/p50q6M+E++C4DO+VEJ cjnOJ/CNv1kAen4oLSD863dbLm+GRScPC+TQYmDqQ7vPoNGhaxm9HhPCzvLsP4wwxfDW MIF+s72qnfwkMZqZYHqa2Z9hvy3MYTZdMzLRss9awqNswez/CTFHAOI8j6bG+g+7Zg6+ ejfpduUto67UynDE1UQttKl4ScrWebUslB20XtYXGcOx40pRCUAocTdhSGmpCIMsmb98 S9Hg== X-Gm-Message-State: AD7BkJKgCHxeffjVhOFVIrFgehhdCJcl26sYGFafRhvkZvAmDNlbSADPFF6Bf7qDTfkePuVp X-Received: by 10.194.94.106 with SMTP id db10mr19964655wjb.175.1456839189005; Tue, 01 Mar 2016 05:33:09 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id t7sm1340814wjf.39.2016.03.01.05.33.07 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 01 Mar 2016 05:33:08 -0800 (PST) From: Thomas Monjalon To: Didier Pallard Date: Tue, 01 Mar 2016 14:31:33 +0100 Message-ID: <2476239.BEsYoxOLBe@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1455010467-4991-1-git-send-email-didier.pallard@6wind.com> <1455879631-18420-1-git-send-email-didier.pallard@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 0/2] Fix CRC32c computation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 13:33:09 -0000 > > CRC32c computation is not valid when buffer length is not a multiple of 4 > > bytes. > > Values returned by rte_hash_crc functions does not match the one > > computed by a trivial crc32c implementation. > > > > First patch fixes crc hash function autotests, to outline the problem. > > Second patch fixes CRC32c computation. > > > > Didier Pallard (2): > > test: fix CRC hash function autotest > > hash: fix CRC32c computation > > Series-acked-by: Pablo de Lara > > Not sure if you need to include a "Fixes" line in the commit messages. > In the first commit, probably you should, the commit that you are fixing is > 6298d2c55ae8 ("app/test: add new functional tests for hash functions"). Thanks > In the second commit, it is a bit more difficult, as we don't know that the commit is, > that code was integrated a while ago, before 1.2.3, which is the first public release in dpdk.org. Yes it helps to know the bug was there since the beginning. > Also, there is a typo "lengthes", in both commit messages. > > You can leave the ack in both patches. Thanks!! Applied, thanks