From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id D5165FA57 for ; Mon, 27 Mar 2017 11:52:59 +0200 (CEST) Received: by mail-wr0-f178.google.com with SMTP id l43so47933374wre.1 for ; Mon, 27 Mar 2017 02:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=PNU8bifNnf3NF5PeLtXZi1yDNT2fsW4WSXtaIzN1h+k=; b=AczZNn0dw5XHPnoLcx5Rg1JeMm0XBONG2xXiVSreUh2yh0p0rAATd3mMzArb8ixQex cu+llnApM4ySAo5LTu1mjStZzVqeOpa2KnD5bLZbQqwfh1cXWS5avIUl+L1xfSsTwLij dSloX1QFJzna5PjDnKbHMqdwponXi38rdoIWQuTJJn4VK2o4ZrMplmnX9ApSAavPOshI QhoSnHHWhMCUCijIV3UotcvkVTe1FJ40y/9EpL4wDTEGWEk2bAPKIt3110FrUnUUvGZ7 AAnGrDnC/xU1GheATWEzmEbicFEl+irrgAceiW/E12UuNJhde6Eql659qKe8oFqjp5iD qhdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=PNU8bifNnf3NF5PeLtXZi1yDNT2fsW4WSXtaIzN1h+k=; b=ZeRB+6ZbrVkWIKHKPC5kgst0iUVTcZdSCUiWsQqehnkUaFpKavbJXurk/pZPioSPdU hRjHTB26iCOFh1pt7ejcJ1H+Pof+lgtjka1+2iZDHVrRz6C8IAkix6FobFri2lbdErom tnBc86618fECjfpIDONQjNTYfYyircmJHC47HjgIRPB5iZBbMHuymqhxPqqGdNhMZjYD dC8dX3GdbPXXhKMfRJ5vuqUrpMnHuDQrK0AhDNRdpcMkqbhtfERESk/eVNyK9oI73BLq jt3bh7/GNFQmFu/cACaE+c2qn/rBai7eRn/8VTRe8zyahhDTUHuYRbAv6BNdteysyXlH utBQ== X-Gm-Message-State: AFeK/H0EuSuWsJZ5xbapa9ib+ZvKolCvInuvTlLnRUQ83TKvnzWFPH92mKZ8K8TuVFenih9O X-Received: by 10.28.203.197 with SMTP id b188mr9292957wmg.110.1490608379547; Mon, 27 Mar 2017 02:52:59 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id q29sm116721wrc.49.2017.03.27.02.52.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Mar 2017 02:52:58 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Cc: olivier.matz@6wind.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com Date: Mon, 27 Mar 2017 11:52:58 +0200 Message-ID: <2476675.J1ds0gYDs0@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170324171008.29355-4-bruce.richardson@intel.com> References: <20170307113217.11077-1-bruce.richardson@intel.com> <20170324171008.29355-1-bruce.richardson@intel.com> <20170324171008.29355-4-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 03/14] ring: eliminate duplication of size and mask fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 09:53:00 -0000 2017-03-24 17:09, Bruce Richardson: > The size and mask fields are duplicated in both the producer and > consumer data structures. Move them out of that into the top level > structure so they are not duplicated. > > Signed-off-by: Bruce Richardson > Acked-by: Olivier Matz Sorry Bruce, I encounter this error: fatal error: no member named 'size' in 'struct rte_ring_headtail' if (r->prod.size >= ring_size) { ~~~~~~~ ^