From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9DB35A49C for ; Sat, 20 Jan 2018 15:37:00 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 469C020CF4; Sat, 20 Jan 2018 09:37:00 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sat, 20 Jan 2018 09:37:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=cSgkbw/rfQPhz+sTk3RRF5aXG2 /oLDfOBqAuBeCmJTQ=; b=M8rvh3a+gUR5luK+F71p628Y7n4DKaS++uEDDgoaaA PkX1RWWugjv4DCBbV/q67CjFk0mm5/tYkCSYMWDSfdgXN1tBpznYfSrtT4RDWPha pXR14vpgfo0Ax0ZRW73DDMGCu14kxoslxbb+YluH7DFJT0IXalci/tkxvaivjiD2 Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=cSgkbw /rfQPhz+sTk3RRF5aXG2/oLDfOBqAuBeCmJTQ=; b=CJ94WKzFu2EQlE1oxS9bO3 jAf4YHsRRWfMDgTWVVX1swo8C0OL678ixrMyGw1qpCESvPKXKMwX/vnUAdBkgiIi aLm4SvTJBZhWtyJQWkp/gHc6oBFexIcSilOTEa/pl7jFytTf56RBGNL10a+wJUlw vQbvjPEt6qWiTWZpJGHJbrzRXzp+OTvtV9x8bxTxWphP5XxSTo2lpF+REkUcW8Dw IKFIn1qJ2T6l2tFtRdl3mu7UdAf5evbZR6T8rvWPRz9hXyJW21bZPWJX8ym2rA5G GC6JSdZrpGzvJ+XFpKT60IvIE722tUhbW4KSu4NKdIBZNKEXTqhYAvnw4vj27rYw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EFE6E7E2E6; Sat, 20 Jan 2018 09:36:59 -0500 (EST) From: Thomas Monjalon To: Elza Mathew Cc: dev@dpdk.org, Bruce Richardson , pablo.de.lara.guarch@intel.com Date: Sat, 20 Jan 2018 15:36:24 +0100 Message-ID: <2479496.07huUYr6Q1@xps> In-Reply-To: <20171211132612.GA9292@bricha3-MOBL3.ger.corp.intel.com> References: <1509991489-26442-1-git-send-email-elza.mathew@intel.com> <20171211132612.GA9292@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/3] hash: run-time function selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jan 2018 14:37:00 -0000 11/12/2017 14:26, Bruce Richardson: > On Mon, Nov 06, 2017 at 10:04:49AM -0800, Elza Mathew wrote: > > Compile-time function selection can potentially lead to > > lower performance on generic builds done by distros. > > Replaced compile time flag checks with run-time function > > selection. > > > > Signed-off-by: Elza Mathew > > --- > > lib/librte_hash/rte_fbk_hash.c | 11 ++++++++++- > > lib/librte_hash/rte_fbk_hash.h | 8 -------- > > 2 files changed, 10 insertions(+), 9 deletions(-) > > > Title needs an update to indicate this change is for fbk-hash. I suspect > that can be fixed on apply. > > Acked-by: Bruce Richardson Applied, thanks