From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39F10A0A0A; Thu, 3 Jun 2021 10:53:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA32540E78; Thu, 3 Jun 2021 10:53:10 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 5577440DF6 for ; Thu, 3 Jun 2021 10:53:09 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F1F635C0069; Thu, 3 Jun 2021 04:53:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 03 Jun 2021 04:53:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 6+lXclCajxRtt+fasGlvTl1XrQAK2/lRE5/cJvi5gpM=; b=FZq9J/ydGINJ6Vj7 /7QP67SN4F+sPgmx4hQjd4w+qxsWDqNMdu4dJLXn4ekAPbQg8TDvhKh4M7dQKRpE lyWZji4cO1Wi53iagEY7CRMKKd+MdiSyEYkBeaukE91Rf4zrNwXAzL7X7TmRxGv2 gVz1NRBN4J5lVup75WuVCeJCsSTFBiljwOIpvQ5IpGfjr1n0x8YdOaqphDgDlsy+ yUiBXmNNki4xmr+12GFsMN+iM3jdnCCiNOQCD9eg5Cv0lVPZXMWsRMc2VLzSmfXf p1NWuEuy/ADZ+4g/YkncObPJxrUMUwdAf1SvyYw11PIo1Gh9VLmU19WeATgDIctA Wr5KSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=6+lXclCajxRtt+fasGlvTl1XrQAK2/lRE5/cJvi5g pM=; b=kM7vvuKpbqUPP9KHDQgiQTABVGYkMzcKPxKTphVwmXYKKRhCsTIljT3I+ mo0y5Ce6tz4BJ2LjP9zzq1tCfNL/eyF/q9YFlqSGunDxNsFr68omEexwfu+/7n/S osM+9wvLL6/QzDQHcv13FOPdm5/JPr97Du/aOy4GfTxpyKt7NDJmvuQAgBJ2Sw90 FG0DTFK9D1A1aXGPyv+Y0RNGRnXLMMi0WjzICyYpDJwV5hImpH83f/8Fvz/FdGZb ikiQ//YrN0nfkTkVyhPhMw6ehDQvReGZ59L5L4nNypyqhLX4dj+HbVR1T6j0V5q3 ts9bp2liwAsAmTBqdDJPJjYuuBDiA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdelledgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 3 Jun 2021 04:53:08 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dpdk-dev , Elena Agostini Date: Thu, 03 Jun 2021 10:53:06 +0200 Message-ID: <2479672.ZMpKsOhbnr@thomas> In-Reply-To: References: <20210602203531.2288645-1-thomas@monjalon.net> <3058202.9UA1LLGnyJ@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] gpudev: introduce memory API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/06/2021 10:47, Jerin Jacob: > On Thu, Jun 3, 2021 at 2:13 PM Thomas Monjalon wrote: > > > > 03/06/2021 10:41, Jerin Jacob: > > > On Thu, Jun 3, 2021 at 1:58 PM Thomas Monjalon wrote: > > > > > > > > 03/06/2021 09:47, Jerin Jacob: > > > > > On Thu, Jun 3, 2021 at 2:05 AM Thomas Monjalon wrote: > > > > > > --- a/doc/api/doxy-api-index.md > > > > > > +++ b/doc/api/doxy-api-index.md > > > > > > @@ -21,6 +21,7 @@ The public API headers are grouped by topics: > > > > > > [compressdev] (@ref rte_compressdev.h), > > > > > > [compress] (@ref rte_comp.h), > > > > > > [regexdev] (@ref rte_regexdev.h), > > > > > > + [gpudev] (@ref rte_gpudev.h), > > > > > > > > > > Since this device does not have a queue etc? Shouldn't make it a > > > > > library like mempool with vendor-defined ops? > > > > > Any specific reason for making it a device? The reason why I am asking > > > > > this is, as other DPDK devices as symmetry in queue(s), configure, > > > > > start, stop operation etc. > > > > > > > > > > > > > > > > + > > > > > > +struct rte_gpu_dev { > > > > > > + /* Backing device. */ > > > > > > + struct rte_device *device; > > > > > > > > > > See above? > > > > > > > > There is a PCI device probed. > > > > I don't understand why it would not be represented as a device. > > > > > > All other DPDK device has symmetry in structures like queue and > > > symmetry in operation like it has configure, start, stop etc. > > > This one seems more like mempool to me all we want set of > > > vendor-defined ops. So any justification on > > > make it a device ? why not like mempool library? > > > (driver/mempool/octeontx2 Mempool HW is also PCI device, but > > > we don't take device path for mempool. So I would like to understand > > > any technical reason for making it a device). > > > > I don't understand what you mean by "symmetry". > > The common attributes. or similarity The common attributes of a device are: - driver - bus - devargs We have these attributes for a GPU. About configure/start/stop usual functions, I think we'll have something similar in the second step for running tasks.