* [dpdk-dev] [PATCH] vhost/crypto: fix bracket
@ 2018-04-30 10:36 Fan Zhang
2018-04-30 10:46 ` Maxime Coquelin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fan Zhang @ 2018-04-30 10:36 UTC (permalink / raw)
To: dev; +Cc: roy.fan.zhang, maxime.coquelin, ferruh.yigit
Coverity issue: 233232
Coverity issue: 233237
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
lib/librte_vhost/vhost_crypto.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
index c38eb3bb5..a3bce6379 100644
--- a/lib/librte_vhost/vhost_crypto.c
+++ b/lib/librte_vhost/vhost_crypto.c
@@ -675,8 +675,7 @@ prepare_sym_cipher_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
goto error_exit;
}
if (unlikely(copy_data(rte_pktmbuf_mtod(m_src, uint8_t *), head,
- mem, &desc, cipher->para.src_data_len))
- < 0) {
+ mem, &desc, cipher->para.src_data_len) < 0)) {
ret = VIRTIO_CRYPTO_BADMSG;
goto error_exit;
}
--
2.13.6
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] vhost/crypto: fix bracket
2018-04-30 10:36 [dpdk-dev] [PATCH] vhost/crypto: fix bracket Fan Zhang
@ 2018-04-30 10:46 ` Maxime Coquelin
2018-04-30 12:57 ` Thomas Monjalon
2018-05-04 15:13 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2018-04-30 10:46 UTC (permalink / raw)
To: Fan Zhang, dev; +Cc: ferruh.yigit
On 04/30/2018 12:36 PM, Fan Zhang wrote:
> Coverity issue: 233232
> Coverity issue: 233237
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> lib/librte_vhost/vhost_crypto.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] vhost/crypto: fix bracket
2018-04-30 10:36 [dpdk-dev] [PATCH] vhost/crypto: fix bracket Fan Zhang
2018-04-30 10:46 ` Maxime Coquelin
@ 2018-04-30 12:57 ` Thomas Monjalon
2018-05-04 15:13 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-04-30 12:57 UTC (permalink / raw)
To: Fan Zhang; +Cc: dev, maxime.coquelin, ferruh.yigit
30/04/2018 12:36, Fan Zhang:
> Coverity issue: 233232
> Coverity issue: 233237
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
2 comments, Fan:
1/ I think it the v2 of a previous commit.
Please update the patchwork status (superseded),
use -v option for revision numbering,
and add a changelog.
2/ The title must give the scope of the change,
or give an idea of the impact of the patch.
Example:
fix symmetric ciphering
The root cause (bracket location) is better in the
commit message than the title.
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] vhost/crypto: fix bracket
2018-04-30 10:36 [dpdk-dev] [PATCH] vhost/crypto: fix bracket Fan Zhang
2018-04-30 10:46 ` Maxime Coquelin
2018-04-30 12:57 ` Thomas Monjalon
@ 2018-05-04 15:13 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2018-05-04 15:13 UTC (permalink / raw)
To: Fan Zhang, dev; +Cc: ferruh.yigit
On 04/30/2018 12:36 PM, Fan Zhang wrote:
> Coverity issue: 233232
> Coverity issue: 233237
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> lib/librte_vhost/vhost_crypto.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Applied to dpdk-next-virtio/master with changes suggested by Thomas.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-04 15:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-30 10:36 [dpdk-dev] [PATCH] vhost/crypto: fix bracket Fan Zhang
2018-04-30 10:46 ` Maxime Coquelin
2018-04-30 12:57 ` Thomas Monjalon
2018-05-04 15:13 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).