From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 76DB01B535 for <dev@dpdk.org>; Thu, 25 Apr 2019 10:19:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 36B7522EE6; Thu, 25 Apr 2019 04:19:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Apr 2019 04:19:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=jwYOc9vxz6i4XRxoqjE4ePAfkSsF0GMz8AiOzZnVvTY=; b=Pm9hX5riiuzJ 8wmzo3Qnpfq1YjicCE/EWrdiQFUsk1oQqz6q4GtnuBZe2VXBJd4e/IndbDsBMjol rHinWtcpoBIJpTLe8j+BYVWKI+RxUL3nQTZOjk46PNGwwCH/2HOD05MGZNMaKDwJ xK2cqNVwTJtyl1t7w/K4blCl5tOxT2c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=jwYOc9vxz6i4XRxoqjE4ePAfkSsF0GMz8AiOzZnVv TY=; b=iaOSkQqJ/dQxfh4jIOsSWASjcIz9duCUr3subLWv0d0PUkmssG5n61FtK z/7nVd8Qge2VrqGTD0GyvZJbMJscYgu8uaCtIoFl3n6Ho52Z4Pb2TaXdIL/9XNaT LdlXk4agNyZ0Cpvfn07kdsj0FtMZv3qiB5mkylbgwjIRrI9hBMGlP+u69CwKHrwg 5FvKjgtJqjUTKFgvbO+XJY76PVy78R0+k9jWkgBvpBvQ5q0aMJz7JWAZpgxp9hwf xYmGiYrY7PrNvlQ0sBTzOwTztkwg3IjVXbm723lzOs7X++DrS7EE21Y1851vV0ak 5JTaNFCO++XmmZEv4FTR69sq/sJXw== X-ME-Sender: <xms:lW3BXBxAaIhx0lYw8RqrwmdRd39lIR1iBjNhS2df0W2H1MU4RcReVQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrheeggddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epkeefrdduudehrdduheehrddufeeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:lW3BXEm4pXSHWtEbpv2-_fQJPhm65pzsFlcrGrV0jwES_z0ObXOcQA> <xmx:lW3BXHL7_rWI3Ms1Qs9KQ8pKQsEH1bWusvyMisOqOJkfBoGuiuupjQ> <xmx:lW3BXGslyUoyf1GDu7NIVZ4MEQRi-ToLJbZt5UCsa1-kLiQq9hZgPg> <xmx:lm3BXHzHkrOhHvZHjLTD37U-m1VZ_kA8s8aOzadO_Si2GOxrvpTlhw> Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id E3D48103D0; Thu, 25 Apr 2019 04:19:31 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Bernard Iremonger <bernard.iremonger@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, WenjieX A Li <wenjiex.a.li@intel.com> Date: Thu, 25 Apr 2019 10:19:28 +0200 Message-ID: <2485235.lFPfLJtBTM@xps> In-Reply-To: <20190424220309.84270-1-ferruh.yigit@intel.com> References: <20190424220309.84270-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 25 Apr 2019 08:19:37 -0000 25/04/2019 00:03, Ferruh Yigit: > This reverts commit bdca79053b6aea504d02691d9319fa976062457f. > > Not all PMDs support the fixed link speed set, and link speed can be set > even with auto negotiation enabled. Reverting the patch to not break > existing usage. Which PMDs do not support this flag? Why not fixing the PMDs? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5255DA05D3 for <public@inbox.dpdk.org>; Thu, 25 Apr 2019 10:19:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6DD21B56F; Thu, 25 Apr 2019 10:19:38 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 76DB01B535 for <dev@dpdk.org>; Thu, 25 Apr 2019 10:19:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 36B7522EE6; Thu, 25 Apr 2019 04:19:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Apr 2019 04:19:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=jwYOc9vxz6i4XRxoqjE4ePAfkSsF0GMz8AiOzZnVvTY=; b=Pm9hX5riiuzJ 8wmzo3Qnpfq1YjicCE/EWrdiQFUsk1oQqz6q4GtnuBZe2VXBJd4e/IndbDsBMjol rHinWtcpoBIJpTLe8j+BYVWKI+RxUL3nQTZOjk46PNGwwCH/2HOD05MGZNMaKDwJ xK2cqNVwTJtyl1t7w/K4blCl5tOxT2c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=jwYOc9vxz6i4XRxoqjE4ePAfkSsF0GMz8AiOzZnVv TY=; b=iaOSkQqJ/dQxfh4jIOsSWASjcIz9duCUr3subLWv0d0PUkmssG5n61FtK z/7nVd8Qge2VrqGTD0GyvZJbMJscYgu8uaCtIoFl3n6Ho52Z4Pb2TaXdIL/9XNaT LdlXk4agNyZ0Cpvfn07kdsj0FtMZv3qiB5mkylbgwjIRrI9hBMGlP+u69CwKHrwg 5FvKjgtJqjUTKFgvbO+XJY76PVy78R0+k9jWkgBvpBvQ5q0aMJz7JWAZpgxp9hwf xYmGiYrY7PrNvlQ0sBTzOwTztkwg3IjVXbm723lzOs7X++DrS7EE21Y1851vV0ak 5JTaNFCO++XmmZEv4FTR69sq/sJXw== X-ME-Sender: <xms:lW3BXBxAaIhx0lYw8RqrwmdRd39lIR1iBjNhS2df0W2H1MU4RcReVQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrheeggddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epkeefrdduudehrdduheehrddufeeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:lW3BXEm4pXSHWtEbpv2-_fQJPhm65pzsFlcrGrV0jwES_z0ObXOcQA> <xmx:lW3BXHL7_rWI3Ms1Qs9KQ8pKQsEH1bWusvyMisOqOJkfBoGuiuupjQ> <xmx:lW3BXGslyUoyf1GDu7NIVZ4MEQRi-ToLJbZt5UCsa1-kLiQq9hZgPg> <xmx:lm3BXHzHkrOhHvZHjLTD37U-m1VZ_kA8s8aOzadO_Si2GOxrvpTlhw> Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id E3D48103D0; Thu, 25 Apr 2019 04:19:31 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Bernard Iremonger <bernard.iremonger@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, WenjieX A Li <wenjiex.a.li@intel.com> Date: Thu, 25 Apr 2019 10:19:28 +0200 Message-ID: <2485235.lFPfLJtBTM@xps> In-Reply-To: <20190424220309.84270-1-ferruh.yigit@intel.com> References: <20190424220309.84270-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190425081928.H7Efgyx1-qTYWtZsYCG1wT8WjHaBTA3inija21wPbJk@z> 25/04/2019 00:03, Ferruh Yigit: > This reverts commit bdca79053b6aea504d02691d9319fa976062457f. > > Not all PMDs support the fixed link speed set, and link speed can be set > even with auto negotiation enabled. Reverting the patch to not break > existing usage. Which PMDs do not support this flag? Why not fixing the PMDs?