From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Emmanuel Roullit <emmanuel.roullit@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: reset driver name pointer on failure
Date: Sun, 29 Jan 2017 23:35:39 +0100 [thread overview]
Message-ID: <2487536.DRxuiboR0Q@xps13> (raw)
In-Reply-To: <20170124202656.792-1-emmanuel.roullit@gmail.com>
2017-01-24 21:26, Emmanuel Roullit:
> The pointer set by strdup() needs to be cleared on failure to avoid a
> potential double-free from the caller.
>
> Found with clang static analysis:
> lib/librte_eal/common/eal_common_devargs.c:123:2:
> warning: Attempt to free released memory
> free(buf);
> ^~~~~~~~~
>
> Fixes: 3fe2e5fec82b ("eal: fix argument parsing check")
The real bug origin is:
Fixes: 0fe11ec592b2 ("eal: add vdev init and uninit")
> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
Applied, thanks
prev parent reply other threads:[~2017-01-29 22:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 20:26 Emmanuel Roullit
2017-01-29 22:35 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2487536.DRxuiboR0Q@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=emmanuel.roullit@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).