From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id BF0CD1B5D0; Mon, 26 Nov 2018 15:37:20 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4EE2F21EA7; Mon, 26 Nov 2018 09:37:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 26 Nov 2018 09:37:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Fw83qtgbSP0PGgrpkw/fO94QWxn21WN2kCnmgtvGdvc=; b=hFnHVEVjQDra HLnPhfdhZzUL/oK86aiGdJCDP3j8epA4BQ9J2koxT9rP+t4HLpt2/DUpw77+scqP t4ttXchPeyAOihIxh2oqaHFcFfzzdGrlCSwBG5yhIbZrfhvzivVLtlxVmg9v0Nsc 9DOp3tymSMCPG1j3tHRsI8kIG9JS12Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Fw83qtgbSP0PGgrpkw/fO94QWxn21WN2kCnmgtvGd vc=; b=kF6IIZfD/48XX+Y+/t1HfZ4BEKU/fDZe3mBwOhiM14dbS1ZLvvMKPmlAX uL7xbCR2BeajzHEr0xB9e4FDOeK7bIsIQWPdUSDDzsmstxrwYyhfo7ZLQx6+TLIM d8y9ln4R2uEnGY0YxkB8kGHnejt0HPnQz/SqIi1Zgt3g5nZTOVGlEhY57PcGRw9H gwEObyMtILjlIlapl74Vs3HZZEzNd3/xsB3CoS6sihxmZxpj4ILVp/JneJ8+RHf7 lTTYhwlbNxNbQ0uWjQIRoM3jAojPxph+seOExY2sP0a7/QbiTr1FmJYR5swqsNiM 1gZnhR7MnLu6gNyQ0bXqhHEeBnjwA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 124C8102DD; Mon, 26 Nov 2018 09:37:18 -0500 (EST) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, "Hunt, David" , stable@dpdk.org Date: Mon, 26 Nov 2018 15:37:18 +0100 Message-ID: <24892453.gmzSld7mhP@xps> In-Reply-To: <73443011-2b32-ce73-ef0d-896858f7503d@intel.com> References: <294f089848bf803ff134979c612bbf28e0e2e6b9.1543229588.git.anatoly.burakov@intel.com> <73443011-2b32-ce73-ef0d-896858f7503d@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mem: fix division by zero in no-NUMA mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 14:37:21 -0000 26/11/2018 12:14, Hunt, David: > Hi Anatoly, > > On 26/11/2018 10:57 AM, Anatoly Burakov wrote: > > When RTE_EAL_NUMA_AWARE_HUGEPAGES is set to "n", not all memtypes > > will be valid, because we skip some due to not supporting other > > NUMA nodes, leading to a division by zero error down the line > > because the necessary memtype fields weren't populated. > > > > Fix it by limiting number of memtypes to number of memtypes we > > have actually created. > > > > Fixes: 1dd342d0fdc4 ("mem: improve segment list preallocation") > > Cc: stable@dpdk.org > > > > Signed-off-by: Anatoly Burakov > > Fixes the issue on my machine. vm_power_manager crashes with floating point > exception without patch, starts successfully with patch. > > Tested-by: David Hunt Applied (in last minute), thanks