From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 0A2542B89 for ; Thu, 7 Dec 2017 10:22:52 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6DBB721BA7; Thu, 7 Dec 2017 09:22:52 +0000 (UTC) Received: from [10.36.112.55] (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89BE36E727; Thu, 7 Dec 2017 09:22:47 +0000 (UTC) To: Tiwei Bie , yliu@fridaylinux.org, dev@dpdk.org References: <20171207053059.19487-1-tiwei.bie@intel.com> <20171207053059.19487-6-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <248fce65-c2af-e3c7-d833-201c60506f05@redhat.com> Date: Thu, 7 Dec 2017 10:22:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171207053059.19487-6-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 07 Dec 2017 09:22:52 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 5/5] net/virtio: squeeze repeated blank lines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 09:22:53 -0000 On 12/07/2017 06:30 AM, Tiwei Bie wrote: > Squeeze repeated blank lines with below scripts: > > for i in $(find . -name "*.[ch]"); do \ > cat -s $i > /tmp/x && mv /tmp/x $i; done > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 1 - > drivers/net/virtio/virtio_logs.h | 1 - > drivers/net/virtio/virtio_pci.c | 1 - > drivers/net/virtio/virtio_pci.h | 2 -- > drivers/net/virtio/virtio_rxtx.c | 2 -- > 5 files changed, 7 deletions(-) I don't really like such cleaning patches. It does not bring added value, but can create conflicts later when backporting or rebasing. Maxime > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 9caa133c9..aa6d494ca 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1801,7 +1801,6 @@ virtio_dev_configure(struct rte_eth_dev *dev) > return 0; > } > > - > static int > virtio_dev_start(struct rte_eth_dev *dev) > { > diff --git a/drivers/net/virtio/virtio_logs.h b/drivers/net/virtio/virtio_logs.h > index 90a79eaa5..6ce3149d5 100644 > --- a/drivers/net/virtio/virtio_logs.h > +++ b/drivers/net/virtio/virtio_logs.h > @@ -59,7 +59,6 @@ > #define PMD_TX_LOG(level, fmt, args...) do { } while(0) > #endif > > - > #ifdef RTE_LIBRTE_VIRTIO_DEBUG_DRIVER > #define PMD_DRV_LOG(level, fmt, args...) \ > RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) > diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c > index 9574498fb..684ef560c 100644 > --- a/drivers/net/virtio/virtio_pci.c > +++ b/drivers/net/virtio/virtio_pci.c > @@ -481,7 +481,6 @@ const struct virtio_pci_ops modern_ops = { > .notify_queue = modern_notify_queue, > }; > > - > void > vtpci_read_dev_config(struct virtio_hw *hw, size_t offset, > void *dst, int length) > diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h > index 3c5ce66ce..e42962a99 100644 > --- a/drivers/net/virtio/virtio_pci.h > +++ b/drivers/net/virtio/virtio_pci.h > @@ -274,7 +274,6 @@ struct virtio_hw { > struct virtqueue **vqs; > }; > > - > /* > * While virtio_hw is stored in shared memory, this structure stores > * some infos that may vary in the multiple process model locally. > @@ -290,7 +289,6 @@ struct virtio_hw_internal { > > extern struct virtio_hw_internal virtio_hw_internal[RTE_MAX_ETHPORTS]; > > - > /* > * This structure is just a reference to read > * net device specific config space; it just a chodu structure > diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c > index 390c137c8..7ccd1da34 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -66,7 +66,6 @@ > #define VIRTIO_DUMP_PACKET(m, len) do { } while (0) > #endif > > - > #define VIRTIO_SIMPLE_FLAGS ((uint32_t)ETH_TXQ_FLAGS_NOMULTSEGS | \ > ETH_TXQ_FLAGS_NOOFFLOADS) > > @@ -175,7 +174,6 @@ virtio_xmit_cleanup(struct virtqueue *vq, uint16_t num) > } > } > > - > static inline int > virtqueue_enqueue_recv_refill(struct virtqueue *vq, struct rte_mbuf *cookie) > { >