Re: [dpdk-dev] [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation

[Yongseok Koh <yskoh@mellanox.com>]

> On Nov 11, 2018, at 3:15 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
> 
> Such limitation seems not to exist on:
> - MLNX_OFED_linux-4.5-0.3.0.0 (Beta)
> - MLNX_OFED_LINUX-4.4-2.0.7.0 (GA)
> - upstream kernel 4.19.0-rc7
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
 
Thanks
> drivers/net/mlx5/mlx5_flow.c | 11 -----------
> 1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 8039664bc2..9c17627da7 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -1240,17 +1240,6 @@ mlx5_flow_validate_item_ipv6(const struct rte_flow_item *item,
> 		return rte_flow_error_set(error, EINVAL,
> 					  RTE_FLOW_ERROR_TYPE_ITEM, item,
> 					  "L3 cannot follow an L4 layer.");
> -	/*
> -	 * IPv6 is not recognised by the NIC inside a GRE tunnel.
> -	 * Such support has to be disabled as the rule will be
> -	 * accepted.  Issue reproduced with Mellanox OFED 4.3-3.0.2.1 and
> -	 * Mellanox OFED 4.4-1.0.0.0.
> -	 */
> -	if (tunnel && item_flags & MLX5_FLOW_LAYER_GRE)
> -		return rte_flow_error_set(error, ENOTSUP,
> -					  RTE_FLOW_ERROR_TYPE_ITEM, item,
> -					  "IPv6 inside a GRE tunnel is"
> -					  " not recognised.");
> 	if (!mask)
> 		mask = &rte_flow_item_ipv6_mask;
> 	ret = mlx5_flow_item_acceptable(item, (const uint8_t *)mask,
> -- 
> 2.12.0
>