From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00070.outbound.protection.outlook.com [40.107.0.70]) by dpdk.org (Postfix) with ESMTP id 6B1B1288C for ; Sun, 11 Nov 2018 12:32:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IsAoaWOiOhLlOGdYA0v8KdhpwZqPUcOgVjxsDATD1VY=; b=HcjCs3gTeFv3rq5VnquAueMjaI69QvE5QhuAoGuGK0nokUlf35iPNqvxpp+DLQJAIwfRqrWovIr4bdfxQAP2dbWZ+ZTqhIR9XcPv97HhSKaQOyO4G8x6gPp+M5HpR9EuLIYNw7F7lDN6TCq5miB/9I9jdMHwZliv8sZOfeaAREs= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4091.eurprd05.prod.outlook.com (52.134.68.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.27; Sun, 11 Nov 2018 11:32:04 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::58e7:97d8:f9c1:4323]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::58e7:97d8:f9c1:4323%3]) with mapi id 15.20.1294.044; Sun, 11 Nov 2018 11:32:04 +0000 From: Yongseok Koh To: Shahaf Shuler CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation Thread-Index: AQHUea/qcy/z0d1LKU2KNw1EV6zKJ6VKcPWA Date: Sun, 11 Nov 2018 11:32:03 +0000 Message-ID: <24922204-F417-4D0B-9883-D8F85276E203@mellanox.com> References: <20181111111526.161148-1-shahafs@mellanox.com> In-Reply-To: <20181111111526.161148-1-shahafs@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4091; 6:dnWxEMVLE5QPvqa2kxgGrK607C0RUYbnnHmy+z4sFraUPkcatcJz/6SAOVL8fpn55rTYWvkaNgVTPp+tzzW7VqXvIuhy+Tzw8Q9gWpt4CIFiPArNz6a/NF9YjcPQG0QutuiP19+4X96LWxI3yuX1Dj8AOmMW60uUWoZvJJsqp7KplYLqJjuuJ/nD4RWxWdBztASlzpypXLhskkRuAzdh+BftlSveqWapP90YueSuqW8t9e4o6PVrPsMY4Tf3pg6h+dyzkTXwCHF9tVVqljdtpHtZ6AOs2YzpmwH2aA0/qlEIzbtuJKR4TuZb8uLJJtr5or8XY7vt/mjQrd+y7/ckFuEVoOfcla08Fs1zonhX5KHo/23FOO5UPN/AEmiyxVBxjoA6HmJHShANFw3SU+O8+I87O58WWV9YMIuwxNcjlHD5YfBMlhpWBaTkYJUCz5DZ/iQ/qb34MS3W9ggk6v1g8g==; 5:tmfSyVW9TD2uhy5LM/ksiydon6tTl8NRroG3uRAZuZE3mrAxraB/h0OqZ8PEJQrfPcP9lqbWbdAfKmbxlbJh8jDgXRlcTSkBVgipmJB2xbc/M0hj7PRDoTLp7lxaz/9OJA5t9SZwBUo6TAMjM7VeYOMtX8O22nk1QPdx4TDXl90=; 7:CSKxNykBzYCOUfXfHomjb8iM0TfAQ4JaDNvSr3OVZZllZJuDDBRK627Gwm1YWNXqbbysyWbOvTKeDHrYNo/MBnZVoTWcx2tgVHbGxXVqM8SRIquX6MRNqug0DfUzmFRdeMbdenbTF6famejKiX1IBw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 6c40ceac-78bc-4968-93ac-08d647c94deb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390040)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4091; x-ms-traffictypediagnostic: DB3PR0502MB4091: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(17755550239193); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231402)(944501410)(52105112)(6055026)(148016)(149066)(150057)(6041310)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:DB3PR0502MB4091; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4091; x-forefront-prvs: 08534B37A7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(136003)(376002)(39860400002)(346002)(189003)(199004)(11346002)(2900100001)(8936002)(316002)(476003)(86362001)(2616005)(186003)(66066001)(7736002)(14454004)(446003)(99286004)(53546011)(5660300001)(6506007)(81156014)(81166006)(8676002)(102836004)(76176011)(305945005)(229853002)(26005)(36756003)(68736007)(2906002)(6636002)(105586002)(106356001)(33656002)(82746002)(25786009)(53936002)(4326008)(6512007)(6436002)(6862004)(71200400001)(6246003)(97736004)(71190400001)(6486002)(486006)(6116002)(83716004)(256004)(37006003)(3846002)(478600001)(14444005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4091; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ZWxPF7HP9wJGlD/z0eU5+hDekry43YlKOOMfnmLKSdQusgE2AqAQNQuh8N1Bf2jbaqTeyFIK/SL93T5f9O2rciqSWbd2V3FaaLpioG7ir3z7bvxJsiAnFQbSlf13RtUcQtnZLBjKkV2znS32UGB0Zwj2MIQmeIhxkgpphVpmCiT852SIttZOor/9Ov0aGKPRpeWXeqcUG349WVaTVC8VJTSNOKkD6sA6dNVUW2BD6bsLNYfat+9VDGWaslmg7c7IHsTb7DlmQje/B6ku+qRyNdSAqbfjdfLKww2bnBZ2yluAas2iGkZb9PXZdDLKk4t8t4c/DhuSaLKR2bg49zT69N/ns2BBdIbtJjaISjQeA0s= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <07C1CAB0799F804DB51CCE94220F7DE7@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c40ceac-78bc-4968-93ac-08d647c94deb X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2018 11:32:03.9380 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4091 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Nov 2018 11:32:05 -0000 > On Nov 11, 2018, at 3:15 AM, Shahaf Shuler wrote: >=20 > Such limitation seems not to exist on: > - MLNX_OFED_linux-4.5-0.3.0.0 (Beta) > - MLNX_OFED_LINUX-4.4-2.0.7.0 (GA) > - upstream kernel 4.19.0-rc7 >=20 > Signed-off-by: Shahaf Shuler > --- Acked-by: Yongseok Koh =20 Thanks > drivers/net/mlx5/mlx5_flow.c | 11 ----------- > 1 file changed, 11 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 8039664bc2..9c17627da7 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -1240,17 +1240,6 @@ mlx5_flow_validate_item_ipv6(const struct rte_flow= _item *item, > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ITEM, item, > "L3 cannot follow an L4 layer."); > - /* > - * IPv6 is not recognised by the NIC inside a GRE tunnel. > - * Such support has to be disabled as the rule will be > - * accepted. Issue reproduced with Mellanox OFED 4.3-3.0.2.1 and > - * Mellanox OFED 4.4-1.0.0.0. > - */ > - if (tunnel && item_flags & MLX5_FLOW_LAYER_GRE) > - return rte_flow_error_set(error, ENOTSUP, > - RTE_FLOW_ERROR_TYPE_ITEM, item, > - "IPv6 inside a GRE tunnel is" > - " not recognised."); > if (!mask) > mask =3D &rte_flow_item_ipv6_mask; > ret =3D mlx5_flow_item_acceptable(item, (const uint8_t *)mask, > --=20 > 2.12.0 >=20