From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43647A0487 for ; Tue, 2 Jul 2019 16:18:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0ECF51B970; Tue, 2 Jul 2019 16:18:22 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 135935424 for ; Tue, 2 Jul 2019 16:18:20 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6537320A0D; Tue, 2 Jul 2019 10:18:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Jul 2019 10:18:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=6d+JFJLIJWkhLNZQkYtPNKBDa0ewaoVzuv6dGmLh1vQ=; b=NsfpOkOkHyNn W9zwxv/TCHxmEJ2dLK/kCClmJNsvR5So1/eWBjPFr52SsuvjdKyR2uw7jSlZ4fw+ AOG+wbOMiGRMQzxOl9f4v/PYOp+YVEqmYrd0spP4iFRq2qG3AbKPOClq3kwC5wDV nSJ+6IqeHPsyplLaNaE2fXOF182CInc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=6d+JFJLIJWkhLNZQkYtPNKBDa0ewaoVzuv6dGmLh1 vQ=; b=cxDtSzfTeXhVe6t3/9TR7NMzjckaON42LqyEcMJ0C01wSf5I+3Q6lZNmo 7K/Y7ehWng2g+qA9ysSS2itqc7ZXMS9lo0PdYpzKXnSB7mR+iDY0FUDLr1prwENV ydY5udxLzaaFYmiF7cwn1gg9gjzyXYMhYSFsUQQLR8NDnrGN7Z8OKXpIYo8Qx7O7 32Kii7JCdFr8+LN8311PE/bXUYrCm4u83FeUkW71pKSno0yspLWK8g8pBZdAS8nb dKnL+gCG54+W9wX8zvRDBwaxkLBvwKJ3fiZqEZiaSvQQAZZ0xSRHWAqUPEcH+/gQ PVbOht52N8BdrlntXfKBmp4cqfM3A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvdekgdejjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E06D8380083; Tue, 2 Jul 2019 10:18:16 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: David Marchand , benjamin.walker@intel.com, jerinj@marvell.com, anatoly.burakov@intel.com, maxime.coquelin@redhat.com, hemant.agrawal@nxp.com, honnappa.nagarahalli@arm.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Date: Tue, 02 Jul 2019 16:18:15 +0200 Message-ID: <2492825.eVpYDgOmm4@xps> In-Reply-To: <3396376.MrP74pr19o@xps> References: <20190530174819.1160221-1-benjamin.walker@intel.com> <1560505157-9769-1-git-send-email-david.marchand@redhat.com> <3396376.MrP74pr19o@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 0/3] Improve automatic selection of IOVA mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" No review at all? I can merge then? 27/06/2019 19:05, Thomas Monjalon: > Help in review would be much appreciated here, thanks. > > 14/06/2019 11:39, David Marchand: > > In SPDK, not all drivers are registered with DPDK at start up time. > > Previously, that meant DPDK always chose to set itself up in IOVA_PA > > mode. Instead, when the correct iova choice is unclear based on the > > devices and drivers known to DPDK at start up time, use other heuristics > > (such as whether /proc/self/pagemap is accessible) to make a better > > choice. > > > > This enables SPDK to run as an unprivileged user again without requiring > > users to explicitly set the iova mode on the command line. > > > > > > Changelog since v1: > > - I took over the series following experiments and discussions with Ben > > and others, squashed Ben patches as two patches focusing on the main > > issues, > > - introduced a fix on KNI, > > - on the EAL bits, > > > > - added log on which IOVA mode has been selected, > > - updated BSD EAL, > > - in Linux EAL, moved KNI special case after IOVA selection, > > - in Linux EAL, added check on forced mode wrt physical addresses > > availability, > > > > - on the PCI bus driver bits, > > > > - enforced the checks in the common code of the PCI bus, > > - added debug logs to track why a iova mode has been chosen per device, > > - added BSD part, > > - in Linux part, checked that VFIO is enabled, > > - in Linux part, defaulted to DC if a driver supports both PA and VA, > > > >