From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B251A09D9; Wed, 11 Nov 2020 17:02:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A9D531FC; Wed, 11 Nov 2020 17:02:34 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4758D31FC for ; Wed, 11 Nov 2020 17:02:33 +0100 (CET) IronPort-SDR: IjvFIVBybj2XnddgMdsQ4Pjy98vdGiC/0+nHKEEDrOa/OewiDK+Qr0m6nW5xLXg11BUTrYzneF vBsrJaG3HTGg== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="254876201" X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="254876201" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 08:02:30 -0800 IronPort-SDR: ugGApszrXFRzJ9naYC0HIGb5SSPHDCos4YgNKJq7WwJMpNH71GD1mTD2jVFNV8ltQ5SaeArjwC eL3ANsw2fhdw== X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="473901930" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.123]) ([10.213.241.123]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 08:02:29 -0800 To: Jiawen Wu , dev@dpdk.org References: <20201111064936.768604-1-jiawenwu@trustnetic.com> <20201111064936.768604-7-jiawenwu@trustnetic.com> From: Ferruh Yigit Message-ID: <249317fb-35a7-53dd-a7cb-8124685e9ae2@intel.com> Date: Wed, 11 Nov 2020 16:02:26 +0000 MIME-Version: 1.0 In-Reply-To: <20201111064936.768604-7-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 06/37] net/txgbe: add ethertype parse rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/11/2020 6:49 AM, Jiawen Wu wrote: > Add support to parse flow for ethertype filter. > > Signed-off-by: Jiawen Wu <...> > +static int > +txgbe_parse_ethertype_filter(struct rte_eth_dev *dev, > + const struct rte_flow_attr *attr, > + const struct rte_flow_item pattern[], > + const struct rte_flow_action actions[], > + struct rte_eth_ethertype_filter *filter, > + struct rte_flow_error *error) > +{ > + int ret; > + > + ret = cons_parse_ethertype_filter(attr, pattern, > + actions, filter, error); > + > + if (ret) > + return ret; > + > + /* txgbe doesn't support MAC address. */ > + if (filter->flags & RTE_ETHTYPE_FLAGS_MAC) { > + memset(filter, 0, sizeof(struct rte_eth_ethertype_filter)); > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM, > + NULL, "Not supported by ethertype filter"); > + return -rte_errno; > + } > + > + if (filter->queue >= dev->data->nb_rx_queues) { > + memset(filter, 0, sizeof(struct rte_eth_ethertype_filter)); > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM, > + NULL, "queue index much too big"); > + return -rte_errno; > + } > + > + if (filter->ether_type == RTE_ETHER_TYPE_IPV4 || > + filter->ether_type == RTE_ETHER_TYPE_IPV6) { > + memset(filter, 0, sizeof(struct rte_eth_ethertype_filter)); > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM, > + NULL, "IPv4/IPv6 not supported by ethertype filter"); > + return -rte_errno; > + } > + > + if (filter->flags & RTE_ETHTYPE_FLAGS_MAC) { > + memset(filter, 0, sizeof(struct rte_eth_ethertype_filter)); > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM, > + NULL, "mac compare is unsupported"); > + return -rte_errno; > + } Isn't 'RTE_ETHTYPE_FLAGS_MAC' already checked a few blocks above, that time error message was ""Not supported by ethertype filter" > + > + if (filter->flags & RTE_ETHTYPE_FLAGS_DROP) { > + memset(filter, 0, sizeof(struct rte_eth_ethertype_filter)); > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM, > + NULL, "drop option is unsupported"); > + return -rte_errno; > + } > + > + return 0; > +} > + >