From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 0E5EB3238
 for <dev@dpdk.org>; Tue, 21 Feb 2017 12:24:05 +0100 (CET)
Received: by mail-wm0-f51.google.com with SMTP id v77so72819017wmv.0
 for <dev@dpdk.org>; Tue, 21 Feb 2017 03:24:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=nqbNLW2clr1l4MAG/uQGttaSQ2DPmA8+sXcmSjQaslA=;
 b=1+S+HKhb9E9KlWBv5Fq9HRHZhmI4oUV9ef1bIowL7TM5kFePO5jBI74F3zUKChMrK7
 8I2eh9OXTOBwvjIhjU7gCLvFFFc39l/GiRgxYeL8awljTlEA3tcFecYE6eVtxUmJKNG6
 zY8wWj8rQ5aBdmUmiaXBFCe7WLcP9/vllxikHPOkORMqN7s7/OzOCahRkk0jMsPPN5ri
 h2BfL1LkKARr8uM+9Rl2y5ePjZsadUwtrb0KWZnt1gVBvbgviTWW1aJG7d1V3r0DaNTP
 K1cPHIN6bzvQy60YVdtwDokNGbjbahWiJE0WrZK1tivgPObAY2/nEoGEIJDfDYGkVUvq
 nBhw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=nqbNLW2clr1l4MAG/uQGttaSQ2DPmA8+sXcmSjQaslA=;
 b=fCB8SvV8awHXOVm69lq/bpj6ER30an6dSdngnEfPqhIh8iokZh87ui3Wx0mc0v8hIL
 Xx77naijq6pYc3D4WaRhl0cxc0+2CXWWksY9v4qVFmInvGEYlgOZ7C0uiqAFTDdUI9gP
 Tj5nUmLS4Ot9daSRQOqLa/7ZPBjRGoV2dLtZWPCYGEgWPfvTlwAiFrgaSIH2HpHuBBID
 eDboSIZ2vm6VLgRdDGCeYSYP0QGgnaCXKivUoJqxNOIiE+0MtVzL3IJwpygOk8DtTne4
 mxnyQ0RP9Y4a0HDV7swwD8ZVa6USjUxxMI18gB8fp+09yiH1DVjZvUg5vMaJ6Kr6sZer
 lZ8w==
X-Gm-Message-State: AMke39lNWRywCXFg5Wf7idlhQxfJqufmUZvhNluGfl+JAOifT/+ZR86CrftO1rnakFDjD4sk
X-Received: by 10.28.215.200 with SMTP id o191mr13860268wmg.118.1487676244829; 
 Tue, 21 Feb 2017 03:24:04 -0800 (PST)
Received: from xps13.localnet (111.15.136.77.rev.sfr.net. [77.136.15.111])
 by smtp.gmail.com with ESMTPSA id h3sm28533550wrb.31.2017.02.21.03.24.03
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 21 Feb 2017 03:24:04 -0800 (PST)
Date: Tue, 21 Feb 2017 03:24:04 -0800 (PST)
X-Google-Original-Date: Tue, 21 Feb 2017 12:24 +0100
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Hunt <david.hunt@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Message-ID: <2496384.fbhMURyGl7@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <20170220111632.GA144436@bricha3-MOBL3.ger.corp.intel.com>
References: <1487563713-165778-1-git-send-email-david.hunt@intel.com>
 <20170220111632.GA144436@bricha3-MOBL3.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v1] scripts: make checkpatch cleaner for
	renamed files
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Feb 2017 11:24:05 -0000

2017-02-20 11:16, Bruce Richardson:
> On Mon, Feb 20, 2017 at 04:08:33AM +0000, David Hunt wrote:
> > When a file is renamed, a normal diff will include all the code of
> > the renamed file, and checkpatch will find warnings and errors,
> > even though it's just a rename.
> > 
> > This change will result in a 'rename' line in the diff, resulting
> > in a much cleaner checkpatches result.
> > 
> > Signed-off-by: David Hunt <david.hunt@intel.com>
> > ---
> >  devtools/checkpatches.sh | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> > index cfe262b..6fbfb50 100755
> > --- a/devtools/checkpatches.sh
> > +++ b/devtools/checkpatches.sh
> > @@ -89,7 +89,8 @@ check () { # <patch> <commit> <title>
> >  	if [ -n "$1" ] ; then
> >  		report=$($DPDK_CHECKPATCH_PATH $options "$1" 2>/dev/null)
> >  	elif [ -n "$2" ] ; then
> > -		report=$(git format-patch --no-stat --stdout -1 $commit |
> > +		report=$(git format-patch --find-renames \
> > +			--no-stat --stdout -1 $commit |
> >  			$DPDK_CHECKPATCH_PATH $options - 2>/dev/null)
> >  	else
> >  		report=$($DPDK_CHECKPATCH_PATH $options - 2>/dev/null)
> 
> This seems a good idea. Renaming legacy files which aren't checkpatch
> clean throws up lots of issues that we don't want to fix as part of the
> rename.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks