From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16FD145CDF; Mon, 11 Nov 2024 01:21:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F361640A6E; Mon, 11 Nov 2024 01:21:24 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2069.outbound.protection.outlook.com [40.107.102.69]) by mails.dpdk.org (Postfix) with ESMTP id C8D5C40151 for ; Mon, 11 Nov 2024 01:21:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ad4YxYcIZmLEJfNsayNVKDDlRnHaX9//DVtwMwjIarBlBfvflBBXTCjbO4HPaPR3f/sVwHzkzEkiqQtf6swKhKU7h9BOEtr5Wj/cGknt0G9p6ZO4gYMM2ws2bG2/LKUJXI4RLsPFbiTZOn1lMZea0NkPbzJ3ZYq3ZBwPyhwtVAdRsyA39Ltp0LKzGqDOFM1uh67hpwQlFlJkO7Q4JII5SSx7su+jkuLidWdhHX4z0WG7CssuRucHXidbbnTk/zxVhRzoDpQrwbjyL7LjbkvxQ0AG8gfdIi7D96KovWoYYmry4ewHbFlenu+8X6g1/u6Yozmx9MXhthdnKYJ9TuW+ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fORUOYkJocVYdvPkPl9iyRojGYLXDPg1NALkc6czPh4=; b=fOAFedNbqNh+J4be9tM2/C6Hw1iE54FHOMbikIa07Rhsd1ImcM69Fzm94anBV/PRncy2PiFoRoThXflmoEsKnCzZqcWeptTrYQNs3sbKnFGxO0Z2CUiq/f6SK+YD03pdNr8+hHZKQ9lRNWCfCSHe+I3nmi87wyof8RLqQ8Q0lskb8SR/cJFMhWpnhLfL50TWbyhefFoKfwXRi4MxI+W1apeptMTNr3/a5CAdbn9tJVqx+WTWhBdNJmwFKZTqsgL/ln++nzaGGSwu3BjRAMfbyT4rfKUWqWKVM0bvKtmgomGXKF3vqcYB9FGHqWnVgQMNvbpa4yanNtYY7BNbib4+6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fORUOYkJocVYdvPkPl9iyRojGYLXDPg1NALkc6czPh4=; b=b3KI1Dov8vnD8YedbjWxVP/Jyk0I3CNOMSIi33jxZVCvuoqL00/++SNd7Uo9LNPGs9hJrYRC4vwrUp4lzC0nrwJ+nzrwVDrIYWHx/ajwdvzmII1ooqBy7sA8IwGB4D8HM3BmHCfcP522IV6PRj5JNCkYo54gUz8RdfbSLcLu1/s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by SA1PR12MB6750.namprd12.prod.outlook.com (2603:10b6:806:257::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.26; Mon, 11 Nov 2024 00:21:20 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%3]) with mapi id 15.20.8137.027; Mon, 11 Nov 2024 00:21:20 +0000 Message-ID: <24ae6ded-bc54-44b6-bf51-a89331e54bc0@amd.com> Date: Mon, 11 Nov 2024 00:21:15 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 13/17] net/r8169: implement device statistics To: Howard Wang , dev@dpdk.org Cc: pro_nic_dpdk@realtek.com References: <20241108121123.248797-1-howard_wang@realsil.com.cn> <20241108121123.248797-14-howard_wang@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241108121123.248797-14-howard_wang@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0037.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::11) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|SA1PR12MB6750:EE_ X-MS-Office365-Filtering-Correlation-Id: b6239844-72a3-4bcf-f97e-08dd01e6c440 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MFFqVnQ3a2x3Y3BWNCtMTzNSSmdIaGlYekN6N2U5ZGFiVUN2YWFxTjJLMzRF?= =?utf-8?B?a2xReUJNTG8rcmpoTEZOaHNjblNMbklGWWJLUENqTWdTQlhYSVVOdCtlZ1FN?= =?utf-8?B?VjZINFNZS2FrdGsvTkdoTHVBdU5LZGJVUm9oT3N5Ym5pamM4MnVuUUwwYTIz?= =?utf-8?B?SDk3NkR4UXo0eDZIZkdlQmZLRzZIL3o0T3N4b3RwRHUwQ0cvOHBKdnJtQVB6?= =?utf-8?B?amhpYkU4N3FsV1dYdEJuUVU1OUFlZGVFNzdBRUF4NUZQenVITFdjdWtRcm0w?= =?utf-8?B?S2F5NlpzTXlUN0lzVXUzdEM3VjVaZjFMYWJON3pRRE1DMU5uOFg1ZXJuc1pP?= =?utf-8?B?SlZreEhqUEFkTVpjb2hmOE9JNmNyMStndWtROExFOTVwOWhlZDhadGhMbWlU?= =?utf-8?B?YnNtbVFncXJlQ215V1NLSTUyMUdkWEI5SldmZDBrcG1TOTBNVTFYN1d5WkxC?= =?utf-8?B?SUM1SjFJOGNyM1d5WHpPa2dIQnJSRTB5RUVaSlFVczVjR25tbW1wZ3k0eWdz?= =?utf-8?B?YkZIZUZSYTZCck5zVWg1dVF2MUVwV2Mwd2NCL1A3dUdMM1oyTmJHUXdtNDRC?= =?utf-8?B?OTJXVGg0TDlha2xUZE5vV3hkdW00MHVFLzYwcllUR0Q2eDNpeHlzUjhXZ3Zn?= =?utf-8?B?SVA4bTVUZ3hSNjA1YWxiRURIQ1Z3Z0EwQzZzL3RTM2ZEY1pJdEhUU1RKS3Za?= =?utf-8?B?eEZ0UnJMN1p4OUVrS3dDOTBJSFVNdEYxQk5BWUc2S0tadU9JUUZDeWhaYUZV?= =?utf-8?B?azZBMmk1NFRqcENlc01LQTdlL3lncmxFY0FVbFBnNUxyTmc2SFQxeTNhNWpk?= =?utf-8?B?aW1aUSt1N29jdDY5UWVNTHZkWWhaTVFnYTRyUC9BYmQwSzUvSTlVb29EMzM2?= =?utf-8?B?MkhaTHo5U2M1MkpoeWxUbjhscXppUlhJRTRUOURyZFgweXVPdisrMkxEV2Fx?= =?utf-8?B?UHQvSzBVNlBMQ29Da3AvTElYYUZ5NFdFek9jZTdoM1VkUi9QMlozOE9rdWhT?= =?utf-8?B?d0JVYU5ZdWFRY3VGbzJGRFBYN1F6YzZaN1N2cTdTWmV1dG9vWW14Wm9LeTFv?= =?utf-8?B?M2p0RzJHV2NuNmlHVnFneXFsTVMyWWJyMFJmOVRtVGtnOER5OG54UXJ3eUl0?= =?utf-8?B?ZzF6T3lFcG14dFVyeWNjSHZWdUgwM0pMYkNnTHc3YWxhUmJ2VEQ3dm9IVmZH?= =?utf-8?B?TWVpZmxtbWx4SlVPTjNRdll6a1Qvd2RNeldaY2VsVUJ4U1RZcUZDV2l5Rllx?= =?utf-8?B?R2dTQjFFV09JYVp6M2trYm9WVHZCaTBWTW1UNkxvK2w0M29aaXZSczFpWlBJ?= =?utf-8?B?NnU5VjhyTXdKRWdQRmdkL0MrRVhlV2IzblRrWGtzT1FtdVlUOFdhWGsxWHpW?= =?utf-8?B?NzgvU0UvN2FLTGM0akZuY3UzU3dJSGlUVlV0R3J0WUdZZzVrOTRBMEY1Sndh?= =?utf-8?B?b29QSXhxM1MxOFpqRml1RzBSS291MEpTdGF0TDlRTmRMMWVmRlVSM0JjRG5J?= =?utf-8?B?Tng5dmc5d2ZRejlVWU5KM3hCNzZ0VTN5Q0dYbU1RWmdhL2NKN2lJdWE0UHYv?= =?utf-8?B?VGdEYkIxeVRxakg1UEhLV0MxWlMrTW45Ry9hc3YxWFNjZXhtb1Znbm1yMDB1?= =?utf-8?B?WEFaUU85OS9XR2FmaWdObEVBWFgvMkllMDVmclg3OFNCU0tlT3JSTnpQeloy?= =?utf-8?B?SlNybEFNMnpHeTFSOUZ6b0pIbzNHeHQ4d0p1QW5ENWdtWU4zc3ArTTM2ZlVG?= =?utf-8?Q?hLdORBD5gHit3/i9PYeYYK4fjtUcZDO7QUGIPFj?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2tpcHdXOUpwd3hkTVFhbW10eS9NMjMwVnhLT2VPQkh0eXE2YmkvUWEyUEFE?= =?utf-8?B?dUpRaVFTcUlJVWNnUlJacm4zQzFaYncwR04ya2wwZ2NnZEtEN3hzL3FxZ3V3?= =?utf-8?B?cDZtNTFDbHhMRzhZbXMrREhoSm1wbi9hMUY5bEJXakE1eHlBM24xWFFtY2kw?= =?utf-8?B?c3NOMldEY2lWQkpNL0wyRGkzeS9FMUo0SnhYcVR2RFk5enFZdVpXZEtZczNQ?= =?utf-8?B?aVZjUlJXcUx2SmFxcHYrRDVITnhBRWh1cEtSaStCTTM0eEMrQU8vYUZwKzcw?= =?utf-8?B?U1JSaW9UejhKNGZUYWhhS2ZFNnpiY25rME92N1dSYUlJbzdlY3pOZHdiZENO?= =?utf-8?B?dUd1UGlubjJGYlV6bXN0eE5xbktpbGdRTG13Q0tBZXRvdzlrcDlDYzJnd2Vp?= =?utf-8?B?ME45K0wvZ1JITnlzdDdYSWtUUXc4ckp0YzZHeGpUN1BFaUhpb20zSmNkMXpJ?= =?utf-8?B?WXNFOTB1cW5SSjJGWDczSXgxcityY005Qzg4Mk5vdU5tVktKZDBGeWgyLzVv?= =?utf-8?B?MHRnU1hMT2NNOFk4YmExNmtyZEVDa1JhSlY5UVZFTDlZVk81dnJUd0p2VmhU?= =?utf-8?B?OXNXeXJnM2xDQ0pCeWpaTndiYzdsNGt4SFMzR1VuVUpyVnVRQVVQSTl3OExm?= =?utf-8?B?eG9qYUhFckc2bWVyM2NmeURLeGF5YlNhdFhoSzNrQm5adExKaHpaUjUrK1h5?= =?utf-8?B?cUg2bVNZc3BYZ2xia1RHMDR0djJtS3JLNU1xOTF0TUlzTUs4OFpqT0xOZCsv?= =?utf-8?B?TG1GN2NFakYwY3VXNWQ4UHFXVHZjQTIwN2VSaS9Hb01SWnhPVjhYLzZmTm5i?= =?utf-8?B?Lzg3S20vMHlwM0hoSnlXbTF6cythaDA1ekVIUEdIT0xpZ0N6aVBPU2krTjNr?= =?utf-8?B?WXF3VElSSlNmVTRzSlk3R2hCM2p1OHVZN1JQejFBZDVlY3A1ZCtiREZhcjkz?= =?utf-8?B?TFVKaUZDY3pEWEw1MEFGdkNUVXpBOE5pTUlnWkZ6TUhDSTdoN3dpNDYzVjhQ?= =?utf-8?B?UW01WExYODQ4NDBraXd1Y0JlN2pQM1ZqOVc4YWVoVU51MVNLK1JEa1BaNmZw?= =?utf-8?B?TExjQ3BZeVBqR0lLZXBWT09TU1I2aVBUZnZiKzVZZ1locHltQWJCMkFaZHFo?= =?utf-8?B?R2IzTVFsWEI0N0R4QmdDK245RWFsdkZDM3FvTk84c0ZwcTJYRjAybXE5a1Bk?= =?utf-8?B?L0RwSDlUSG85dTdqNk11cVQvcDNITC9rS05RaFhRRmZwdUVzV2I1VUdwUUhj?= =?utf-8?B?czMzYk5rNm1YWHgzSkhDa1hGYkszSm0yS0xoQ00xeE1Qck1ZblAwcjgyY0hS?= =?utf-8?B?T3JRbFMrVDQ0QlArQkdua1hFU2NuNTRKc2VjeFBwRkVWbFVCNUcyNWdZOW9s?= =?utf-8?B?Q0FvZ2xwVUtLZHlOMEMvU2VqKzRKeWFub0xjUVBqS1hTN3BndXBiUGpYdXdO?= =?utf-8?B?UmhIZVUzY0FPRksxbHRlVjhxWFV3dDl4VFlrOXBSUSt4MlhuQkdMczVqMjlE?= =?utf-8?B?Y1lTb2xIMTJteWJUcnQ4M0o2V0FGVUNMa3R4RldWY1RoUHpRRk40Tm15RmdR?= =?utf-8?B?YUQ5RTF1akF6blVQbXkyWGpWTTl4SmRhMlkzempKdndvUERseXd3NXZjSlNu?= =?utf-8?B?YjAxNkxkS0V6cUVjVDJwSG9lRjEyK0NIeUZiWHBnL1NGS3h0SzBvZitqaUZR?= =?utf-8?B?QWlmdHRCeFlVNmhwMW9sVEtHWlVGRVlUWDV1dmhHTzZiOUhYbnlTWE00dDY3?= =?utf-8?B?MDZ5NTFWdlNncW1UQ2VxRDJwTStlMjRMbHRad3hvK3QxZjlBaWEvQmlTOVAz?= =?utf-8?B?cDFjclpyY2lZM0MyM2VWLy9VQzlCV0VWQmZXVTBmRUs0blRxQmtZemlsNEJD?= =?utf-8?B?THZtZWVpaUI0UTlreFlLYmxubHpEczhuNGxLZ28rc3NzcVFLQjdTdG41cFN5?= =?utf-8?B?TC9wMkY4RE5ZWm9paWdjaGpsY1U3d2ZMUnRuYS8wUkptQm5ZSyt4U2FOTUJD?= =?utf-8?B?Q051YVNhbXNaWG4vR2xRYkF5MnJoTk1yRnUyekxEN2FkOVB1YXNxa1ZwdGNm?= =?utf-8?B?N3phWkZVcjRyQkc2ZzhyTFpLRlNOdklBd0EzdmlGeDhJM1FNUXU4NVVwMHRH?= =?utf-8?Q?XcwUqU+yTFkuE467909g1uJEt?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6239844-72a3-4bcf-f97e-08dd01e6c440 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 00:21:20.3941 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gaHAQlUQ1MjPMzvsz87dm4RCXrLcqlG7jLydrNUYROwXontmAP/Mo0PoAE7XbkQN X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6750 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/8/2024 12:11 PM, Howard Wang wrote: > Signed-off-by: Howard Wang > --- > doc/guides/nics/features/r8169.ini | 3 ++ > drivers/net/r8169/r8169_compat.h | 16 ++++++ > drivers/net/r8169/r8169_ethdev.c | 48 ++++++++++++++++++ > drivers/net/r8169/r8169_ethdev.h | 3 ++ > drivers/net/r8169/r8169_hw.c | 80 ++++++++++++++++++++++++++++++ > drivers/net/r8169/r8169_hw.h | 6 +++ > 6 files changed, 156 insertions(+) > > diff --git a/doc/guides/nics/features/r8169.ini b/doc/guides/nics/features/r8169.ini > index f36b912c53..b983f7ce55 100644 > --- a/doc/guides/nics/features/r8169.ini > +++ b/doc/guides/nics/features/r8169.ini > @@ -17,6 +17,9 @@ L4 checksum offload = Y > Packet type parsing = Y > Rx descriptor status = Y > Tx descriptor status = Y > +Basic stats = Y > +Extended stats = Y > +Stats per queue = Y > "Extended stats" & "Stats per queue" seems not implemented, at least not yet.